[TC11.51] Copy "Only file of this type" inconsistently leaves selection

Moderators: Hacker, petermad, Stefan2, white

User avatar
white
Power Member
Power Member
Posts: 5895
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC11.51] Copy "Only file of this type" inconsistently leaves selection

Post by *white »

ghisler(Author) wrote: 2025-05-09, 09:33 UTC Thanks for your suggestion. Where would you add this to the help?
You can add it to the explanation of the "Only files of this type" field, under the examples.

Note that whether you add it to the help or not, users may not notice that excluded files remain selected in a large folder and could subsequently delete them accidentally when selecting and deleting other files.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50703
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC11.51] Copy "Only file of this type" inconsistently leaves selection

Post by *ghisler(Author) »

I have added this to the help of 11.55 RC2, please check!
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50703
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC11.51] Copy "Only file of this type" inconsistently leaves selection

Post by *ghisler(Author) »

2white
Could you check this, please?
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5895
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC11.51] Copy "Only file of this type" inconsistently leaves selection

Post by *white »

I see that you used Google translate to translate it to German, and then translated the German text back to English. In this case that's not an improvement of my original text. Was it by accident?

My original text was this:
When using the "Only files of this type" field, Total Commander unselects pre-selected files that are successfully copied, while files excluded by the filter remain selected for further actions, such as copying with a different filter or to another location. Pre-selected folders remain selected if completely skipped by a filter (e.g., "| somedir1\"). However, folders are unselected when processed, even if no files inside are copied (which can feel unintuitive as it suggests no further action is needed).
One other minor consideration is this. When I wrote "However, folders are unselected when processed", I meant when processing a folder has finished. I see that you can read it two ways, and that it was translated in the other meaning to "Ordner werden jedoch bei der Verarbeitung abgewählt". This is not entirely correct and could be fixed by changing "bei der Verarbeitung" into "nach der Verarbeitung", and for English by changing "when processed" into "after processing" (that is, if you keep my original text, which is what I recommend).
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50703
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC11.51] Copy "Only file of this type" inconsistently leaves selection

Post by *ghisler(Author) »

Unfortunately we don't have any native English speakers among the beta testers. I found that your suggestion sounded a bit strange, so I translated it to German, corrected it, and translated it back. What don't you like about that translation?
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5895
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC11.51] Copy "Only file of this type" inconsistently leaves selection

Post by *white »

ghisler(Author) wrote: 2025-05-16, 15:58 UTC Unfortunately we don't have any native English speakers among the beta testers. I found that your suggestion sounded a bit strange, so I translated it to German, corrected it, and translated it back. What don't you like about that translation?
The original wording was carefully chosen to convey specific nuances, flow and readability. By translating it to German and then back to English while keeping the same structure, all those nuances get lost making it harder to read and understand.

But I'm sure the text could be improved upon. As mentioned, the behavior is confusing and hard to explain. Here's another try:
When using the 'Only files of this type' field, files excluded by the filter remain selected. This allows users to copy them later with a different filter or move them to another location. Files that are fully copied are deselected, as they require no further action.
However, when folders are deselected, it does not always mean that no further action is needed. Copied folders are deselected even when partly copied or when nothing was copied at all. This happens because files inside the folder may have been filtered out, and the folder itself might already exist in the target location. Only folders that are completely skipped by the filter (e.g., '| somedir\') will remain selected after the copy operation.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50703
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC11.51] Copy "Only file of this type" inconsistently leaves selection

Post by *ghisler(Author) »

Thanks, that sounds much better! The skipped filter should be '| somedir1\', though.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5895
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC11.51] Copy "Only file of this type" inconsistently leaves selection

Post by *white »

ghisler(Author) wrote: 2025-05-18, 07:49 UTC Thanks, that sounds much better! The skipped filter should be '| somedir1\', though.
Right! (and the 1 can be removed, fixed it)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50703
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC11.51] Copy "Only file of this type" inconsistently leaves selection

Post by *ghisler(Author) »

Please check the updated help of 11.55 RC3.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5895
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC11.51] Copy "Only file of this type" inconsistently leaves selection

Post by *white »

ghisler(Author) wrote: 2025-05-21, 12:49 UTC Please check the updated help of 11.55 RC3.
English and German help tested OK, but I noticed something else on that help page. You don't use hanging indent for theses lists:
If the wildcard characters ? and * are used when copying, the following rules apply:
...
...

Examples:
...
...
That becomes very confusing when using a small window.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50703
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC11.51] Copy "Only file of this type" inconsistently leaves selection

Post by *ghisler(Author) »

You are right, I didn't notice that. I will add the indentation.
Author of Total Commander
https://www.ghisler.com
Post Reply