[BUG][SOLVED!]SizeCheck doesn't work with files >18 chars

[icfu]

Confirmations needed:
http://www.ghisler.ch/board/viewtopic.php?p=77632#77632

When copying single files (not directories) that are too big to fit on target partition, there is no warning anymore, also cancelling the copy process sometimes doesn't work. While testing, TC one time even continued to write on a full partition, the process could not be ended anymore and I had to reset my box.

Update:
In TC 5.51 and 6.03 it works flawlessly, TC 6.50 and upwards fails!

Can anyone confirm that?

It doesn't matter if SizeCheck entry is missing in wincmd.ini or if it is set to SizeCheck=1.

Icfu

[Lefteous]

2icfu
My test results so far:

When internal TC copy method is used
SizeCheck=0 disables size check (as expected)
SizeCheck=1 enables size check (as expected)

When "Compatiblity" copy method is used the size check is performed regardless from the SizeCheck value (unexpected).

I just tested with 6.54 PB 2.

[icfu]

Edit: Ah crap, I am completely confused now. It has nothing to do with DCPP like I thought but only with the files themselves.

Some files issue that warning and some don't and I have no clue how to reproduce that.

No problems in TC 5.51 and 6.03 at least so something seems to have changed with TC 6.50, that's all I can say now.

Please do some tests with different files that are too big, thanks!

Icfu

[ghisler(Author)]

OK, it happens like this: If you use normal or big file copy mode, then size check is performed when SizeCheck=1 (or not set, it's the default).

When using compatibility mode, then no size check is performed. Why? The function CopyFileEx fails immediately when it fails to allocate the requested file size, before a single byte has been copied.

[icfu]

Nope, the problem is not related to that!

I have several files here that are too big and only SOME of them issue the warning, the other DON'T!

NO PROBLEMS whatsoever in TC 5.51 and 6.03 where the warning ALWAYS works, ONLY from TC 6.50 upwards I get strange results.

Please don't tell me I am stupid, because I am short before believing that myself when looking at what TC does here.

Do you want me to create a movie clip? I will gladly do that...

Icfu

[icfu]

I have isolated the bug now!
Not the files itself are the problem but the file length!

The bug occurs only with filenames longer than 18 characters, including the dot and the extension.

So:
123456789012345678 gives a warning
1234567890123456789 does NOT give a warning.

Only in TC 6.50 upwards, lower TC versions are fine!

Icfu

[Lefteous]

Confirmed - OMG

[icfu]

THANK YOU!

I really thought it was time for the asylum...

Icfu

[ghisler(Author)]

NOT confirmed here! I renamed a file to 1234567890123456789 and then tried to copy it with F5 -> got warning that there isn't enough space on target and if I want to continue.

What copy method do you use?

[icfu]

copy method for big files
32K for different drives
10240 for same drive

Doesn't make a difference though, bug occurs no matter if on same drive or different drive.

Icfu

[petermad]

Confirmed here too!

Conditions:
filename of 19 chars
copying a too big file to an USB memory Card
"USB stick" NOT checked in the Copy/Delete config
Big file copy mode - 10240 / 64 k
SizeCheck=1

If I reduce the file name to 18 characters. I get the expected warning about not enough space, but not with 19 characters, here the file copies until 100% and then I get the dialog:
Disk is full!
[Skip] [Cancel]

[icfu]

I have uploaded a demonstration video to my file store.

Icfu

[ghisler(Author)]

Good news: I have tried to reproduce it on Windows XP now, and here I could confirm the error! I have no idea why it is controlled by the length of the file name, though. The problem is that Windows 2000 and lower set a parameter to 0, while XP does not - except for files with names <=18 characters! Anyway, I'm now setting it to 0 myself before the call, so the problem is fixed. Thanks for helping me find this really absurd XP-only error!

[icfu]

I have no idea why it is controlled by the length of the file name, though.

Maybe it helps to compare with TC 5.51 and 6.03 where the problem does not occur?

Thanks for helping me find this really absurd XP-only error!

You're welcome, I had a lot of fun. Thanks for fixing it.

Icfu

[petermad]

The problem seems to be fixed in TC 6.54 pb3