[Misfeature] GroupBox deosn't have XP style

English support forum

Moderators: Hacker, petermad, Stefan2, white

User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

2ghisler(Author)
Yes you are right :oops: It's been a wild guess. I just looked at the msdn and saw there are no parts ans state defined for static controls. :cry:
I support Alextp idea of removing these controls.
User avatar
Alextp
Power Member
Power Member
Posts: 2321
Joined: 2004-08-16, 22:35 UTC
Location: Russian Federation
Contact:

Post by *Alextp »

I support Alextp idea of removing these controls.
Not removing at all - removing out of GroupBoxes.
CoolWater
Power Member
Power Member
Posts: 744
Joined: 2003-03-27, 16:33 UTC

Post by *CoolWater »

ghisler(Author) wrote:Any ideas how to solve this problem?
Just draw the groupbox frame on a label. But the x and cx coords of the frame are < 0 and accordingly > width to cut off the round edges. So you will have a single "separator" line without round edges. Maybe, this is only a solution for the standard/themed xp groupbox frame.

IMHO, there is no appropriate theme function for this task.

Regards,
CoolWater
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50824
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I have implemented your suggestions now, plus a third one, and would like to get your opinion. Have a look at this image, please:
http://ghisler.ch/img/groupbox2.gif

The topmost uses a groupbox inside of a groupbox. The second draws just the top line of a groupbox. The third uses no separator at all. What do you think?
Author of Total Commander
https://www.ghisler.com
User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

2ghisler(Author)
The second draws just the top line of a groupbox.
How did you do that? ;-)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50824
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

That's not difficult - I call DrawThemeBackground, which takes two RECT parameters: The first is the size of the item to be drawn, the second is the clipping rectangle. So I just set the clipping rectangle to the size of the top line, and the item size to +50 pixels to the left and right, and +100 pixels to the bottom. Windows XP then draws a groupbox much larger than the available space, but draws only the part within the available space...
Author of Total Commander
https://www.ghisler.com
User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

2ghisler(Author)
I hope there are no themes around which begin the drawing of the top line a few lines below the top of the rectangle...
User avatar
Flint
Power Member
Power Member
Posts: 3511
Joined: 2003-10-27, 09:25 UTC
Location: Belgrade, Serbia
Contact:

Post by *Flint »

I have implemented your suggestions now, plus a third one, and would like to get your opinion.
Looks very nice! If it works fine (without artefacts), I'd vote for the second variant.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 11.03 / Win10 x64
CoolWater
Power Member
Power Member
Posts: 744
Joined: 2003-03-27, 16:33 UTC

Post by *CoolWater »

Flint wrote:
I have implemented your suggestions now, plus a third one, and would like to get your opinion.
Looks very nice! If it works fine (without artefacts), I'd vote for the second variant.
Support++
User avatar
Alextp
Power Member
Power Member
Posts: 2321
Joined: 2004-08-16, 22:35 UTC
Location: Russian Federation
Contact:

Post by *Alextp »

2ghisler(Author)
I vote for the third (without bevel at all).
User avatar
szlori
Senior Member
Senior Member
Posts: 263
Joined: 2005-01-17, 07:12 UTC
Location: Sydney

Post by *szlori »

I vote for the second one as well.
The horizontal separator adds a nice tidyness to the dialog.
User avatar
Hacker
Moderator
Moderator
Posts: 13144
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

I also vote for second.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
karlchen
Power Member
Power Member
Posts: 4605
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

ghisler(Author) wrote:I have implemented your suggestions now, plus a third one, and would like to get your opinion. Have a look at this image, please:
http://ghisler.ch/img/groupbox2.gif

The topmost uses a groupbox inside of a groupbox. The second draws just the top line of a groupbox. The third uses no separator at all. What do you think?
I definitely prefer the topmost version, the groupbox inside the groupbox.
But I can live with the second version as well.
I am even willing to put up with the separatorless version, if the majority votes for it.

Karl
MX Linux 21.3 64-bit xfce, Total Commander 11.50 64-bit
The people of Alderaan keep on bravely fighting back the clone warriors sent out by the unscrupulous Sith Lord Palpatine.
The Prophet's Song
User avatar
SQUIRE
Senior Member
Senior Member
Posts: 373
Joined: 2005-06-16, 18:07 UTC

Post by *SQUIRE »

I'd take the 3rd option. It's far less cluttered and easier to read without unnecessary margins.
User avatar
majkinetor !
Power Member
Power Member
Posts: 1580
Joined: 2006-01-18, 07:56 UTC
Contact:

Post by *majkinetor ! »

I vote for 4th!
It is less cluttered then all other options, and without margins at all. Acctually, you can't see it at all, but you know it is there, containg your font of choice, layin' invisible there ... and all that...

Now, if we are finished with make-up, can we move on more serious topics, like Unicode, Scripts, Icons in Menus, Multithreading, Unified Command System, Recycle Bin with Folders...


BTW, install WindowBlinds or StyleXP and you will have anything you like there, as you like, you can even create something new, like bold marguins with the little elephants in the middle...
Habemus majkam!
Post Reply