Access violations while editing files inside of ZIP archiv

[NotMyBug]

Seems there is no support in this forum. Neither the author Mr. Ghisler nor another member answers - waiting for two weeks now. Maybe I'm too impatient - however I just wonder. Thought I could get some help here. Maybe I should close the thread...

[fenix_productions]

2NotMyBug

Seems there is no support in this forum. Neither the author Mr. Ghisler nor another member answers - waiting for two weeks now. Maybe I'm too impatient - however I just wonder. Thought I could get some help here. Maybe I should close the thread...

Please, do not think this way. Few people tried to figure out what might be wrong but it looks like no one can reproduce such behaviour or has an idea how to fix it.

The only thing left is waiting for TC 7.50pb1, which should arrive this week (if everything goes OK). I think I can share the information that there had been few bugs with lister plugins which were fixed in private betas, so just wait.

One more thing: last few days were busy for an author because of upcoming public beta release and that might be the reason of no reponse.

[NotMyBug]

Access violation with the new Beta version of TC.
However, there was a new error message providing data which is needed by Mr. Ghisler for debugging, so here it is:

---------------------------
Total Commander
---------------------------
Access violation at address 00401BF5. Write of address 01DE0060.
Please report this error to the Author,
with a description of what you were doing when this error occurred!
Continue execution?

Windows exception: C0000005

Stack trace:

00401BF5 00413E10 7E368732 7E368814

7E3689CB 7E37A439 7E3696C5 004193C9

004193F4 004195AE 0068EFAC 0068EFC7

7C817075 7C81707E
Press Ctrl+C to copy this report!
---------------------------
Ja Nein
---------------------------

[NotMyBug]

and a lot more after pressing 'Continue execution' (this is the second one):

---------------------------
Total Commander
---------------------------
Access violation at address 00401BF5. Write of address 01DE0060.
Please report this error to the Author,
with a description of what you were doing when this error occurred!
Continue execution?

Windows exception: C0000005

Stack trace:

00401BF5 00413E10 7E368732 7E368814

7E378EA9 7E3689CB 7E37A439 7E3696C5

004193C9 004193F4 004195AE 0068EFAC

0068EFC7 7C817075 7C81707E
Press Ctrl+C to copy this report!
---------------------------
Ja Nein
---------------------------

[NotMyBug]

To the author:
Please let me know if you need more data.
In case there is a special debug version of TC available (besides the official beta) I would like to test it too! I have a special interest in the removal of that annoying bug and I will always answer as soon as possible.

[NotMyBug]

And another one, now Invalid pointer operation:


---------------------------
Total Commander
---------------------------
Invalid pointer operation.
Please report this error to the Author,
with a description of what you were doing when this error occurred!
Continue execution?

Delphi exception: EInvalidPointer

Stack trace:

7C812AFB 00413E10 7E368732 7E368814

7E37A011 7E37A037 004427F5 00413E10

7E368732 7E368814 7E378E9E 018BBB6C

7E378EEA 7C91E471 7E3694BC 7E378E0B

018BBEDA 7E378DD7 7E378D75 7E378D89

7E368732 7E368814 7E37A011 7E37A037

004427CB 00413E10 7E368732 7E368814

7E37A011 7E37A996 004435E7 004165BD

004441A2 00417142 00615DC4 004415DD

0044353D 0044005A 00415A2C 00442850

00443282 00413E10 7E368732 7E368814

018779B3 7E37A011 7E37A037 004427F5

00413E10 7E368732 7E368814
Press Ctrl+C to copy this report!
---------------------------
Ja Nein
---------------------------

[petermad]

2NotMyBug

Seems there is no support in this forum. Neither the author Mr. Ghisler nor another member answers

Ok, I have tried to reproduce your bug, so far without luck. I installed SynPlus 2.7.3, packed some txt files and other ANSI files into a zip archive - both in the root of the archive and in subfolders. Changed the archive extension to .xpi - opened the archive and opened different files in Lister with SynPlus as the primary plugin. Edited the files one by one and let TC save the changed files into the xpi archive. No errors so far.

Some questions:
1. Have you tried with a clean ini file (totalcmd.exe /i=new.ini) where SynPlus is the ONLY plugin you install? - maybe there is interference with some other plugin?
2. What number in the plugins list is SynPlus in your current configuration?
3. What kind of files are you editing? - maybe it matters what kind of highlighting scheme that is used?
4. What is the size of the edited files?
5. Could you maybe provide a test.xpi file that crashes your TC which we could test?

.

[NotMyBug]

Note: As I mentioned before USUALLY TC does NOT crash when I edit files inside of those archives! It's rare and occurs randomly.
I have some hundred repacks a day and there usually are times (30 repacks or even a lot more) where TC works without any error.
But it could also happen that I get several crashes in a row, althought all TC instances have been killed by taskmanager (verified) and I started a completely new instance of TC.
I do not think that the crashes are related to filetype, filesize or fileextension in any way - however that's not verified, just my believe.

1. Have you tried with a clean ini file (totalcmd.exe /i=new.ini) where SynPlus is the ONLY plugin you install? - maybe there is interference with some other plugin?

No, but I will do so (with plugins removed)

2. What number in the plugins list is SynPlus in your current configuration?

#12

3. What kind of files are you editing? - maybe it matters what kind of highlighting scheme that is used?

.js, .xul, .dtd, .properties, .rdf - every type made TC crash at least one time

4. What is the size of the edited files?

up to 130.000 bytes

5. Could you maybe provide a test.xpi file that crashes your TC which we could test?

https://addons.mozilla.org/en-US/firefox/addon/7004

[ghisler(Author)]

Thanks for your stack traces. Unfortunately all the addresses within TC are just in Window handling functions like TWinControl.WndProc etc.

The problem with Lister plugins is that once the plugin has been loaded, it's autonomous - it does its own redrawing etc. without intervention from Total Commander. This seems to be happening here too, there are no Total Commander functions directly involved in the crash.

So what advice can I give you? Don't use any lister plugins, and use an extenal editor via F4 instead if this fixes your problems. I'm really sorry that I cannot give you any better advice, but I really cannot reproduce these problems.

[petermad]

I could now reproduce your bug.

After editing around 20 files in
https://addons.mozilla.org/en-US/firefox/downloads/latest/7004/addon-7004-latest.xpi with SynPlus I finally got an AV when saving content\bf.js

Code: Select all

---------------------------
Total Commander
---------------------------
Access violation at address 005549BF. Write of address 00DE3F98.
Please report this error to the Author,
with a description of what you were doing when this error occurred!
Continue execution?

Windows exception: C0000005

Stack trace:

005549BF  00413E10  7E368732  7E368814

7E3689CB  7E37A439  7E3696C5  004193C9

004193F4  004195AE  0068EFAC  0068EFC7

7C817075  7C81707E  
Press Ctrl+C to copy this report!
---------------------------
Ja   Nej   
---------------------------

A little later I got this Inv. pointer operation when saving content\preload.xul:

Code: Select all

---------------------------
Total Commander
---------------------------
Invalid pointer operation.
Please report this error to the Author,
with a description of what you were doing when this error occurred!
Continue execution?

Delphi exception: EInvalidPointer

Stack trace:

7C812AFB  00413E10  7E368732  7E368814

7E3689CB  7E37A439  7E3696C5  004193C9

004193F4  004195AE  0068EFAC  0068EFC7

7C817075  7C81707E  
Press Ctrl+C to copy this report!
---------------------------
Ja   Nej   
---------------------------

I had not restarted TC since the first AV. SynPlus is installed as first (primary) Lister plugin.


EDIT:
A little later I got these two, without even editing any file - just chnaging focus form TC and back:

Code: Select all

---------------------------
Total Commander
---------------------------
Access violation at address 005F4C10. Read of address 0000000C.
Please report this error to the Author,
with a description of what you were doing when this error occurred!
Continue execution?

Windows exception: C0000005

Stack trace:

005F4C10  00413E10  7E368732  7E37BDEF

7E368828  7E379279  7E3792E1  77417796

77417CD4  7E379E5D  7E379E69  773E0FA3

773E0D97  7E368732  7E368814  7E37A011

7E37A037  004427CB  00413E10  7E368732

7E368814  7E37A011  7E37A996  004435E7

004439A4  004330DF  004415DD  0044353D

00432E81  00442850  00443282  00413E10

7E368732  7E368814  7E37A011  7E37A037

004427F5  00413E10  7E368732  7E368814

746F13D7  7E378E9E  7E3778CE  7E3778DE

7E378EEA  7C90E471  7E3694D0  7E378F0E

7E37A439  7E3696C5  004193C9  
Press Ctrl+C to copy this report!
---------------------------
Ja   Nej   
---------------------------

Code: Select all

---------------------------
Application Error
---------------------------
Exception EAccessViolation in module TOTALCMD.EXE at 0001F321.
Access violation at address 0042054D. Read of address 8BFFFFFA.
---------------------------
OK   
---------------------------

Whereafter TC totally crashed.

[ghisler(Author)]

2petermad
Address 005549BF is interesting, it's in code where the changed file has just been re-packed. Does the error occur just after re-packing the viewed file to the .xpi, or does it occur while editing the file?

[NotMyBug]

Big thanks to PeterMad for those successful efforts. I know that it isn't easy to reproduce this bug and there seems no way to trigger it by execution of a special task or by special behaviour. Please note that I got the same crashes with other editor plugins too, even with non-Syn ones.

To Mr. Ghisler:
I know your valuable time is very limited, so please just ignore my proposal if inadequate...:
It would be helpful to have a *very* simple editor plugin where *you* own the source code and with some exception handling inside implemented. Delphi should provide a simple control to do so.

[petermad]

Does the error occur just after re-packing the viewed file to the .xpi

Yes.

[NotMyBug]

(first exception within a TC session)
---------------------------
Total Commander
---------------------------
Access violation at address 005549BF. Write of address 02CD7FA0.
Please report this error to the Author,
with a description of what you were doing when this error occurred!
Continue execution?

Windows exception: C0000005

Stack trace:

005549BF 00413E10 7E368732 7E368814

7E3689CB 7E37A439 7E3696C5 004193C9

004193F4 004195AE 0068EFAC 0068EFC7

7C817075 7C81707E
Press Ctrl+C to copy this report!
---------------------------
Ja Nein
---------------------------

[NotMyBug]

2Mr. Ghisler:

This might be important to know if you try to define the exact time of error occurrence:
When restarting a crashed TC and reopening the same file inside of a XPI, then TC asks me to overwrite/skip/etc. that file which obviously had not been deleted from TC's cache folder (due to the crash).
That means that the crash happens before TC erases the cached copy after repackaging has been done.