[9.0b1x86] Too flat interface

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

Sob
Power Member
Power Member
Posts: 945
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

I assume you can detect classic theme (= themes disabled). So if you showed lines in this case, no one would complain, because those with classic theme like lines. ;)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, that would be doable, I will check it.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

These modern borderless interfaces make me sick.

Please make it optional and disabled by default for such people that complain about too many lines. At least one-pixel depth would be appreciated.
Support+
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Sorry but fine tuning these lines for all possible combinations of displayed/hidden elements and various themes takes dozens of hours each time, I can't offer multiple variations here. It's just not feasible.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

At least borders for file panels would be nice. You don't need to draw borders manually in classic theme: Windows does it for you.

I've added WS_EX_STATICEDGE (0x20000) extended style to TMyListBox, and it looks pretty nice.
I've added this style for path bar in tabbed mode too, and it looks JUST PERFECT! But don't add this style to path bar in non-tabbed mode or border will be too thick.

Screensnot

I would add this style too for other TC windows, e.g. quick view window or separate trees (thin border looks better).
User avatar
wanderer
Power Member
Power Member
Posts: 1640
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Post by *wanderer »

MVV wrote:These modern borderless interfaces make me sick.
Using non-flat UI here. While in general i agree with MVV's statement, i have to say that the new TC look is indeed better than the pre-9 versions.

The only thing i agree needs a touch is the path bars (config / show current directory). It's the only thing that struck to me as strange from b1.
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3 (very rarely nowadays).
x64: Clients/Servers - Win10/Win11 and Win2K16 to Win2K22, mainly Win10 though.
User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

While it looked really horrible in beta 1 I just tested beta 2 in classic theme and it looks okay.

Some hints though:

There is no a real left file panel border which is different to the Aero theme. I don't think it's intentional?

The flat look isn't really flat. The bottom and right border look just as 3D as in non-flat mode which is also strange.
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2MVV
Screensnot
The bottom one looks perfect to mee too. +++
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Sob
Power Member
Power Member
Posts: 945
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

2Lefteous: In other words, you got used to it. Or are you trying to fool us? ;) Because with classic theme there's almost zero difference between beta 1 and 2. I even took screenshots and let image program show differences between the two. Those are number in title (obviously) and icon on active tab positioned higher by two pixels. And that's it, not a single pixel more.

2MVV: Based on your idea, my Plan B, version 0.1 alpha. :)
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

petermad wrote:The bottom one looks perfect to mee too. +++
I hope Christian will add this style. :)
Sob wrote:2Lefteous: In other words, you got used to it. Or are you trying to fool us? ;) Because with classic theme there's almost zero difference between beta 1 and 2. I even took screenshots and let image program show differences between the two. Those are number in title (obviously) and icon on active tab positioned higher by two pixels. And that's it, not a single pixel more.
Agree. There are no differences between b1 and b2 in classic theme (for ones that get accustomed to classic themes). Borders are 100% the same, only differences are in drive bar (b2 has OldDriveIcons=2 option) and in icon fading (b1 fades hidden icons when IconLib=%COMMANDER_EXE% is set while b2x86 not - but b2x64 fades them too).
Sob wrote:2MVV: Based on your idea, my Plan B, version 0.1 alpha. :)
It would be better to create a DLL for loading via Autorun plugin, and this DLL should also set the style for path bars when tabs are shown and hide when there are no tabs. :)
User avatar
Lefteous
Power Member
Power Member
Posts: 9537
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

2Sob
In other words, you got used to it. Or are you trying to fool us?
Neither of them. I found the reason for the missing panel border where the hotlist and history buttons are placed. When folder tabs are not displayed there is no border.
As I tested with folder tabs displayed I thought it was a change from beta 1 to beta 2. Sorry for the confusion.

But let's face it It's really just a bug. I don't think this is intentional.

Please also note that I critized to other points in my previous post. There is also another point. The inconsistency between 3D and flat separators remains though.

The discussion between flat and 3D is also pointless as this is a already a general UI option. People could about the default though.
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

ghisler(Author),
Thank you for returning file panel borders in 9.0b3!
However path bar in tabbed mode is still flat...

What about adding WS_EX_STATICEDGE style to path bars (in tabbed mode) and file panels (always) to get nicer borders like on screenshot here?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I think that the path panel looks better this way...
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3506
Joined: 2003-10-27, 09:25 UTC
Location: Belgrade, Serbia
Contact:

Post by *Flint »

I gather, the changes were made only for Classic themes? I'm using Windows 7 with Aero, and do not see any difference. But surely Windows 7 cannot be called "flat", therefore I think the changes should also apply to its non-classic themes.

BTW, I, too, think that the whole "flat interface" concept looks horrible. Without delimiters I often think that the file name in the status bar is just one more file in the file panel, and it takes me a couple of seconds to understand why cursor refuses to move onto it.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 11.03 / Win10 x64
User avatar
wanderer
Power Member
Power Member
Posts: 1640
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Post by *wanderer »

MVV wrote:However path bar in tabbed mode is still flat...
ghisler(Author) wrote:I think that the path panel looks better this way...
I have a blue panel background. When i edit the path bar (breadcrumbs disabled here), its background color becomes blue too. Without at least 1px separator line, it looks extremely flat. OK, granted, maybe the choice of colors is not the best out there but a 1px separator line might not look that bad. Is there a chance of having one in the next beta, just to see how it goes?

Settings: flat UI NOT checked, XP themed mode checked, Win7.
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3 (very rarely nowadays).
x64: Clients/Servers - Win10/Win11 and Win2K16 to Win2K22, mainly Win10 though.
Post Reply