When using dark mode and searching for duplicates: no dashed lines in search results panel

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

User avatar
white
Power Member
Power Member
Posts: 5743
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *white »

sa16 wrote: 2024-12-25, 10:35 UTC It is not good that we would have to change the behavior that has existed for 14 years. But there would be an analogy with F8(Del) and Shift+F8(Del) and the UseTrash option...
It is good if the behavior was confusing for 14 years, not documented, and contrary to what the Help says:
Help wrote:SearchKeepLast=1
Keep last search results when closing "Find files" dialog, except after "Feed in Listbox"
sa16
Senior Member
Senior Member
Posts: 324
Joined: 2021-09-10, 07:15 UTC

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *sa16 »

Also here:
History.txt wrote:10.11.10 Release Total Commander 7.56 beta 1
10.11.10 Added: Find files: Remember last search results when using "Go to file" or "Cancel" (but not when using "Feed to listbox"). Turn off with SearchKeepLast=0 in wincmd.ini
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *ghisler(Author) »

Sorry but I'm definitely NOT going to change this behavior now. Currently people can choose to keep or not keep the results depending on how they close the search dialog. This would be lost if I always saved it. It could be solved with more options for the SearchKeepLast option, but I don't want to add new features in RC versions. It would extend the beta test forever.

Moderator message from: ghisler(Author) » 2024-12-26, 09:12 UTC

Moved (for now) to will not be changed
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5743
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *white »

ghisler(Author) wrote: 2024-12-26, 09:12 UTC Sorry but I'm definitely NOT going to change this behavior now. Currently people can choose to keep or not keep the results depending on how they close the search dialog. This would be lost if I always saved it. It could be solved with more options for the SearchKeepLast option, but I don't want to add new features in RC versions. It would extend the beta test forever.
Again, you are not providing clarity if and when it will be changed, only that it will not be changed right now. If there is a chance that this will remain unchanged for years to come or indefinitely, shouldn't the behavior then be documented?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *ghisler(Author) »

Well, the history documents that it is only guaranteed to be saved when using "Go to file" or "Cancel".
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5743
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *white »

ghisler(Author) wrote: 2024-12-27, 07:45 UTC Well, the history documents that it is only guaranteed to be saved when using "Go to file" or "Cancel".
The user is already lucky if he can find information about it in the Help. The functionality is not explained in the Help about the search function, but only in the Help about the SearchKeepLast setting in wincmd.ini. The user can of course not be expected to scan the entire changelog to find out how the search function works. Furthermore, an entry in the changelog is merely a shorthand indication of a change to the program. It is of course not program documentation describing the functionality of the program. If it is, then a lot of changelog entries (if not most) need to be changed because they are not accurate in that sense.
Post Reply