2Ghisler
Yes, the installer work good now!
but when i do testing i found something wrong with the Uninstaller, try this:
1- install TC and choose program directory for ini files
2- after installation complete, open regedit and delete both Ghisler keys under HKLM & HKCU
3- run TCUNINST.EXE and select "Remove configuration file ..." option.
you will recieve a warning message for deleting "C:\Windows\wincmd.ini" while this file isn't exist at all.
it seems that when the Uninstaller doesn't find "IniFileName" & "FtpIniName" in the registry, it consider the TC setting files are inside %Windir% and popup a waning message without check the exist of the both file
maybe it will be nice if you adding some extra lines of code to check the existense of %windir%\wincmd.ini and %windir%\wcx_ftp.ini
it is not very important so you can do it or not!
BTW: if only "C:\Windows\wcx_ftp.ini" is exist, the warning message will include both "C:\Windows\wincmd.ini" & "C:\Windows\wcx_ftp.ini" , this mean that you already do a check for the existense of wcx_ftp.ini
[Beta] installer bug
Moderators: Hacker, petermad, Stefan2, white
2Ghisler
Sorry, but after extra testing the bug still exist, this time in reverse order try this:
1- press "Change ini file location" button and select Program directory option or any other option.
2- press "Back"
3- press "Back" (someone could do this to review the installing folder)
4- press "Next"
5- press "Change ini file location" button again and you will see your choices have been losted.
if you complete the installation without pressing "Change ini file location" button again, you will find that "IniFileName" & "FtpIniName" aren't written to the registry and TC locates wincmd.ini inside Windows folder not the specified location while installing.
Note: the location options are saved only when pressing "Next" button immediately after changing them and pressing "Back" will not reset them.
Sorry, but after extra testing the bug still exist, this time in reverse order try this:
1- press "Change ini file location" button and select Program directory option or any other option.
2- press "Back"
3- press "Back" (someone could do this to review the installing folder)
4- press "Next"
5- press "Change ini file location" button again and you will see your choices have been losted.
if you complete the installation without pressing "Change ini file location" button again, you will find that "IniFileName" & "FtpIniName" aren't written to the registry and TC locates wincmd.ini inside Windows folder not the specified location while installing.
Note: the location options are saved only when pressing "Next" button immediately after changing them and pressing "Back" will not reset them.
-
ghisler(Author)
- Site Admin
- Posts: 50475
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
2ts4242
Currently TC doesn't remember the ini file settings when you use the back button, only when you use the forward button. This is intentional, e.g. for users who played around with these rather complex settings, but didn't really understand them. Yes, it's different from the other installation dialogs, but I think that it shouldn't be changed. What do you think?
Currently TC doesn't remember the ini file settings when you use the back button, only when you use the forward button. This is intentional, e.g. for users who played around with these rather complex settings, but didn't really understand them. Yes, it's different from the other installation dialogs, but I think that it shouldn't be changed. What do you think?
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
2Ghisler
in my opinion the installer must remember all settings changed by the user regardless of he understand these settings or not. you cannot guarantee that who press "Back" immediately after changing ini location is just playing!
indeed a user do a mistake while installing is better than your installer do this mistake! (he can run the installer again to correct what he need)
beside that now TC actually remember the ini file settings when you press "Back" button if you changed ini location and pressed "Next" as follow:
1- change ini location
2- press "Next"
3- press "Back" twice
4- press "Next"
5- change ini location to different location
6- press "Back"
7- press "Change ini..." button and you will find the old setting (step 1) not the recent setting (step 5)
in my opinion the installer must remember all settings changed by the user regardless of he understand these settings or not. you cannot guarantee that who press "Back" immediately after changing ini location is just playing!
indeed a user do a mistake while installing is better than your installer do this mistake! (he can run the installer again to correct what he need)
beside that now TC actually remember the ini file settings when you press "Back" button if you changed ini location and pressed "Next" as follow:
1- change ini location
2- press "Next"
3- press "Back" twice
4- press "Next"
5- change ini location to different location
6- press "Back"
7- press "Change ini..." button and you will find the old setting (step 1) not the recent setting (step 5)