[WFX] Android ADB 8.8

Discuss and announce Total Commander plugins, addons and other useful tools here, both their usage and their development.

Moderators: Hacker, petermad, Stefan2, white

Post Reply
jakubklos
Senior Member
Senior Member
Posts: 221
Joined: 2012-07-11, 14:48 UTC

Re: Deleting files doesnt work

Post by *jakubklos »

ricobautsch wrote:I tried this very useful plugin.
All seems to be ok so far, except deleting files.
If i try to delete a file on sd-card, i get the question "Should the selected file xxx really be deleted?" and then nothing happens, the file remains on the sd-card.
Copying files from/to sd-card works ok.
Hi there,
that is weird. Anyway, enable "Debug logging to TC FTP connection bar" and do the delete again. Then send me the logs from the connection bar.
ricobautsch
Member
Member
Posts: 103
Joined: 2005-06-21, 00:42 UTC

Post by *ricobautsch »

I see in the log a "permission denied" message when i try to delete the Muster1.png.
What's wrong with the permissions, i copied the file with your plugin to the device some moments ago.
Here is a excerpt of the log:

Code: Select all

Connecting to ADB server...
Connected
ADB Write: host:transport:HT09JPL01885
ADB Read: OKAY
ADB Write: shell:ls -l "/mnt/sdcard/temp/"
ADB Read: OKAY
ADB Read Data: ----rwxr-x system   sdcard_rw    16276 2012-09-07 14:44 Muster1.png
Connecting to ADB server...
Connected
ADB Write: host:transport:HT09JPL01885
ADB Read: OKAY
ADB Write: shell:busybox rm -f "/mnt/sdcard/temp/Muster1.png"
ADB Read: OKAY
ADB Read Data: busybox: permission denied
Connecting to ADB server...
Connected
ADB Write: host:transport:HT09JPL01885
ADB Read: OKAY
ADB Write: shell:su -c "busybox rm -f \"/mnt/sdcard/temp/Muster1.png\""
ADB Read: OKAY
ADB Read Data: su: permission denied
Connecting to ADB server...
Connected
ADB Write: host:transport:HT09JPL01885
ADB Read: OKAY
ADB Write: shell:ls -l "/mnt/sdcard/temp/"
ADB Read: OKAY
ADB Read Data: ----rwxr-x system   sdcard_rw    16276 2012-09-07 14:44 Muster1.png
jakubklos
Senior Member
Senior Member
Posts: 221
Joined: 2012-07-11, 14:48 UTC

Post by *jakubklos »

ricobautsch wrote:I see in the log a "permission denied" message when i try to delete the Muster1.png.
What's wrong with the permissions, i copied the file with your plugin to the device some moments ago.
Here is a excerpt of the log:

Code: Select all

Connecting to ADB server...
Connected
ADB Write: host:transport:HT09JPL01885
ADB Read: OKAY
ADB Write: shell:ls -l "/mnt/sdcard/temp/"
ADB Read: OKAY
ADB Read Data: ----rwxr-x system   sdcard_rw    16276 2012-09-07 14:44 Muster1.png
Connecting to ADB server...
Connected
ADB Write: host:transport:HT09JPL01885
ADB Read: OKAY
ADB Write: shell:busybox rm -f "/mnt/sdcard/temp/Muster1.png"
ADB Read: OKAY
ADB Read Data: busybox: permission denied
Connecting to ADB server...
Connected
ADB Write: host:transport:HT09JPL01885
ADB Read: OKAY
ADB Write: shell:su -c "busybox rm -f "/mnt/sdcard/temp/Muster1.png""
ADB Read: OKAY
ADB Read Data: su: permission denied
Connecting to ADB server...
Connected
ADB Write: host:transport:HT09JPL01885
ADB Read: OKAY
ADB Write: shell:ls -l "/mnt/sdcard/temp/"
ADB Read: OKAY
ADB Read Data: ----rwxr-x system   sdcard_rw    16276 2012-09-07 14:44 Muster1.png
Ok there are 2 possibilities

1. You are not properly rooted and it misbehaves - we need to verify this
2. The rights on sdcard are somewhat incorrect and files cannot be deleted via adb.

Does this work for you?
"rm /mnt/sdcard/temp/Muster1.png"

If yes, I will update it so it will handle the 1) issue. If it does not work you should get a different ROM or kernel.

Let me know
ricobautsch
Member
Member
Posts: 103
Joined: 2005-06-21, 00:42 UTC

Post by *ricobautsch »

Im not sure what you mean with "properly rooted". My device is NOT rootet, it's in original state.

The "rm /mnt/sdcard/...." works, the file can be deleted this way.

Deleting with the plugin does not work, even with your new 3.2 Version of the plugin.
jakubklos
Senior Member
Senior Member
Posts: 221
Joined: 2012-07-11, 14:48 UTC

Post by *jakubklos »

ricobautsch wrote:Im not sure what you mean with "properly rooted". My device is NOT rootet, it's in original state.

The "rm /mnt/sdcard/...." works, the file can be deleted this way.

Deleting with the plugin does not work, even with your new 3.2 Version of the plugin.
Well, your phone is indeed semi-rooted. That is why it responds with "Permission denied" to commands busybox and su (these can be found only on rooted devices). Otherwise it would respond with "busybox: not found" or similar.

Anyway, I have fixed it in the code so it also expects such behavior and works now. 3.3 is coming
jakubklos
Senior Member
Senior Member
Posts: 221
Joined: 2012-07-11, 14:48 UTC

New version 3.3

Post by *jakubklos »

I have released a new version with plenty of reworks. It is all related to the screenshot functionality and install/uninstall.

Originally, I used some external tools or adb executable for that. In this new version I wrote my own code to do these and it works perfect since I am able to use the file transfer progress indication now.

It is also a lot faster. Hope you like it
3.3
- New: Screenshot function uses internal functions and java is not used anymore (uses native ICS "screenshot" command or adb framebuffer:) (faster screenshots and file transfer progress)
- Update: Install and Uninstall in .apps folder does not use adb binary, push and pm command is used (allows you to see the file transfer progress)
- Update: In special cases native linux command used when "Permission denied" response detected
sheppaul
Member
Member
Posts: 134
Joined: 2003-12-05, 07:59 UTC

Post by *sheppaul »

Hello,
Thanks for this great plugin first!

I have a small question while trying your plugin. (I do not root my phone)

1. About installing apk to phone.
It would be nice if the plugin let me know the status of installation. After copying apk to .apps, I think there should be some kinds of notice (in the plugin or phone).

2. About .apps folder
The folder is empty even when apks are installed. Is it normal?
Only using TCMD x64. :)
jakubklos
Senior Member
Senior Member
Posts: 221
Joined: 2012-07-11, 14:48 UTC

Post by *jakubklos »

sheppaul wrote:Hello,
Thanks for this great plugin first!

I have a small question while trying your plugin. (I do not root my phone)

1. About installing apk to phone.
It would be nice if the plugin let me know the status of installation. After copying apk to .apps, I think there should be some kinds of notice (in the plugin or phone).

2. About .apps folder
The folder is empty even when apks are installed. Is it normal?
Hi, thank you.

1) Since the new version has a complete control of the installation process I know exactly if installing an app fails. So instead I would suggest returning an error if there is a problem. Copyig a file to a folder also does not inform you the file copy succeeded. What do you think? Do you have any negative experience with installing apps so you would like a confirmation? Let me know

2) You should enable logging and send me the logs. The plugin is able to displays apps even on non-rooted phones via the "pm" command. The question is if it works on your phone or if there is some other problem. The logs will tell us more

Jakub
pavelmx
New Member
New Member
Posts: 1
Joined: 2012-09-17, 00:22 UTC

Post by *pavelmx »

ricobautsch wrote:Im not sure what you mean with "properly rooted". My device is NOT rootet, it's in original state.

The "rm /mnt/sdcard/...." works, the file can be deleted this way.

Deleting with the plugin does not work, even with your new 3.2 Version of the plugin.
Same problem with deleting on SGS3 (ICS) stock (rooted), but delete files in \mnt\sdcard works fine, only with \mnt\extSdCard I have problem in my case. "rm /mnt/extsdcard/...." on extSdCard doesn't works too. "Ls" command works in terminal, but not sure busybox installed correctly.
I think this is MTP peculiarity. May be I must somehow unmount extSdCard for RW? I heard something about "sysrw" command, can you explain it for me.
ricobautsch
Member
Member
Posts: 103
Joined: 2005-06-21, 00:42 UTC

Post by *ricobautsch »

I have just installed your new version 3.4.
For me it's working now, i can delete the files properly.
Thanx.
sheppaul
Member
Member
Posts: 134
Joined: 2003-12-05, 07:59 UTC

Post by *sheppaul »

jakubklos wrote: Hi, thank you.

1) Since the new version has a complete control of the installation process I know exactly if installing an app fails. So instead I would suggest returning an error if there is a problem. Copyig a file to a folder also does not inform you the file copy succeeded. What do you think? Do you have any negative experience with installing apps so you would like a confirmation? Let me know

2) You should enable logging and send me the logs. The plugin is able to displays apps even on non-rooted phones via the "pm" command. The question is if it works on your phone or if there is some other problem. The logs will tell us more

Jakub

"Do you have any negative experience with installing apps so you would like a confirmation?"

When I'm trying this plugin for the first time, it's hard to know the way to install apk from hard disk. I think it's rather unintuitive. Even when the copy (installation) process was finished, I didn't know what it means. What about adding help tab in options of ADB plugin? :)

Code: Select all

2012-09-17 16:30:49 [1638] Connecting to ADB server...
2012-09-17 16:30:49 [1638] Connected
2012-09-17 16:30:49 [1638] ADB Write: host:devices
2012-09-17 16:30:49 [1638] ADB Read: 00095dac01875f	device
2012-09-17 16:30:56 [1638] Connecting to ADB server...
2012-09-17 16:30:56 [1638] Connected
2012-09-17 16:30:56 [1638] ADB Write: host:transport:00095dac01875f
2012-09-17 16:30:56 [1638] ADB Read: OKAY
2012-09-17 16:30:56 [1638] ADB Write: shell:ls -l "/"
2012-09-17 16:30:56 [1638] ADB Read: OKAY
2012-09-17 16:30:56 [1638] ADB Read Data: drwxr-xr-x root     root              2012-09-17 02:26 acct
drwxrwx--- system   cache             2012-09-17 15:37 cache
dr-x------ root     root              2012-09-17 02:26 config
lrwxrwxrwx root     root              2012-09-17 02:26 d -> /sys/kernel/debug
drwxrwx--x system   system            2012-09-17 02:26 data
-rw-r--r-- radio    radio         129 2012-08-07 17:00 default.prop
drwxr-xr-x root     root              2012-09-17 02:26 dev
drwxrwx--x radio    system            2011-01-01 00:02 efs
lrwxrwxrwx root     root              2012-09-17 02:26 etc -> /system/etc
-rwxr-xr-x radio    radio        3262 2012-08-07 17:00 fota.rc
-rwxr-xr-x radio    radio      131552 2012-08-07 17:09 init
-rw-r--r-- radio    radio        2344 2012-08-07 17:00 init.goldfish.rc
-rw-r--r-- radio    radio       34585 2012-08-07 17:00 init.rc
-rwxr-xr-x radio    radio        5844 2012-08-07 17:00 init.shw-m250s.rc
-rwxr-xr-x radio    radio        4888 2012-08-07 17:00 init.shw-m250s.usb.rc
drwxr-xr-x radio    radio             2012-08-07 17:22 lib
-rwxr-xr-x radio    radio        1634 2012-08-07 17:00 lpm.rc
drwxrwxr-x root     system            2012-09-17 02:26 mnt
drwxrwx--x system   system            2012-09-17 02:26 preload
dr-xr-xr-x root     root              1970-01-01 09:00 proc
-rw-r--r-- radio    radio        1782 2012-08-07 17:09 recovery.rc
drwxr-xr-x radio    radio             2012-08-07 17:22 res
drwxr-xr-x radio    radio             2012-08-07 17:22 sbin
lrwxrwxrwx root     root              2012-09-17 02:26 sdcard -> /mnt/sdcard
drwxr-xr-x root     root              2012-09-17 02:26 sys
drwxr-xr-x root     root              1970-01-01 09:00 system
drwxr-xr-x radio    radio             2012-08-07 17:22 tmp
-rw-r--r-- radio    radio         272 2012-08-07 17:00 ueventd.goldfish.rc
-rw-r--r-- radio    radio        3873 2012-08-07 17:00 ueventd.rc
-rwxr-xr-x radio    radio        1587 2012-08-07 17:00 ueventd.shw-m250s.rc
drwxr-xr-x radio    radio             2012-08-07 17:22 vendor
2012-09-17 16:30:57 [1638] Connecting to ADB server...
2012-09-17 16:30:57 [1638] Connected
2012-09-17 16:30:57 [1638] ADB Write: host:transport:00095dac01875f
2012-09-17 16:30:57 [1638] ADB Read: OKAY
2012-09-17 16:30:57 [1638] ADB Write: shell:ls -l "/data/app/"
2012-09-17 16:30:58 [1638] ADB Read: OKAY
2012-09-17 16:30:58 [1638] ADB Read Data: opendir failed, Permission denied
2012-09-17 16:30:58 [1638] Connecting to ADB server...
2012-09-17 16:30:58 [1638] Connected
2012-09-17 16:30:58 [1638] ADB Write: host:transport:00095dac01875f
2012-09-17 16:30:58 [1638] ADB Read: OKAY
2012-09-17 16:30:58 [1638] ADB Write: shell:su -c "ls -l "/data/app/""
2012-09-17 16:30:58 [1638] ADB Read: OKAY
2012-09-17 16:30:58 [1638] ADB Read Data: /system/bin/sh: su: not found
2012-09-17 16:31:00 [1638] Connecting to ADB server...
2012-09-17 16:31:00 [1638] Connected
2012-09-17 16:31:00 [1638] ADB Write: host:transport:00095dac01875f
2012-09-17 16:31:00 [1638] ADB Read: OKAY
2012-09-17 16:31:00 [1638] ADB Write: shell:ls -l "/"
2012-09-17 16:31:00 [1638] ADB Read: OKAY
2012-09-17 16:31:00 [1638] ADB Read Data: drwxr-xr-x root     root              2012-09-17 02:26 acct
drwxrwx--- system   cache             2012-09-17 15:37 cache
dr-x------ root     root              2012-09-17 02:26 config
lrwxrwxrwx root     root              2012-09-17 02:26 d -> /sys/kernel/debug
drwxrwx--x system   system            2012-09-17 02:26 data
-rw-r--r-- radio    radio         129 2012-08-07 17:00 default.prop
drwxr-xr-x root     root              2012-09-17 02:26 dev
drwxrwx--x radio    system            2011-01-01 00:02 efs
lrwxrwxrwx root     root              2012-09-17 02:26 etc -> /system/etc
-rwxr-xr-x radio    radio        3262 2012-08-07 17:00 fota.rc
-rwxr-xr-x radio    radio      131552 2012-08-07 17:09 init
-rw-r--r-- radio    radio        2344 2012-08-07 17:00 init.goldfish.rc
-rw-r--r-- radio    radio       34585 2012-08-07 17:00 init.rc
-rwxr-xr-x radio    radio        5844 2012-08-07 17:00 init.shw-m250s.rc
-rwxr-xr-x radio    radio        4888 2012-08-07 17:00 init.shw-m250s.usb.rc
drwxr-xr-x radio    radio             2012-08-07 17:22 lib
-rwxr-xr-x radio    radio        1634 2012-08-07 17:00 lpm.rc
drwxrwxr-x root     system            2012-09-17 02:26 mnt
drwxrwx--x system   system            2012-09-17 02:26 preload
dr-xr-xr-x root     root              1970-01-01 09:00 proc
-rw-r--r-- radio    radio        1782 2012-08-07 17:09 recovery.rc
drwxr-xr-x radio    radio             2012-08-07 17:22 res
drwxr-xr-x radio    radio             2012-08-07 17:22 sbin
lrwxrwxrwx root     root              2012-09-17 02:26 sdcard -> /mnt/sdcard
drwxr-xr-x root     root              2012-09-17 02:26 sys
drwxr-xr-x root     root              1970-01-01 09:00 system
drwxr-xr-x radio    radio             2012-08-07 17:22 tmp
-rw-r--r-- radio    radio         272 2012-08-07 17:00 ueventd.goldfish.rc
-rw-r--r-- radio    radio        3873 2012-08-07 17:00 ueventd.rc
-rwxr-xr-x radio    radio        1587 2012-08-07 17:00 ueventd.shw-m250s.rc
drwxr-xr-x radio    radio             2012-08-07 17:22 vendor
2012-09-17 16:31:09 [1638] Connecting to ADB server...
2012-09-17 16:31:09 [1638] Connected
2012-09-17 16:31:09 [1638] ADB Write: host:devices
2012-09-17 16:31:09 [1638] ADB Read: 00095dac01875f	device
2012-09-17 16:31:13 [1638] Connecting to ADB server...
2012-09-17 16:31:13 [1638] Connected
2012-09-17 16:31:13 [1638] ADB Write: host:devices
2012-09-17 16:31:13 [1638] ADB Read: 00095dac01875f	device
2012-09-17 16:42:07 [1638] Connecting to ADB server...
2012-09-17 16:42:07 [1638] Connected
2012-09-17 16:42:07 [1638] ADB Write: host:devices
2012-09-17 16:42:07 [1638] ADB Read: 00095dac01875f	device
2012-09-17 16:42:09 [1638] Connecting to ADB server...
2012-09-17 16:42:09 [1638] Connected
2012-09-17 16:42:09 [1638] ADB Write: host:transport:00095dac01875f
2012-09-17 16:42:09 [1638] ADB Read: OKAY
2012-09-17 16:42:09 [1638] ADB Write: shell:ls -l "/"
2012-09-17 16:42:09 [1638] ADB Read: OKAY
2012-09-17 16:42:09 [1638] ADB Read Data: drwxr-xr-x root     root              2012-09-17 02:26 acct
drwxrwx--- system   cache             2012-09-17 16:38 cache
dr-x------ root     root              2012-09-17 02:26 config
lrwxrwxrwx root     root              2012-09-17 02:26 d -> /sys/kernel/debug
drwxrwx--x system   system            2012-09-17 02:26 data
-rw-r--r-- radio    radio         129 2012-08-07 17:00 default.prop
drwxr-xr-x root     root              2012-09-17 02:26 dev
drwxrwx--x radio    system            2011-01-01 00:02 efs
lrwxrwxrwx root     root              2012-09-17 02:26 etc -> /system/etc
-rwxr-xr-x radio    radio        3262 2012-08-07 17:00 fota.rc
-rwxr-xr-x radio    radio      131552 2012-08-07 17:09 init
-rw-r--r-- radio    radio        2344 2012-08-07 17:00 init.goldfish.rc
-rw-r--r-- radio    radio       34585 2012-08-07 17:00 init.rc
-rwxr-xr-x radio    radio        5844 2012-08-07 17:00 init.shw-m250s.rc
-rwxr-xr-x radio    radio        4888 2012-08-07 17:00 init.shw-m250s.usb.rc
drwxr-xr-x radio    radio             2012-08-07 17:22 lib
-rwxr-xr-x radio    radio        1634 2012-08-07 17:00 lpm.rc
drwxrwxr-x root     system            2012-09-17 02:26 mnt
drwxrwx--x system   system            2012-09-17 02:26 preload
dr-xr-xr-x root     root              1970-01-01 09:00 proc
-rw-r--r-- radio    radio        1782 2012-08-07 17:09 recovery.rc
drwxr-xr-x radio    radio             2012-08-07 17:22 res
drwxr-xr-x radio    radio             2012-08-07 17:22 sbin
lrwxrwxrwx root     root              2012-09-17 02:26 sdcard -> /mnt/sdcard
drwxr-xr-x root     root              2012-09-17 02:26 sys
drwxr-xr-x root     root              1970-01-01 09:00 system
drwxr-xr-x radio    radio             2012-08-07 17:22 tmp
-rw-r--r-- radio    radio         272 2012-08-07 17:00 ueventd.goldfish.rc
-rw-r--r-- radio    radio        3873 2012-08-07 17:00 ueventd.rc
-rwxr-xr-x radio    radio        1587 2012-08-07 17:00 ueventd.shw-m250s.rc
drwxr-xr-x radio    radio             2012-08-07 17:22 vendor
2012-09-17 16:42:11 [1638] Connecting to ADB server...
2012-09-17 16:42:11 [1638] Connected
2012-09-17 16:42:11 [1638] ADB Write: host:devices
2012-09-17 16:42:11 [1638] ADB Read: 00095dac01875f	device
2012-09-17 16:42:23 [1638] Connecting to ADB server...
2012-09-17 16:42:23 [1638] Connected
2012-09-17 16:42:23 [1638] ADB Write: host:devices
2012-09-17 16:42:23 [1638] ADB Read: 00095dac01875f	device
2012-09-17 16:54:30 [1638] Connecting to ADB server...
2012-09-17 16:54:30 [1638] Connected
2012-09-17 16:54:30 [1638] ADB Write: host:devices
2012-09-17 16:54:30 [1638] ADB Read: 00095dac01875f	device
If you need more information, let me know that.

Thanks!
User avatar
Schattenjager
Junior Member
Junior Member
Posts: 8
Joined: 2012-08-28, 15:07 UTC
Location: Unknown Kadath

Post by *Schattenjager »

jakubklos,
Please tell me if there is any reason for updating adb binaries :)
These binaries in the latest version of Android SDK Platform-toos are newer than included in your plugin.
User avatar
za222
Member
Member
Posts: 146
Joined: 2003-03-11, 17:19 UTC
Location: Germany

Post by *za222 »

I found a problem:

The plugin does not show a dialog when copying/moving and the target file already exists, instead it simply overwrites the target file.

This is the case when copying both from and to adb.

Can you add the regular overwrite confirmation dialog?
jakubklos
Senior Member
Senior Member
Posts: 221
Joined: 2012-07-11, 14:48 UTC

Post by *jakubklos »

za222 wrote:I found a problem:

The plugin does not show a dialog when copying/moving and the target file already exists, instead it simply overwrites the target file.

This is the case when copying both from and to adb.

Can you add the regular overwrite confirmation dialog?
Ok, will do
jakubklos
Senior Member
Senior Member
Posts: 221
Joined: 2012-07-11, 14:48 UTC

New version 3.5

Post by *jakubklos »

3.5
- Update: Install/Uninstall - result properly checked - in case of error TC displays an error
- New: File Copy - Overwrite handling added - TC displays an Overwrite dialog automatically
Post Reply