Board updated to latest phpbb version

[white]

Is there anything security-related in the update? Otherwise I will probably wait a bit longer.

I think there is 1 issue that may qualify as a security issue. There is way to bypass the maximum number of allowed keywords for a search, allowing users to run extremely large queries that may lock databases or stall under-resourced servers.

[ghisler(Author)]

I have updated the board to phpBB version 3.3.13 now and applied the moderator patch. Please let me know if you encounter any problems.

[white]

I have updated the board to phpBB version 3.3.13 now and applied the moderator patch. Please let me know if you encounter any problems.

Confirmed and works so far.

[white]

Reminder: phpBB version 3.3.14 was released 3 weeks ago. Announcement

[ghisler(Author)]

I have updated the board to phpBB version 3.3.14 now. Please let me know if you encounter any problems.

[white]

I have updated the board to phpBB version 3.3.14 now.

Thanks, works so far.

[beb]

Please, note:
The board's engine renders the following link in a pretty weird way:

The link:
https://support.microsoft.com/en-us/account-billing/frequently-asked-questions-about-microsoft-365-basic-4f39a693-4dc6-47bc-82b6-c2ef5f3afa38#:~:text=Microsoft%20365%20Basic%20and,Business

The way the board renders it:
https://support.microsoft.com/en-us/account-billing/frequently-asked-questions-about-microsoft-365-basic-4f39a693-4dc6-47bc-82b6-c2ef5f3afa38#:~:text=Microsoft%20365%20Basic%20and,Business

Workaround (which I don't like, because it hides a part of the text):
to manually wrap such a link into [ url=fulllink ]shortenedlink[ /url ]
Checked this on different browsers. Actually, it wasn't a true workaround in this case.
However, looks like [ url=fulllink ]simple text[ /url ] should work [still, only if the "simple text" itself is short enough to fit the browser window's width]:

https://support.microsoft.com/en-us/account-billing/frequently-asked-questions-about-microsoft-365-basic-4f39a693-4dc6-47bc-82b6-c2ef5f3afa38

short simple text

loooooooooooooo oooooooooooo oooooooooo ooooooooooooooooooooooo oooooooooooooooooo ooooooooooooooooooooooooooo oooooooooooooong text

[white]

The board's engine renders the following link in a pretty weird way:

The board's engine has nothing to do with it. This is how most web browsers render hyperlinks that span multiple lines.

[beb]

2white
Thank you for the information. Good to hear.
However, when I make a simple html with those links (and even just save this page as html in one way or another) and open it in those same browsers, they begin to display it properly (with no underlines outside the actual links texts).
So I believe <a href="" class="postlink"></a> does somehow have something to do with it.

ETA

Out of curiosity, I have found it:
Image: https://i.imgur.com/d3jbmUT.png
Image: https://i.imgur.com/kbtN5N2.png

[white]

However, when I make a simple html with those links (and even just save this page as html in one way or another) and open it in those same browsers, they begin to display it properly (with no underlines outside the actual links texts).
So I believe <a href="" class="postlink"></a> does somehow have something to do with it.

You are right. Seems I made the wrong conclusion, sorry. On https://www.phpbb.com/community the display texts are shortened, but if you use "Inspect element" and change the display text, it happens there too. It is caused by the display property for links being set to inline-block in links.css:

Code: Select all

a {
	direction: ltr;
	unicode-bidi: embed;
	text-decoration: none;
	/* we use links inline more often then not so to address several bugs with
	IE and some other browsers we render all links as inlineblock by default */
	display: inline-block;
}

Use "Inspect element" en uncheck the box before "display: inline-block;" and look at the result.
Web browsers display links this way when the links are to be rendered as inline-block with a bottom border (the bottom border is set by the postlink class).

[beb]

2white
Yes, thank you. I have already found that too.
The effect we can see is caused by playing with text-decoration, and border-bottom.

Code: Select all

.postlink {
    text-decoration: none;
    border-bottom: 1px solid transparent;
}

[ghisler(Author)]

I have switched from PHP 8.2.x to 8.3.15 now. Please let me know if you encounter any problems with the board.

[white]

The effect we can see is caused by playing with text-decoration, and border-bottom.

Yeah, disable the border and set the text-decoration property to "underline". Of course it wouldn't be a problem if links were not styled as inline blocks.

Shortening of the display texts of urls seems to be standard nowadays for phpBB boards. So it seems Ghisler is using a mod or extension to display full link texts.

[beb]

2white
OK. Now it's clear that this is by design.
Of course, Mr. Ghisler has his point for that, and it's up to him to do something with that or to do nothing leaving it as it is.
I have satisfied my curiosity and have no more questions in that regard.
Thank you for your help.
Cheers.

[ghisler(Author)]

I'm not sure what exactly you dislike about the current display of links. Do you want to have the link target (behind the hashtag) removed? Or is it about underlining just the last line of the link?