Sync into RAR: focus lost, file list lost

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Sync into RAR: focus lost, file list lost

Post by *StatusQuo »

A kind of cosmetical thing?
  • besides TC have at least one other program window open
  • in TC put a normal directory on the left and a RAR archive on the right
  • mark some (5) files on the left side (and roughly remember which files you marked), that are not present in the archive on the right
  • start Commands / Synchonize Dirs to show the differences
  • remove copy direction from all displayed files
  • set copy direction for a single file on the left to be copied to right (packed into the archive)
  • let the Sync-tool pack some files into the RAR archive (left=>right)
There are two flaws in here:
  • Focus lost: After WinRAR closes after finishing its job, the focus is not passed to TC's Synchronize-window, but another window gets the focus (almost always).
    WinRAR.EXE is called directly here, there is no additional batch or something.
    => Is that (unwanted) focus change done by TC or is WinRAR to blame here?
  • File list lost: When re-comparing after copying the selected file into the archive,
    the list of previously marked files in TC main window seems to be lost, too:
    No files at all are shown then, neither different nor equal ones.
This behaviour is identical to TC 6.56.
The focus thing is not a big problem, because it's (almost) always pressing one Alt-Tab that is needed here - I'm quite used to it by now.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
petermad
Power Member
Power Member
Posts: 14824
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Confirmed, but using DOS RAR 2.04 in stead.

When TC looses focus after the DOS RAR box has closed, I also hear a Windows Standard beep.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
PeaceMaker
Senior Member
Senior Member
Posts: 287
Joined: 2005-12-31, 22:32 UTC
Location: Warsaw, Poland
Contact:

Post by *PeaceMaker »

Confirmed using DOS RAR v2.50...
[face=tahoma]LICENSE NUMBER: #101897 Single user license (since: 6th February 2004)
CURRENT VERSION: Total Commander 9.00 beta 12 (released: 31st August 2016)
[/face]
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48107
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Focus lost
Not confirmed here (Windows 2000, WinRAR). Where does the focus go to?
File list lost
Confirmed and fixed! What happens is that the selection is cleared in Total Commander (main window) after packing. Since you had the option "only selected" checked, the Synchronize function will not show any files at all in the second compare step. The files are still there, just not shown...
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14824
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Where does the focus go to
To the window that is just before TC in the z-order.

Try to close all windows, then open for example a browser window in full screeen and then open TC in front of the browser window - now do the synchronization as described in the first post. Tested with Windows XP SP2
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

petermad wrote:
Where does the focus go to
To the window that is just before TC in the z-order.
Yes, the same here.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48107
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

It seems the be a timing problem of Windows XP. TC closes the progress dialog almost at the same time when the focus should go back to it. If I add Sleep(500), Windows seems to have the time to set the focus correctly...
Author of Total Commander
https://www.ghisler.com
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

ghisler(Author) wrote:It seems the be a timing problem of Windows XP.
Confirmed.
The behaviour is the same under W2k and XP on different PCs.
But is occurs on "fast" PCs (P4-2,4 GHz), while on slow ones (P3-550 MHz) TC Sync keeps the focus.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
petermad
Power Member
Power Member
Posts: 14824
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

But is occurs on "fast" PCs
Glad to learn that I have a fast PC :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48107
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Can anyone test whether this works now in RC5, please?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14824
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

The loosing focus problem is fixed, but I still hear a Standard Windows beep.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

Fixed in RC5 completely here:
- lost focus: fixed
- lost file list: fixed
- no beep sound here anymore (with RC4 I got this, too; yes, the speakers were switched on while testing :) )

Tomorrow I will test this also on another PC, where this bug occured in RC4.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
petermad
Power Member
Power Member
Posts: 14824
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Maybe I should add that I am using DOS RAR 2.04
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

Confirmed beep using 32bit console RAR.EXE of different versions (tested 3.62, 3.51, 2.04).

Using WinRAR.EXE I didn't get any beep.

Using RAR.EXE there is NO beep when adding files with F5,
but there is one when adding files with SyncDirs tool.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

Confirmed beep using 32bit console RAR.EXE of different versions (tested 3.62, 3.51, 2.04).

Using WinRAR.EXE I didn't get any beep.

Using RAR.EXE there is NO beep when adding files with F5,
but there is one when adding files with SyncDirs tool.


EDIT:
Testing this messed things up (at least it seems like that).
After testing this I got a beep also with WinRAR.EXE (which I didn't before).
Also the focus was lost again.

Neither a windows restart or copying back the old INI did help,
and I can see no differences in the WinRAR directory. :(
System restore is running... :|
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
Post Reply