[8.0ß23 x64] Image OLE tooltip crash

[Taverius]

If I save this image to disk and then mouseover, TC bombs out.

OLE2 comments must be on, onbviously

Problem signature:
Problem Event Name: APPCRASH
Application Name: TOTALCMD64.EXE
Application Version: 8.0.0.1
Application Timestamp: 00000000
Fault Module Name: PhotoMetadataHandler.dll
Fault Module Version: 6.1.7600.16385
Fault Module Timestamp: 4a5be037
Exception Code: c0000090
Exception Offset: 000000000001bfaf
OS Version: 6.1.7601.2.1.0.256.1
Locale ID: 2057
Additional Information 1: c719
Additional Information 2: c719fb1b445e58a2e114b3bae027d08d
Additional Information 3: dbbd
Additional Information 4: dbbd00130113d2e8add43eb919c65f45

[karlchen]

Hello, Taverius.

If I save this image to disk and then mouseover, TC bombs out.
OLE2 comments must be on, onbviously

Well, nothing bad happens here. No crash.

Total Commander 8.0ß23 64-bit
OLE comments activated under Configuration => Options => Display
Windows Server 2008 R2

But maybe the programme author will be able to tell what goes wrong in your case.

Kind regards,
Karl

[Sir_SiLvA]

2karlchen
Do you have
Fault Module Name: PhotoMetadataHandler.dll
Fault Module Version: 6.1.7600.16385
on your System?

[karlchen]

Hello, Sir_SiLvA.

The DLL file in question is present on Server 2008 R2 as well:
Path: C:\Windows\System32
Filename: String Value
PhotoMetadataHandler.dll 420,864 07/14/2009 03:41 ----

Copyright © Microsoft Corporation. All rights reserved.
Date modified 7/14/2009 3:41 AM
File description Photo Metadata Handler
File version 6.1.7600.16385
Language English (United States)
Original filename PhotoMetadataHandler.dll
Product name Microsoft® Windows® Operating System
Product version 6.1.7600.16385
Size 411 KB
Type Application extension

Cheers,
Karl

[umbra]

This issue has been mentioned before: http://ghisler.ch/board/viewtopic.php?t=33540. While I can reproduce it even on a freshly installed Windows 7 x64, I'm not sure it is TC's fault.
For some reason, Windows can't work with some images containing GPS coordinates - especially the ones saved by Adobe LR4. If you open such files in IrfanView, it will show proper coordinates. However if you look at the same coordinates in the Explorer, it will show "-2147483648;-2147483648;0" for both longitude and latitude. Also, according to the Internet, TC is not the only application that can crash on such files - but still, it shouldn't.

[karlchen]

Hello, umbra.

Thanks a lot for linking to the other thread.

Hello, Taverius.

Can reproduce the reported crash using
+ T.C. 8.0ß23 64-bit on
+ Windows 7 Home Premium SP1 64-bit with
+ Aero Theme (glass effect off, but this seems to be irrelevant in this case)

Switching to any 32-bit version of T.C. - 8.0ß23 32-bit, 7.57a - makes the problem go away. This suggests that though the affected 32-bit shell extension is all right, the corresponding 64-bit shell extension must exhibit some sort of problem. Which takes us to the thread which Umbra points to.

We'll see ... nothing ... switching the extension "Photo Extract Image" with Nir Sofer's shellexview programme does not have any effect.

Cheers,
Karl

[ghisler(Author)]

TC simply calls IQueryInfo->GetInfoTip, see this MSDN article:
http://msdn.microsoft.com/en-us/library/windows/desktop/bb761357%28v=vs.85%29.aspx

This function calls the various comment handlers registered in the system.

There is no crash here, neither in 32-bit nor 64-bit - I also have PhotoMetadataHandler version 6.1.7600.16385. Maybe some other extension called just BEFORE the above is causing the crash in PhotoMetadataHandler? Can you try to turn off the OTHER extensions wih shellexview? Since it happens only in 64-bit TC, there is probably just the 64-bit version of the problematic extension installed.

[umbra]

Maybe some other extension called just BEFORE the above is causing the crash

Since it crashes on a completely fresh installation of Windows 7 x64, I doubt that. However I just tried to disable all extensions (to the point the system was hardly able to boot) and it still crashes in PhotoMetadataHandler. When I disabled it - no crash, when I enabled it - crash again.
As I said in my last post, the bug is probably in the extension itself, since it doesn't work properly even in the Explorer, but it should not be able to crash TC.

[HolgerK]

Fault Module Name: PhotoMetadataHandler.dll
Fault Module Version: 6.1.7600.16385
Fault Module Timestamp: 4a5be037
Exception Code: c0000090

0xC0000090 Floating-point invalid operation

I thought this bug is gone since:

23.01.08 Added: Disable Delphi floating point exceptions when calling OLE functions which may involve shell extensions: Drag&Drop, Context menu, Property sheet, Copy+Paste, Overlay Icons, Thumbnails, Info-Tips
23.01.08 Added: Disable Delphi floating point exceptions before loading any DLLs (Visual C++ DLLs may cause floating point exceptions because exception handling is off in C++)

Is there a difference between Delphi and Lazarus code?

TC simply calls IQueryInfo->GetInfoTip
...
There is no crash here, neither in 32-bit nor 64-bit

The bug depends on the metadata of the picture, so it will occur only for some pictures (and only if the handler isn't replaced by another shell extension like MediaInfo.

BTW: here PhotoMetadataHandler.dll is not registered for info tips:

IPropertyStore Handler for Images Property Handler Photo Metadata Handler 6.1.7600.16385 C:\Windows\system32\PhotoMetadataHandler.dll

Photo Extract Image Thumbnail Photo Metadata Handler 6.1.7600.16385 C:\Windows\system32\PhotoMetadataHandler.dll

And sorry, i can't confirm the bug (maybe because i'd installed a different Infotip-Handler or because i downloaded the wrong picture from the deviant art gallery).

Regards
Holger

[ghisler(Author)]

Sorry, no idea, I still can't reproduce it.

[karlchen]

Hello, Christian.

Since it happens only in 64-bit TC, there is probably just the 64-bit version of the problematic extension installed.

At least for the two machines where I have tested it
+ Server 2008 R2 - where no problem occurs
+ Windows 7 Home Premium SP1, 64-bit - where the crash happens
both editions of PhotoMetadataHandler.dll are present, 32-bit in syswow64, 64-bit in system32, and have got the same version numbers.

T.C. 8.0ß23 32-bit does not crash on either of the two machines.
T.C. 8.0ß23 64-bit does not crash on Server 2008 R2, but it crashes on Windows 7 Home Premium SP1, 64-bit, reliably and reproducibly.

Hm, as soon as I get the chance I will try to check whether the list of 32-bit and 64-bit shell-extensions is different on the Windows 7 Home Premium SP1 64-bit notebook.

Kind regards,
Karl

[umbra]

Looks like I've managed to reproduce it also in TCx32.
When you point to such picture to show a tooltip, TCx64 will simply freeze. However if you select the same file in TCx32, point to it to show its tooltip and press Del to delete the file just before the tooltip is shown, TC will crash.

First, it will show a message box with text "Exception EInvalidOp in module TOTALCMD.EXE at 6D9F8673. Invalid floating point operation." When you close it, another message box will appear with text "Control deleted from background thread!". This message cannot be closed - it will keep reopening until you kill TC's process. And sometimes, but not always, you can see a crash dialog:

Code: Select all

---------------------------
Total Commander 8.0ß23
---------------------------
Access violation at address 00448052. Read of address 000000E4.
Access violation at address 00448052. Read of address 000000E4
Windows 7 SP1 6.1 (Build 7601)

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Windows exception: C0000005
Stack trace:
00448052
4242F0  424A9C  426EF5  >423C18  423C18  425E42
444535  423C18  445CF8  446033  448050  444535
446486  423C18  445A47  423C18  429236  42937C
6D9185  
Raw:
448050  42427F  4242F0  42476F  424A9C  426EF5
444535  446755  4258F4  446492  423C18  4467FF
426485  446DDD  444535  446755  4258F4  446492
423C18  425E42  426D5A  444535  446755  4258F4
446492  423C18  445CF8  402235  4033BC  4021B4
4023DB  4026A4  4036AD  4458AE  444D41  4459B5
6D5E49  41D7A4  445E7E  446033  446755  446486
4464A9  423C18  445A47  423C18  420FAB  42461C
4261EC  4461DA  44803E  448050  64A010  4459B5
423C18  4467FF  402E36  444535  446755  4258F4

Press Ctrl+C to copy this report!
Continue execution?
---------------------------
Yes   No   
---------------------------

Again, this happens only with pictures containing weird (yet valid) GPS data.

To sum it up:
I've got two Win7 x64 machines (one totally clean and one old), one Win8 x32 and one Win8 x64.
Both TC versions crash on all x64 machines.
TCx32 does not crash on Win8 x32.

[umbra]

2karlchen
Hi. Testing it with Server 2008 R2 might be tricky, since most of the desktop features are disabled by default. To make it act like a desktop, you have to install the Desktop Experience pack, enable a few Group Policy settings and so on - it's easy to overlook something.

[karlchen]

<offtopic>

Hello, umbra.

Hi. Testing it with Server 2008 R2 might be tricky, since most of the desktop features are disabled by default.

I know. But as far as time is concerned, I have got unlimited access to the machine.
The same is not true for my own private Windows 7 64-bit notebook. It is usually hijacked by someone playing "Happy Harvesting" all the time.

To make it act like a desktop, you have to install the Desktop Experience pack, enable a few Group Policy settings and so on - it's easy to overlook something.

Cannot do so, our Windows admins would not appreciate such modifications.

Cheers,
Karl

<offtopic>

[ghisler(Author)]

Unfortunately I still can't reproduce it. Maybe I'm just testing with the wrong picture? The link in the first post points to a whole page of pictures, not just one. I tested with the top-left picture (the linked one, not the thumbnail). Is that the right one?