[TC801rc4] Multi-rename tool: Placeholder [2-5] not working

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
white
Power Member
Power Member
Posts: 4615
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC801rc4] Multi-rename tool: Placeholder [2-5] not working

Post by *white »

Help wrote:[2-5] Characters 2-5 from the whole name and extension (other numbers as in [N] definition)
Works OK in Windows Commander 4.50 - 4.54, masking file name including extension.
Masks file name including full path since Windows Commander 5.0.

Tested using Windows XP.
umbra
Power Member
Power Member
Posts: 871
Joined: 2012-01-14, 20:41 UTC

Post by *umbra »

Is that a bad thing? You can easily work with file name and its extension using [N] and [E]. But how else would you manipulate with a full path to the file? I think it's the help description that needs to be made more clear.
Windows 7 Pro x64, Windows 10 Pro x64
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3290
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

I dont think its a Bug, but a bug fixed in 5.0. Path belongs to the filename.
Hoecker sie sind raus!
User avatar
white
Power Member
Power Member
Posts: 4615
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

umbra wrote:Is that a bad thing? You can easily work with file name and its extension using [N] and [E].
To work with folders that sometimes have dots in their name, you need this placeholder. You cannot use [N] and [E] to get a sub string in this case.
umbra wrote:But how else would you manipulate with a full path to the file?
[=tc.path]
Sir_SiLvA wrote:I dont think its a Bug, but a bug fixed in 5.0. Path belongs to the filename.
There is no mention of this in history.txt and to me this makes no sense for 5.0.
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3290
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

white wrote:There is no mention of this in history.txt and to me this makes no sense for 5.0.
First point is correct,
but for me it makes sense:
- You want Filename you use [Nx-y] and [E]
- You want complete Filename with Path you use [x-y]
Hoecker sie sind raus!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48075
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Indeed the wording in the help is a bit unclear - but it was changed this way to access the whole name and extension including the full path.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4615
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

ghisler(Author) wrote:Indeed the wording in the help is a bit unclear - but it was changed this way to access the whole name and extension including the full path.
I can't believe you gave up basic functionality to handle sub strings of folder names with dots (see discussion here) in order to be able to handle full path which was hardly usable at that time.

Also strange that the new placeholder [P] in that version was mentioned in HISTORY.TXT and in "What's new in this version?", but the important fix to access full path was not mentioned at all.

Anyway, I think the original function is much more basic and would be more beneficial for the average user. I think it's better that people need to use [=tc.path] to get full path, than that people need to use [=tc.fullname] to get full name (which means no path!).

However changing it back after 10 years is questionable too, although nobody seems to be using placeholder [x-y]. Placeholder [=tc.path] on the other hand seems to be used plenty and is advised by Christian Ghisler.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48075
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I also don't think that changing it now would be a good idea. Therefore I have simply added a new placeholder [A] which stands for all characters of the name (with extension, without path). Please try it!
Author of Total Commander
https://www.ghisler.com
User avatar
Stefan2
Power Member
Power Member
Posts: 4153
Joined: 2007-09-13, 22:20 UTC
Location: Europa

Post by *Stefan2 »

ghisler(Author) wrote:I also don't think that changing it now would be a good idea.
Therefore I have simply added a new placeholder [A]
which stands for all characters of the name (with extension, without path).
Please try it!
[A] for ALL > name (with extension, without path)

-

And how about to make it more complete:
[F] for FULL > full name (with extension, with path)

The same as: [1-] as i understand, but more obvious.

EDIT:
... [F] is already taken.
So maybe [W] for Whole > as equivalent to [1-] to get path\base.ext?


.
Last edited by Stefan2 on 2012-07-27, 17:21 UTC, edited 1 time in total.
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3290
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

Stefan2 wrote:[F] for FULL > full name (with extension, with path)
This is exactly what [x-y] does ... its the FULL filename including path name & extension...
Hoecker sie sind raus!
User avatar
Stefan2
Power Member
Power Member
Posts: 4153
Joined: 2007-09-13, 22:20 UTC
Location: Europa

[W] for Whole > as equivalent to [1-] to get path\base.ex

Post by *Stefan2 »

Sir_SiLvA wrote:
Stefan2 wrote:[F] for FULL > full name (with extension, with path)
This is exactly what [x-y] does ... its the FULL filename including path name & extension...
I know. But since a few hours only.
Before i have that not found in (understand from) the help:
Help wrote:[2-5] Zeichen 2 bis 5 von Name INKLUSIVE Erweiterung
[2-5] Characters 2-5 from the whole name and extension
From the english help i could guess from the "whole".
But in german help that special part is missed.

{
    What is defined to be the "NAME" aside here,
    since that is not obvious for average users.

    Better would be anyway something like:
    [P] = whole Path (with an syntax to get an desired folder, like having [P] as an array and use as [P(2)] and [P(-1)])
    = Base name / file name part
    [E] = Extension
    [N] = [P]\.[E]

    But therefor it's to late anyway.
}


That's why i suggest to add maybe
[W] for Whole > as equivalent to [1-] to get path\base.ext



And/Or change the wording in the help and include the word "path"
improved help wrote:[2-5] Zeichen 2 bis 5 vom kompletten Pfad inklusive Dateiname und -erweiterung
[2-5] Characters 2-5 from the whole path including name and extension


With my suggestion that becomes:
[W2-5]
[W2-5]
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3290
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

Thats why I often say: Using a tool like TC requires the User to have a brain and understanding of what he does.
a Filename contains every part ofc - path, name, extension.

So clearing that up in the help for the DAUs okay but building the same function into tc twice is reidiculous....
Hoecker sie sind raus!
User avatar
white
Power Member
Power Member
Posts: 4615
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

ghisler(Author) wrote:I also don't think that changing it now would be a good idea. Therefore I have simply added a new placeholder [A] which stands for all characters of the name (with extension, without path). Please try it!
Placeholder [A] works OK. Tested using TC 8.01rc5 32-bit.

Help text is adjusted and more clear. I noticed however that unlike all other lines, the following lines do not start with a capital:
Help wrote:[N] old file name, WITHOUT extension
[A] old file name, WITH extension (All characters of the name), without the path
And I suggest to swap the following lines:
Help wrote:[2-5] Characters 2-5 from the name INCLUDING path and extension (other numbers as in [N] definition)
[A] old file name, WITH extension (All characters of the name), without the path
User avatar
petermad
Power Member
Power Member
Posts: 14792
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Help wrote:
[N] old file name, WITHOUT extension
[A] old file name, WITH extension (All characters of the name), without the path
I agree that these lines should start with capital letters.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48075
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks for testing the new placeholder [A]!

I agree about the uppercase, but I prefer to keep all the [N*] placeholders tohether. I will put the [A] in front of the [2-5] line, though.
Author of Total Commander
https://www.ghisler.com
Post Reply