Close windows group of TC and its Help: crash in TC/hhctrl

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Close windows group of TC and its Help: crash in TC/hhctrl

Post by *DrShark »

To reproduce:
0. Tasks on taskbar required to be grouped to reproduce it, so Start menu options, Taskbar tab setting "Group similar taskbar buttons" must be enabled and some windows already must take enough place on taskbar.
1. Start TC.
2. Start CHM help using F1 key. On taskbar TC and its help will be in one group.
3. In group's context menu, use item with name like "Close group" or "Close all windows" (my Windows Vista interface is in Russian language, so my translation may be not accurate).
4. Total Commander and Help will be closed, with following error:
Продукт
Total Commander 32 bit

Проблема
Остановка работы

Дата
01.12.2015 16:49

Состояние
Отчет отправлен

Сигнатура проблемы
Имя проблемного события: APPCRASH
Имя приложения: TOTALCMD.EXE
Версия приложения: 8.5.2.1
Штамп времени приложения: 2a425e19
Имя модуля с ошибкой: hhctrl.ocx
Версия модуля с ошибкой: 6.0.6001.18000
Штамп времени модуля с ошибкой: 4791a6bb
Код исключения: c0000005
Смещение исключения: 000132e5
Версия ОС: 6.0.6002.2.2.0.768.3
Код языка: 1058
Дополнительные сведения 1: 1633
Дополнительные сведения 2: 6b6679d44207168283cef06a4a6b69cb
Дополнительные сведения 3: b5ec
Дополнительные сведения 4: 1d316487a9353bc0813f888988d7dfce

Дополнительные сведения о проблеме
Код черпака: 409445454
I can also add a mini dump if required.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Strange, not crashing here on Windows 7. It could be a Vista-specific bug. TC closes the help by itself when you close TC, so the double closing may crash the help viewer.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I can confirm the bug on Windows 8.1 and Windows 10 for both 32bit and 64bit TC - but I cannot reproduce the bug on Windows 7 SP1 (all Windows versions are 64bit).
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

ghisler(Author) wrote:Strange, not crashing here on Windows 7.
I sent a minidump to support email, hope it will help.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I finally managed to open enough programs under Window XP (32bit) to make TC and TC's help join the same group (you cannot force that under XP). TC and TC Help closes alright when "Close group" is used, so I cannot reproduce the bug under Windows XP.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

From C. Ghisler's email reply after minidump analyzing:
It really seems to be crashing in the hhctrl viewer,
no TC code visible.
So let's see if it will be possible to do something here on Total Commander side.

Note about help in hlp format: on my Vista system I still have 16-bit viewer for hlp files, and with them TC never goes into one group. Several copies of opened helps from different TC instances forms one group with Help windows, and this group is closed fine without any errors. Latest *.hlp help files from TC offered in this topic are not compatible with 16-bit help viewer, so I checked with hlp from TC 7.50.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Unfortunately the bug seems to be in the help viewer itself, not TC - there is no indication of TC in the stack trace from the mini dump.
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

ghisler(Author) wrote:Unfortunately the bug seems to be in the help viewer itself, not TC - there is no indication of TC in the stack trace from the mini dump.
I meant, is it possible to add some workaround on TC side in case if it depends on how TC opens help file? I just checked IrfanView (it also does use CHM help), and the error doesn't happen when closing a group of Iview/Help. I don't know though if it's possible to check it without possibility to reproduce the error. petermad reproduced an error on Windows 8.1 and Windows 10, have you ability to try it on these OSes?

I'll also try report it to Microsoft.

Edit: since MS Connect doesn't accept bugreports for Vista or CHM Help Viewer, I wrote about it on MS support forums.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

DrShark wrote:I just checked IrfanView (it also does use CHM help), and the error doesn't happen when closing a group of Iview/Help
I take back my words about IrfanView. Visually there weren't errors, and the windows of IrfanView and its Help were closed, but the process i_view32.exe still was remaining working and required manual killing. So definitely there's something wrong with "Close group" feature at least on Windows Vista here.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

history.txt wrote:27.04.16 Fixed: Do not actively close HTML help (.chm) when closing TC, it crashes on Vista/8/8.1/10 when user chooses "Close group"...
I can confirm the fix in TC 9.00a on Vista 32bit.
history.txt wrote:... Windows closes the window by itself (32/64)
Just a note: Windows closes the help file with some pause after TC has been closed.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
Post Reply