[9.10ß3] Multi Rename Tool: [E#-#] is not working properly

Bug reports will be moved here when the described bug has been fixed

Moderators: white, sheep, Hacker, Stefan2

Post Reply
User avatar
Flint
Power Member
Power Member
Posts: 3159
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

[9.10ß3] Multi Rename Tool: [E#-#] is not working properly

Post by *Flint » 2017-10-05, 22:49 UTC

This is not 9.10β specific but was just reported on a Russian forum.

(I'm not sure about posting this all together, but all these bugs look related to me.)

Bug No.1
1. Select some file(s) with non-empty extensions and open Multi Rename Tool.
2. Click the [E#-#] button, select any part of the extension.
3. Turn on the option "Measure last character from the end", press OK.
4. Nothing is added to the Extension editbox.

Bug No.2
pp. 1, 2 are the same.
3. Turn on the option "Use [first,last]…", press OK.
4. The [E…] template is appended to the Name editbox instead of Extension one.

Bug No.3
1. Select at least one file or dir without extensions, open Multi Rename Tool.
2. Put cursor on a file without extension and click the [E#-#] button.
3. Instead of opening the dialog, TC immediately inserts [E1-3] into the Extension editbox.
I understand that there is nothing to select from, but TC should either suggest some fake extension instead, or simply do nothing.

Bug No.4
1. Select at least one file or dir without extensions, open Multi Rename Tool, do NOT put .
2. Do NOT put cursor anywhere in the list and click the [N#-#] button.
3a. If the cursor in TC panel was set on some file/dir, the dialog will use this name for selection.
3b. If the cursor was set on [..], the name of a random file from the list will be used.
4. Now press [E#-#].
5. No matter where the cursor in TC panel was (even if it was on a file with extension), TC just inserts [E1-3] into the Extension editbox, without dialog.

P.S. There are many problems also with [#-#], [P#-#], etc. commands of the [#] button drop-down menu. For instance, when "Measure last character from the end" is set, selection is not applied at all (TC inserts just [], or [P], or [G], etc.).
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.21rc1 / Win7 x64 SP1, Win10 x64

User avatar
petermad
Power Member
Power Member
Posts: 8059
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2017-10-06, 01:39 UTC

2. Do NOT put cursor anywhere in the list and click the [N#-#] button.
3a. If the cursor in TC panel was set on some file/dir, the dialog will use this name for selection.
Not here, it is set to some random file/dir name (the same each time for the same selection in the main panel)
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36504
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2017-10-06, 09:44 UTC

I can confirm that the [E...] entry isn't added.
Author of Total Commander
http://www.ghisler.com

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36504
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2017-10-08, 10:27 UTC

OK, I have checked this now:
#1 is a bug, will be fixed
#2 too
#3 is intentional: Since there is no extension, the user couldn't choose anything in the dialog
#4 is intentional too: If you don't put the cursor on a file, TC uses the name of the first in the list. Then #3 is applied (no extension)
There are many problems also with [#-#], [P#-#], etc.
It's actually the same as #1: When I added this feature, I updated only the [N#-#] button.
Author of Total Commander
http://www.ghisler.com

User avatar
Flint
Power Member
Power Member
Posts: 3159
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Post by *Flint » 2017-10-08, 10:47 UTC

ghisler(Author) wrote:#4 is intentional too: If you don't put the cursor on a file, TC uses the name of the first in the list. Then #3 is applied (no extension)
Not according to my tests. See the screenshot:
http://flint-inc.ru/Temp/tcbeta910/tc-mrt.png
I selected all files in my TC dir, put the cursor on the [..] (you can see it in the background), opened MRT, pressed [N#-#]. TC suggested the name "TOTALCMD64-9.00b15a" which is not the first file.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.21rc1 / Win7 x64 SP1, Win10 x64

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36504
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2017-10-08, 11:03 UTC

No, [N#-#] is special, it suggests the longest name!
Author of Total Commander
http://www.ghisler.com

User avatar
Flint
Power Member
Power Member
Posts: 3159
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Post by *Flint » 2017-10-08, 11:17 UTC

ghisler(Author)
I see. It's a bit confusing. Maybe make [E#-#] do the same when no file is selected — suggest the longest available extension?
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.21rc1 / Win7 x64 SP1, Win10 x64

User avatar
petermad
Power Member
Power Member
Posts: 8059
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2017-10-08, 18:38 UTC

No, [N#-#] is special, it suggests the longest name!
Aha - good to know - makes sense BTW.
Maybe make [E#-#] do the same when no file is selected — suggest the longest available extension?
I agree.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36504
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2017-10-09, 12:44 UTC

Usually extensions aren't longer than 3 characters, so I didn't add the 'longest' search as I did for the N placeholder. I prefer to keep it this way for consistency with older TC versions.
Author of Total Commander
http://www.ghisler.com

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36504
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2017-10-10, 09:34 UTC

Bugs 1+2 should be fixed now in RC1, as well as the problems with [P], [G] etc. from the dropdown list. Please test!
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8059
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2017-10-10, 18:09 UTC

I can confirm that bug 1 and 2 are fixed in TC 9.10rc1 :-)
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
Flint
Power Member
Power Member
Posts: 3159
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Post by *Flint » 2017-10-11, 12:12 UTC

Yes, confirm fixed in rc1.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.21rc1 / Win7 x64 SP1, Win10 x64

Post Reply