Missing sections/keys in the help file

Please report only one bug per message!

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Missing sections/keys in the help file

Post by *Flint »

In the wincmd.ini/wcx_ftp.ini somne keys and sections are not described or not completely described.

I. wincmd.ini missing descriptions:

[Left]
ActivePanelColor
ActivePanelColor2


[1024x768 (10x20)]
PluginSel*
IconWin95


[ButtonBar], [ButtonBarVertical]
Buttonheight96
SmallIconSize96
DefaultDpi


[CompareCustomField]
[ThumbsCustomField]
[SearchCustomField]

These sections are not mentioned at all.

[Configuration]
Lastmd5: Missing description of the values 5-10 (SHA224, SHA384 and all SHA3).
In addition, these new options are not mentioned in the "Create Checksum File(s)" help article describing the dialog.


II. wincmd.ini wrong default values:

For most keys, the sample value means the default value. However, for the following ones this rule does not hold:

[Colors]
CursorColor=8421504
CursorText=16777215
Default value for both of these keys is -1.

ActiveTitle=
ActiveTitleText=
InactiveTitle=
InactiveTitleText=

Default value is not specifies at all, it should be -1 here too.


III. wcx_ftp.ini missing descriptions:

[connections]
default

[Site1]
ClientCert
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

Mostly fixed in 9.20rc2, although there are some glitches:

ActivePanelColor, ActivePanelColor2, PluginSel* do not have =<value> after the name (no value is expected for PluginSel*, of course, but the equal sign should be there, as in all other keys).

wcx_ftp.ini::[Site1] ::ClientCert:
1) Maybe, it's worth mentioning that the serial number is stored as Base64?
2) I'd suggest to use the term "SHA1 thumbprint" in the description of the second value, rather than "SHA1 checksum". Technically, they are the same, but all the tools that work with certificates use "thumbprint", so it would be easier for non-experienced users to tie up the ends.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

ActivePanelColor, ActivePanelColor2 don't have the = sign because they are usually undefined, except when using view modes.

ClientCert: it's not the thumbprint because it's only a partial SHA1 checksum (only half). This isn't a security problem because it's not used to recognize a certificate sent by the server, but one stored locally.
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

ghisler(Author) wrote:ActivePanelColor, ActivePanelColor2 don't have the = sign because they are usually undefined, except when using view modes.
Well, there are many keys that are not present by default, but they still have default values specified, or if there cannot be any value, just the equal sign.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

Some additional comments from my co-author of the Russification package, Vadim:

1. A minor inconsistency in the description of Lastmd5: it shows SHA3-*, but in the dialog and the help topic about the dialog an underscore is used (SHA3_*).

2.
ActivePanelColor Background color of current tab
ActivePanelColor2 Secondary background color of current tab
a) First of all, this sounds like the colors of the tab title, not the actual panel contents (compare with the description of ActiveTabColor).
b) It does not mention that these keys are only added when a custom view mode is selected, so they may be confused with BackColor/BackColor2.

3. The keys Buttonheight96, SmallIconSize96, DefaultDpi were added to the [Buttonbar] section but not to the [ButtonbarVertical].

4.
monitor(x,y,dx,dy,dpi)=x,y,dx,dy Position and size saved separately for multiple monitors (in the section for the main monitor)
The description is a bit unclear, those coordinates look identical. I think it's worth describing explicitly that (x,y,dx,dy) in the key name is the monitor position within multimonitor desktop configuration, and (x,y,dx,dy) in the value is the windows position on this monitor.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, I will make some changes. For 3, I will just add etc.
Author of Total Commander
https://www.ghisler.com
Post Reply