No context menu after activation of Tab with QV

Please report only one bug per message!

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

No context menu after activation of Tab with QV

Post by *DrShark »

It seems to be a regression caused by tab switch bugfix .

To reproduce:
1. Open QuickView in a tab of opposite panel.
2. Activate a tab with QuickView with left mouse button click.
3. Try to open context menu of QuickView panel's tab header with right mouse button click it, or context menu of other tab headers in that panel. It won't show up.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: No context menu after activation of Tab with QV

Post by *petermad »

Confirmed.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48005
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: No context menu after activation of Tab with QV

Post by *ghisler(Author) »

Why would you want to open it? The commands in that right click menu are for the directory shown by that tab, not for the quick view panel.

Can you give me a single reason why I should re-enable it?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: No context menu after activation of Tab with QV

Post by *petermad »

2ghisler(Author)
The problem is that when Quick View is active, right click on any other tab in the Quick View side does not respond to right click.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: No context menu after activation of Tab with QV

Post by *DrShark »

In addition to a reason mentioned by petermad above, I can add that actions for tab listed it its context menu have context of panel's path of tab, not QuckView file path. Even though QuickView covers tab's panel path, user usually know that path (because QuickView is not permanent), so it's expected to have a context menu of a tab with actions for its panel's path.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48005
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: No context menu after activation of Tab with QV

Post by *ghisler(Author) »

The problem is that when Quick View is active, right click on any other tab in the Quick View side does not respond to right click.
That's indeed the case - but which of the right click commands would make any sense while quick view is active?
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: No context menu after activation of Tab with QV

Post by *DrShark »

ghisler(Author) wrote: 2019-03-31, 13:15 UTCwhich of the right click commands would make any sense while quick view is active?
I think all, because, as I wrote above, that commands have a context of tab's actual path (from which tab header name is formed), not in context of QuickView (e.g. with context menu we're locking a path of tab, not the QuickView view.)
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: No context menu after activation of Tab with QV

Post by *petermad »

but which of the right click commands would make any sense while quick view is active?
For the tabs "behind" the tab that shows the Quick View, the right click menu should be the same as if Quick View was not active.

For the tab that shows the Quick View, I think that the text on the tab should be changed either to "Quick View" (or the Quick View icon), or to the path of the source folder. Right click menu could either be disabled or it could be used to show the "Options" menu of Lister - in that way it could be easy to change plugin, which it not always is now, because the plugin "steals" the keyboard input, so you cannot just press 4 to change plugin (you have to click on the header bar of the Quick View, an sometime that doesn't even work)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: No context menu after activation of Tab with QV

Post by *DrShark »

petermad wrote: 2019-03-31, 17:15 UTCFor the tab that shows the Quick View, I think that the text on the tab should be changed either to "Quick View" (or the Quick View icon), or to the path of the source folder. Right click menu could either be disabled or it could be used to show the "Options" menu of Lister
I think complete removing context menu items of original tab path and its keyboard shortcuts, and changing tab's menu name+icon to e.g. Lister's title and icon, is making usage of TC less convenient, e.g. in TC 9.21a it's not possible to use Ctrl+T on a tab with QuckView opened - to do it user now must waste time closing QuickView with Ctrl+Q first. I think the change of behavior in TC 9.21a, which breaks UX so much, is too significant for a minor bugfix release.

I'm not against Lister's menu for a tab with QuickView (indeed I'd like to see a full Lister's menu then, not only "Options"). Indeed, I'd prefer additional Lister's menu item with all its submenus for it, and part of Lister's title may be a part of Lister menu item there.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: No context menu after activation of Tab with QV

Post by *petermad »

e.g. in TC 9.21a it's not possible to use Ctrl+T on a tab with QuckView opened
Ctrl+T could be a key used by the Lister plugin - then it wouldn't work anyway for duplicating the tab.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: No context menu after activation of Tab with QV

Post by *DrShark »

Meanwhile on March 31 Total Commander 9.22a has been re-released (silent update,) but it changes nothing regarding tab context menus (even for background tabs)
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48005
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: No context menu after activation of Tab with QV

Post by *ghisler(Author) »

No, neither totalcmd.exe not totalcmd64.exe have been changed (that would require a new version number). Only a single dll has been replaced.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: No context menu after activation of Tab with QV

Post by *petermad »

Seems to be fixed in TC 9.5b1 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: No context menu after activation of Tab with QV

Post by *DrShark »

history950.txt wrote:09.04.19 Fixed: Right click on tabs was disabled when a quick view panel was shown on that side (32/64)
I can confirm the fix. For the discussion about possible ways to access the Lister's menu in QuickView, I created a new topic in Suggestions subforum.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
Post Reply