[9.50] Mismatched translation reuse: 'Save copy options' title

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
Flint
Power Member
Power Member
Posts: 3248
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

[9.50] Mismatched translation reuse: 'Save copy options' title

Post by *Flint » 2019-11-09, 23:14 UTC

When you click the new "Save" button in the Copy - Options, the confirmation dialog has the title "default" which is a reuse of the line 1591.
First, even in English it looks far from acceptable: it's not capitalized, and it's not clear what it actually means.
Second, I don't know about other languages, but in Russian it is just seriously mismatched. If users will see that, they'll just scratch their heads being unable to understand what it means, especially since the message itself tells absolutely nothing, except just repeating the selected option name.

My suggestions:
1. Add a new translation line for the title, something like "Save default action" or just "Default action".
2. Add an actual message text (translatable, of course) to the confirmation box, in addition to the option name. For example:
«Save the overwrite action "%s" as default?», or «Save the following overwrite action as default?\n%s»
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.22a / Win7 x64 SP1, Win10 x64

User avatar
petermad
Power Member
Power Member
Posts: 8967
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.50] Mismatched translation reuse: 'Save copy options' title

Post by *petermad » 2019-11-10, 00:41 UTC

I totally agree.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38395
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50] Mismatched translation reuse: 'Save copy options' title

Post by *ghisler(Author) » 2019-11-11, 11:33 UTC

Good point, I will add a translation.
Author of Total Commander
http://www.ghisler.com

User avatar
Flint
Power Member
Power Member
Posts: 3248
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: [9.50] Mismatched translation reuse: 'Save copy options' title

Post by *Flint » 2019-11-13, 18:34 UTC

I can see a new line was added in 9.50β5, and confirm it's working. Thanks for adding it!

However, I still have a couple of remarks.

1. The title of the confirmation box is now just a copy of the selected action, and I'm not sure it's a good idea. The title is expected to show the general idea of what's going on; and this one doesn't. I would suggest to use 5004="Overwrite options" for the title, instead.

2. Instead of OK/Cancel, the confirmation dialog is now Yes/No, which makes it impossible to close it via Esc. Could you please switch it back to OK/Cancel? Or Yes/No/Cancel, like you already did in some confirmation dialogs for the same reason.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.22a / Win7 x64 SP1, Win10 x64

User avatar
petermad
Power Member
Power Member
Posts: 8967
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.50] Mismatched translation reuse: 'Save copy options' title

Post by *petermad » 2019-11-13, 23:09 UTC

1. The title of the confirmation box is now just a copy of the selected action, and I'm not sure it's a good idea. The title is expected to show the general idea of what's going on; and this one doesn't. I would suggest to use 5004="Overwrite options" for the title, instead.

2. Instead of OK/Cancel, the confirmation dialog is now Yes/No, which makes it impossible to close it via Esc. Could you please switch it back to OK/Cancel? Or Yes/No/Cancel, like you already did in some confirmation dialogs for the same reason.
I agree. Also the (red) close button in the upper right corner of the dialog is now disabled.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
petermad
Power Member
Power Member
Posts: 8967
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.50] Mismatched translation reuse: 'Save copy options' title

Post by *petermad » 2019-11-20, 23:39 UTC

Not yet changed in TC 9.5b6 :-(
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38395
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50] Mismatched translation reuse: 'Save copy options' title

Post by *ghisler(Author) » 2019-11-21, 10:40 UTC

1. I'm not sure if this is a better idea.

2. The question is wrong for OK/Cancel.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8967
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.50] Mismatched translation reuse: 'Save copy options' title

Post by *petermad » 2019-11-21, 12:40 UTC

1: A title sayin for example "Copy all smalle files (owerwrite larger)" really look peculiar - I think "Overwrite options" is more correct

2. Then make it an [OK] [Cancel] - dialog - or at least enable the red close button in the title line.
Last edited by petermad on 2019-11-22, 20:05 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38395
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50] Mismatched translation reuse: 'Save copy options' title

Post by *ghisler(Author) » 2019-11-22, 15:38 UTC

1. OK, no problem for me
2. This cannot be changed in the standard message box. I will use Yes-No-Cancel
Author of Total Commander
http://www.ghisler.com

User avatar
Flint
Power Member
Power Member
Posts: 3248
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: [9.50] Mismatched translation reuse: 'Save copy options' title

Post by *Flint » 2019-11-27, 21:32 UTC

Confirm both the title change and Yes-No-Cancel in 9.50β7. Thanks, much better now!
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.22a / Win7 x64 SP1, Win10 x64

User avatar
petermad
Power Member
Power Member
Posts: 8967
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.50] Mismatched translation reuse: 'Save copy options' title

Post by *petermad » 2019-11-27, 23:34 UTC

String 5004="Overwrite options" is now used in the title of the "Save the following overwrite action as default?" dialog box.

String 5004 allows a hotkey - and if a hotkey is applied in a .lng file then the & from the hotkey is shown in the title of that dialog box.

See: https://madsenworld.dk/tcmd/overwritechoice.png

So I don't consider this issue fully solved :-(
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38395
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50] Mismatched translation reuse: 'Save copy options' title

Post by *ghisler(Author) » 2019-11-28, 11:20 UTC

No problem, I can remove the hotkey easily.
Author of Total Commander
http://www.ghisler.com

Post Reply