TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
HolgerK
Power Member
Power Member
Posts: 5217
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *HolgerK »

x86 version only:
- Files->Change Attributes...
- [more attributes] tc.comments
- press [>>] to open the "File comment" dialog

-> vertical scroll bar is not dark themed

"Files->Edit Comment... <Ctrl+Z>" the same(?) dialog is correct themed.

Regards
Holger
Make our planet great again

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39702
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *ghisler(Author) »

Strange, here both are not themed.
Author of Total Commander
http://www.ghisler.com

User avatar
HolgerK
Power Member
Power Member
Posts: 5217
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *HolgerK »

Maybe i used the wrong wording "themed".
What i meant was that the dark colors are not applied to the scroll bar of "edit comment"-dialog if its called from the 32 Bit TC "Set attribute-> plugin tc.comment" [>>]-Button:

http://holgerk.drivehq.com/TC9.50Beta/SetAttribEditComment(TC9.50,x86,beta4).png

Regards
Holger
Make our planet great again

User avatar
petermad
Power Member
Power Member
Posts: 9647
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *petermad »

Confirmed for TC 9.5b4 32bit version under windows 10 - and in both 64bit and 32 bit TC 9.5b4 under Windows 7
"Files->Edit Comment... <Ctrl+Z>" the same(?) dialog is correct themed.
Not under Windows 7 in TC 9.5b4 32- and 64bit - here the scrollbar is white too.
License #524
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.965 (x64)
TC 3.0 on Android 6.0
Get:
Extended Total Commander Menus | TC Languagebar | TC Dark Help | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39702
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *ghisler(Author) »

Unfortunately I had to remove the vertical scrollbar from this edit box completely for dark mode. You can still go through a big comment manually then, but not scroll with the mouse.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 9647
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *petermad »

Unfortunately I had to remove the vertical scrollbar from this edit box completely for dark mode. You can still go through a big comment manually then, but not scroll with the mouse.
Confirmed that vertical scrollbar is now removed in dark mode for both 32bit and 64bit TC 9.5b5 (Windows 7 and 10)
License #524
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.965 (x64)
TC 3.0 on Android 6.0
Get:
Extended Total Commander Menus | TC Languagebar | TC Dark Help | PHSM-Calendar

User avatar
DrShark
Power Member
Power Member
Posts: 1569
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *DrShark »

ghisler(Author) wrote:
2019-11-12, 20:12 UTC
Unfortunately I had to remove the vertical scrollbar from this edit box completely for dark mode
I hope it's a temporary solution, because the white scollbar in dark mode is better than no scrollbar at all.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39702
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *ghisler(Author) »

It's a bug in Windows 10 1809 - there the scrollbar should remain. It's as designed for older versions. I cannot draw the scrollbar myself there because it would interfere with the editing function.
Author of Total Commander
http://www.ghisler.com

User avatar
HolgerK
Power Member
Power Member
Posts: 5217
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *HolgerK »

The scroll bars removal is also applied for TC95.0B5x64 W10-1903 (where this bug was not present in B4x64).
Still the question why does the "File comment" dialog (Ctrl+Z) shows correct dark scroll bars in both version and the "File comment" dialog called from "Change attributes-plugins tc.comment" shows a bright scroll bars in x86-version.
Isn't it the same dialog?

If the scroll bar can not be owner drawn in x86, would it be possible to implement an auto hide feature (like in file panel)?
This way the bug would only be notable if the number of comment lines exceeds 14-18 lines (depending on dialog font size).

Regards
Holger
Make our planet great again

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39702
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *ghisler(Author) »

Still the question why does the "File comment" dialog (Ctrl+Z) shows correct dark scroll bars in both version and the "File comment" dialog called from "Change attributes-plugins tc.comment" shows a bright scroll bars in x86-version.
Isn't it the same dialog?
It is, and they look the same here.
Author of Total Commander
http://www.ghisler.com

User avatar
HolgerK
Power Member
Power Member
Posts: 5217
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *HolgerK »

HolgerK wrote:
2019-11-17, 19:53 UTC
The scroll bars removal is also applied for TC95.0B5x64 W10-1903 (where this bug was not present in B4x64).
Fixed with TC9.5B6x64 W10-1903; scroll bar is again visible.

If nobody else can reproduce the difference in TC9.5b6 x86 / W10pro x64 1903 between Ctrl+Z scroll bar (correct dark) and "File comment" dialog called from "Change attributes->plugins->tc.comment {>>]" (bright scroll bar), maybe this should be moved to behavior which will not be changed?

Regards
Holger
Make our planet great again

User avatar
tuska
Power Member
Power Member
Posts: 1999
Joined: 2007-05-21, 12:17 UTC

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *tuska »

HolgerK wrote:
2019-11-20, 21:02 UTC
If nobody else can reproduce the difference in TC9.5b6 x86 / W10pro x64 1903
between Ctrl+Z scroll bar (correct dark) and "File comment" dialog
called from "Change attributes->plugins->tc.comment {>>]" (bright scroll bar), ...
I can confirm a difference (x86): Picture


Windows 10 Pro (x64) Version 1909 (OS build 18363.476)
TC 9.50ß6 x64/x86 | Everything - Version 1.4.1.956 (x64)

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39702
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *ghisler(Author) »

Thanks, I was finally able to reproduce it on windows 10 1903. I don't have any idea why it happens, but I found a workaround (reapplying dark mode).
Author of Total Commander
http://www.ghisler.com

User avatar
HolgerK
Power Member
Power Member
Posts: 5217
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *HolgerK »

history.txt wrote:27.11.19 Fixed: Dark mode: "Edit comment" dialog called from "Change attributes" had bright title bar and scrollbar on Windows 10 1903 (32)
Confirmed fixed with TC9.5b7 x86 (W10pro x64 1903)

Thanks
Holger
Make our planet great again

User avatar
petermad
Power Member
Power Member
Posts: 9647
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50B4(x86) Dark mode: "File comment" called from "Change Attributes.."

Post by *petermad »

Confirmed that "Edit comment" dialog called from "Change attributes" now has dark scrollbar alsoin in 32bit TC9.5b7 :-)
License #524
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.965 (x64)
TC 3.0 on Android 6.0
Get:
Extended Total Commander Menus | TC Languagebar | TC Dark Help | PHSM-Calendar

Post Reply