[solved] TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 9597
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

[solved] TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *petermad »

Help:
ThumbIconSize=32 Size of the icons in mode "Thumbnails"
But the default size when the parameter is not present is 48

Which corresponds to this:
History.txt:
28.04.15 Added: Use 48x48 icons by default in thumbs mode on Vista or newer (32/64)
Last edited by petermad on 2019-11-13, 22:16 UTC, edited 1 time in total.
License #524
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.965 (x64)
TC 3.0 on Android 6.0
Get:
Extended Total Commander Menus | TC Languagebar | TC Dark Help | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39593
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *ghisler(Author) »

Well, I would have to leave the field empty because neither value is valid for all Windows versions. Therefore I will keep it as it is now because 58 would be equally wrong.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 9597
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *petermad »

Well a lot more people uses Vista or newer than pre-Vista OS'es.
License #524
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.965 (x64)
TC 3.0 on Android 6.0
Get:
Extended Total Commander Menus | TC Languagebar | TC Dark Help | PHSM-Calendar

User avatar
Usher
Power Member
Power Member
Posts: 845
Joined: 2011-03-11, 10:11 UTC

Re: TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *Usher »

Well, currently all XXI century desktop Windows from NT family are in more common use than Windows Vista: Windows 10, Windows 7, Windows 8.1, Windows XP and even Windows 8. See statistics:
https://netmarketshare.com/operating-system-market-share.aspx?options=%7B%22filter%22%3A%7B%22%24and%22%3A%5B%7B%22deviceType%22%3A%7B%22%24in%22%3A%5B%22D ... 1000%22%7D
Regards from Poland
Andrzej P. Wozniak

User avatar
petermad
Power Member
Power Member
Posts: 9597
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *petermad »

2Usher
I wrote Vista or newer - I don't see how that is not in accordance with that statistic?
License #524
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.965 (x64)
TC 3.0 on Android 6.0
Get:
Extended Total Commander Menus | TC Languagebar | TC Dark Help | PHSM-Calendar

User avatar
DrShark
Power Member
Power Member
Posts: 1569
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *DrShark »

ghisler(Author) wrote:
2019-11-11, 11:22 UTC
Well, I would have to leave the field empty because neither value is valid for all Windows versions. Therefore I will keep it as it is now because 58 would be equally wrong.
You can leave the current default value in help, but also add explanation that it varies depending on Windows version:
ThumbIconSize=32 Size of the icons in mode "Thumbnails". Default value depends on Windows version.
Next to this you can list the default values and Windows versions where they are used.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
Usher
Power Member
Power Member
Posts: 845
Joined: 2011-03-11, 10:11 UTC

Re: TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *Usher »

petermad wrote:
2019-11-12, 11:05 UTC
2Usher
I wrote Vista or newer - I don't see how that is not in accordance with that statistic?
Usage statistics show order which isn't based on first release time. It means that "Something or newer" is more like propaganda rather than a good measure of common use.
Regards from Poland
Andrzej P. Wozniak

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39593
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *ghisler(Author) »

That's a good point - isn't Vista also out of service now?
Author of Total Commander
http://www.ghisler.com

User avatar
tuska
Power Member
Power Member
Posts: 1976
Joined: 2007-05-21, 12:17 UTC

Re: TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *tuska »

ghisler(Author) wrote:
2019-11-12, 20:01 UTC
That's a good point - isn't Vista also out of service now?
I'm not sure, if this link helps...

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39593
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *ghisler(Author) »

It reports "Not Applicable". :)
Author of Total Commander
http://www.ghisler.com

User avatar
Usher
Power Member
Power Member
Posts: 845
Joined: 2011-03-11, 10:11 UTC

Re: TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *Usher »

2ghisler(Author)
Windows Vista support has ended in 2017, 10 years after GDR release, and 2 years before XP POSReady/Embedded/WEPOS end of support:
https://support.microsoft.com/en-us/help/22882/windows-vista-end-of-support
Regards from Poland
Andrzej P. Wozniak

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39593
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *ghisler(Author) »

Thanks for the clarification. I have changed it to 48 now.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 9597
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [solved] TC 9.5b4 - Wrong default value for ThumbIconSize in Help

Post by *petermad »

Confirmed changed in TC 9.5b5 :-)
License #524
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.965 (x64)
TC 3.0 on Android 6.0
Get:
Extended Total Commander Menus | TC Languagebar | TC Dark Help | PHSM-Calendar

Post Reply