[TC9.51] TC does not reload icons for changed buttons bar

Please report only one bug per message!

Moderators: white, Hacker, petermad, Stefan2

Post Reply
andry81
Junior Member
Junior Member
Posts: 97
Joined: 2018-11-22, 19:17 UTC

[TC9.51] TC does not reload icons for changed buttons bar

Post by *andry81 »

* Windows x64 Pro SP1

In case if the main button bar has paths containing environment variables:
[ButtonBar]
button=%MYVAR%\blabla.ico
and the button bar is changed before the WM_SETTINGCHANGE, then needs to manually open Button Bar dialog and press OK to trigger button bar icons reload. The point is the `MYVAR` here can change externally and TC does not reload the icons by the WM_SETTINGCHANGE message.

I think TC should reload the button bar because the button bar paths can contain environment variables.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48005
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC9.51] TC does not reload icons for changed buttons bar

Post by *ghisler(Author) »

This is intentional, otherwise caching bar files would be impossible.

To force a reload, simply go to Configuration - Change button bar and click OK.
Author of Total Commander
https://www.ghisler.com
andry81
Junior Member
Junior Member
Posts: 97
Joined: 2018-11-22, 19:17 UTC

Re: [TC9.51] TC does not reload icons for changed buttons bar

Post by *andry81 »

ghisler(Author) wrote: 2021-01-22, 17:33 UTC To force a reload, simply go to Configuration - Change button bar and click OK.
No need to change, it reloads even if just press OK. But why not does the same on WM_SETTINGCHANGE?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48005
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC9.51] TC does not reload icons for changed buttons bar

Post by *ghisler(Author) »

WM_SETTINGCHANGE can be quite frequent. Reloading the button bar can be very slow when there are many programs with individual icons, so it would cause a huge slowdown.
Author of Total Commander
https://www.ghisler.com
User avatar
sqa_wizard
Power Member
Power Member
Posts: 3854
Joined: 2003-02-06, 11:41 UTC
Location: Germany

Re: [TC9.51] TC does not reload icons for changed buttons bar

Post by *sqa_wizard »

... it would cause a huge slowdown.
Agree, furthermore the reloading would take effect only on the current button bar. All other button bars would remain unchanged which would be inconsistent.
#5767 Personal license
Post Reply