[Solved] Inconsistency between Internal English and wcmd_eng.lng for string 5269

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

[Solved] Inconsistency between Internal English and wcmd_eng.lng for string 5269

Post by *petermad »

In the wcmd_eng.lng file and the new750.txt file in the difres1000.zip translators package, string 5269 is
"Ask every time a Unicode name is encountered\nStore Unicode names as UTF-8 (Pkzip 4.5/Winzip 11.2 method)\nAll as UTF-8 if at least one contains Unicode\nAll as UTF-8 if at least one contains non-English characters\nStore Unicode name in extra field (Info-Zip method)\nStore all names containing non-English in extra field\nStore Unicode characters as '?'"
But the Internal english dialog is different:
"Ask every time a Unicode name is encountered\nStore all as UTF-8 (Pkzip 4.5/Winzip 11.2 method)\nAll as UTF-8 if at least one contains Unicode\nAll as UTF-8 if at least one contains non-English characters>127\nStore Unicode name in extra field (Info-Zip method)\nStore all names containing non-English in extra field\nStore Unicode characters as '?'"
Since "Store Unicode names as UTF-8" and Store all as UTF-8 doesn't excatly imply the same, I think one or the other should be changed in future versions of TC.

I think the Internal dialog is wrong writing "all" - otherwise the two next options does not make sence.
Last edited by petermad on 2022-04-21, 02:15 UTC, edited 3 times in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Inconsistency between Internal English and wcmd_eng.lng for string 5269

Post by *ghisler(Author) »

Yes, wcmd_eng.lng file is right - the second option here only stores Unicode names from a different codepage as UTF-8, and the rest (e.g. accents from your own codepage) as ansi/ascii text. The third option stores everything as UTF-8.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Inconsistency between Internal English and wcmd_eng.lng for string 5269

Post by *petermad »

history.txt wrote:10.11.21 Fixed: Configuration - Options - ZIP packer: in "Pack Unicode names", the second option (internal English only) was named incorrectly, it should be "Store Unicode names as UTF-8 (Pkzip 4.5/Winzip 11.2 method)" (32/64)
Confirmed that the second option is now changed in TC 10.50b1 to: "Store Unicode names as UTF-8 (Pkzip 4.5/Winzip 11.2 method)".

But the fourth option is still labelled diferently in Internal English and wcmd_eng.lng:
"All as UTF-8 if at least one contains characters>127"
"All as UTF-8 if at least one contains non-English characters"

It you choose to make the first of these two the preferred one, please ad a space before ">".

Or you could combine the two:
"All as UTF-8 if at least one contains non-English characters >127"

Notice that in option 6 the term "non-English characters" is used.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Inconsistency between Internal English and wcmd_eng.lng for string 5269

Post by *petermad »

2ghisler(Author)

In TC 10.50b2 the string is changed to:
"All as UTF-8 if at least one contains non-English characters > 127" :-)

Remember to change it likewise in the wcmd_eng.lng file.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Solved] Inconsistency between Internal English and wcmd_eng.lng for string 5269

Post by *ghisler(Author) »

Remember to change it likewise in the wcmd_eng.lng file.
I already did that, but thanks for the reminder.
Author of Total Commander
https://www.ghisler.com
Post Reply