Thumbnail View BUG in TC10

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Thumbnail View BUG in TC10

Post by *ghisler(Author) »

I will check it, thanks for your detailed tests.
Author of Total Commander
https://www.ghisler.com
slobodan2806
Junior Member
Junior Member
Posts: 8
Joined: 2021-11-07, 15:31 UTC

Re: Thumbnail View BUG in TC10

Post by *slobodan2806 »

Dear Ghisler,
thank you!

Best regards,
Slobodan
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Thumbnail View BUG in TC10

Post by *ghisler(Author) »

I have checked the code. It's caused by the new zooming feature:
1. When ThumbIconSize is smaller (<=) than the thumbnail size (zoomed or not), then ThumbIconSize will be used directly.
Example: ThumbIconSize=256, thumbnail size 256 or larger
2. When ThumbIconSize is larger (>) than the thumbnail size (zoomed or not), the icon size is reduced to one of the following fixed values:
16, 32 48 pixels.

In beta 6 and older, the icon size was reduced to the thumbnail size, which would look bad with many icons.
I don't want to go back to that, so maybe I should add a few more fixed sizes, e.g.
16, 32 48, 64, 96, 128, 192, 256 pixels when ThumbIconSize is larger (>) than the thumbnail size.
Or alternatively do the full zooming when ThumbIconSize is set to a certain minimum size like 128 or 256?

What do you think?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14742
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Thumbnail View BUG in TC10

Post by *petermad »

1. When ThumbIconSize is smaller (<=) than the thumbnail size (zoomed or not), then ThumbIconSize will be used directly.
It seems to me that you use < and not <= because a thumbnail size of 256x256 in my book equals a ThumbIconSize of 256

As it is now I have to experiment to find out that a setting of ThumbIconSize=220 will give a folder icon larger than 48 pixels. It would be more intuitive that if the two sizes are equal then they will both be used.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Thumbnail View BUG in TC10

Post by *ghisler(Author) »

On which Windows version did you try that?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14742
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Thumbnail View BUG in TC10

Post by *petermad »

ghisler(Author) wrote: 2021-11-12, 11:33 UTC On which Windows version did you try that?
That was on Windows 7.

I have now tried on Windows 10 21H1 and there:
ThumbWidthNoCache=256
ThumbHeightNoCache=256
ThumbIconSize=256
works, showing 256 pixel folder icons

But under Windows 7 I need to use:
ThumbWidthNoCache=256
ThumbHeightNoCache=256
ThumbIconSize=220
to get the 256 pixels folder icons
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Thumbnail View BUG in TC10

Post by *ghisler(Author) »

That's because on Windows 7, a single item in a listbox can have a maximum height of 255 pixel (including the text below the image).

I added a fix in beta 7 for this:
22.04.21 Fixed: On Windows 10 older than 1709 (Fall 2017) and older Windows versions, scale thumbnails if the size entered by the user is larger than 240, so the line would become higher than 255 pixels (32/64)
Without this fix, the lines could be only a few pixels high.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14742
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Thumbnail View BUG in TC10

Post by *petermad »

2ghisler(Author)

Aha - but still I have to use the value of 220 for ThumbIconSize and not 240 to get a full thumbnail (1 line of text under thumbnail) - so it seems that not quite the same algoritm is used for ThumbIconSize and ThumbHeightNoCache.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Thumbnail View BUG in TC10

Post by *ghisler(Author) »

Yes, because 255 is the maximum for the entire line, including the icon, the file name, and any extra fields.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Thumbnail View BUG in TC10

Post by *ghisler(Author) »

Please try this with Total Commander 10.50 beta, it should be fixed.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14742
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Thumbnail View BUG in TC10

Post by *petermad »

In TC 10.50b2 32bit and 64bit under Windows 7, I can now use ThumbIconSize=256 to show 256 pixel folder icons :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Thumbnail View BUG in TC10

Post by *ghisler(Author) »

Great, thanks for trying! While the function to set the line height doesn't support values >255 in Windows 7, I can recreate the listbox with the larger height, so that's what I'm doing now.
Author of Total Commander
https://www.ghisler.com
Post Reply