Solved TC 10.00/TC10.5b3 Buttonbar with Popup Menü

[ghisler(Author)]

I can still reproduce it in Dark mode. Most visible with icon size 32 or larger and Small icons disabled.

Do you mean the icon size in the button bar? Or in the file lists?

[petermad]

In the button bar

[ghisler(Author)]

Just tried that, but unfortunately the context menus appear just fine.

[petermad]

2ghisler(Author)

Ok - try this:
1. Download https://madsenworld.dk/tcmd/testbuttonbar.zip
2. Unpack the 3 files to the directory where you have your wincmd.ini file.
3. Start a new instance of TC using the test.ini file.
4. Click on the rightmost button in the button bar (Internal commands button bar).
5. Right-click on any item in the button bar menu.

You will see that more or less of the characters in the right side of the context menu is cut off.

This ONLY applies to 64bit TC
Tested under Windows 10 and 7.

[white]

Confirmed.

And why is this context menu a different style (no rounded corners and white thick border)?

[ghisler(Author)]

Thanks, I was able to reproduce it now! The border style is wrong because subclassing of the menu failed. This is also the reason it isn't sized correctly. It doesn't do this with my own ini. I will check in the debugger why it fails only with these settings.

[vianova]

Thanks Christian,
Issue resolved in TC 10.5b4

[petermad]

Fixed in TC 10.50b4 but only under Windows 10 - Under Windows 7 the context menu is not dark themed anymore - but neither is any other context menu in Dark mode under Windows 7, so it is actually weird that it was themed for buttonbar submenu items before.

[white]

Tested OK using TC10.50b4.

[ghisler(Author)]

Under Windows 7 the context menu is not dark themed anymore - but neither is any other context menu in Dark mode under Windows 7, so it is actually weird that it was themed for buttonbar submenu items before.

Indeed I'm using the same menu now as when right clicking directly on a button. The difference is that this new menu is drawn by Windows itself, while the old one with the odd border colors was owner drawn (by my own code).

The one drawn by Windows itself can be set to dark mode on Windows 10, but Windows 7 doesn't have the concept of a dark mode.
The one drawn by TC can be drawn manually in dark colors, but the border is still drawn by Windows. It's difficult to correctly size this and overdraw the borders, so I decided to let Windows draw the menu instead.