Solved [TC 10.50b2] Extra thick lines around Rules section Auto Switch Mode dialog

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Solved [TC 10.50b2] Extra thick lines around Rules section Auto Switch Mode dialog

Post by *petermad »

The lines around sections in Dark mode are getting better and better also under Windows 7, but there is still an extra thick line around the Rules section the Auto Switch Mode configuration dialog. And it is both under Windows 7 and Windows 10.

In 64bit TC all 4 line are extra thick and bright, in 32bit TC only right and bottom lines are bright but they are all too thick.

See: https://madsenworld.dk/tcmd/darkmodeautoswitchdialog.png
Last edited by petermad on 2022-04-29, 10:41 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b2] Extra thick lines around Rules section Auto Switch Mode dialog

Post by *ghisler(Author) »

This is a so-called Scrollbox control. You can see the same control in "Change attributes" and the print preview dialog.
It's a lot of work to replace it with my own control, so I can't say if I will ever find the time to do that, sorry.
Author of Total Commander
https://www.ghisler.com
CoolWater
Power Member
Power Member
Posts: 737
Joined: 2003-03-27, 16:33 UTC

Re: [TC 10.50b2] Extra thick lines around Rules section Auto Switch Mode dialog

Post by *CoolWater »

Have you tried to subclass the control and process WM_NCPAINT (and WM_THEMECHANGED) and draw the border yourself using DrawThemeBackground? This way, I replaced the border of a CRichEditCtrl in MFC (which normally has a 3D border).
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b2] Extra thick lines around Rules section Auto Switch Mode dialog

Post by *petermad »

ghisler(Author) wrote: 2022-04-22, 08:08 UTC This is a so-called Scrollbox control. You can see the same control in "Change attributes" and the print preview dialog.
Aha - yes I also see it in the Plugins tab of the Find Files dialog.

Talking about the Find Files dialog in black mode:
The horizontal section divider lines in the General and the Advanced tab are also thick and bright.
In the Load/Save tab the frame around the "Previous searches" field i thick and bright until hovered by the mouse (except in 32bit TC under Windows 7)

In All dialogs:
Spin controls like In foe example the Advanced tab at the end ot the "Not older than", the "Older than" and the "File size" fields has an extra line on top and two extra lines at the right side and bottom - but ONLY in 32bit TC (both Windows 10 and 7).
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b2] Extra thick lines around Rules section Auto Switch Mode dialog

Post by *ghisler(Author) »

They are not actually spin controls, they are just scrollbars. I'm looking for a replacement because Windows 11 doesn't display the up/down triangles until you move the mouse over the control, which is very unfortunate.
Author of Total Commander
https://www.ghisler.com
CoolWater
Power Member
Power Member
Posts: 737
Joined: 2003-03-27, 16:33 UTC

Re: [TC 10.50b2] Extra thick lines around Rules section Auto Switch Mode dialog

Post by *CoolWater »

Fixed in b3, TC 32 bit. But it should also have a smaller border in non-darkmode. At least in 32 bit version, there is a "sunken" border.
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b2] Extra thick lines around Rules section Auto Switch Mode dialog

Post by *petermad »

Fixed in TC 10.50b3 concerning the Rules section in the Auto Switch Mode dialog in the Plugins section of the Change attributes dialog and the Plugisn tab of the Find Files dialog.

I still see extra thick hrisontal dividers in the General and Advanced tabs in the Find Files dialg - and the small scrollbars in 32bit TC still have thick lines on the top and right side.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b2] Extra thick lines around Rules section Auto Switch Mode dialog

Post by *ghisler(Author) »

Thanks for confirming the bugfix! In non dark mode, it uses the standard look of this control.

The dividers are a different control, please submit a new bug report if you want to see them changed.
Author of Total Commander
https://www.ghisler.com
CoolWater
Power Member
Power Member
Posts: 737
Joined: 2003-03-27, 16:33 UTC

Re: Solved [TC 10.50b2] Extra thick lines around Rules section Auto Switch Mode dialog

Post by *CoolWater »

FYI: The standard look in non dark mode differs in 32 bit and 64 bit version. In 64 bit version, the frame is small (but 2 pixel wide, the inner frame is white), in 32 bit version, the frame is thick and in "sunken" style.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Solved [TC 10.50b2] Extra thick lines around Rules section Auto Switch Mode dialog

Post by *ghisler(Author) »

TC 32-bit uses Delphi while TC 64-bit uses Lazarus. They each have their own controls which may be implemented slightly differently.
Author of Total Commander
https://www.ghisler.com
Post Reply