[TC 10.50b5] Options - Edit/View

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

User avatar
white
Power Member
Power Member
Posts: 4615
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.50b5] Options - Edit/View

Post by *white »

ghisler(Author) wrote: 2022-05-20, 09:01 UTC Doesn't this look odd with the two buttons not ending at the same position?
No, it helps the brain to understand that one button is indented, so a sub option of External viewer.
User avatar
petermad
Power Member
Power Member
Posts: 14791
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *petermad »

2ghisler(Author)
Maybe I should make the "configure internal viewer" button a bit wider so it ends at the same position as the "Associations" button?
Doesn't it already do that ? See: https://madsenworld.dk/tcmd/editview3.png
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4615
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.50b5] Options - Edit/View

Post by *white »

petermad wrote: 2022-05-20, 13:33 UTC
Maybe I should make the "configure internal viewer" button a bit wider so it ends at the same position as the "Associations" button?
Doesn't it already do that ? See: https://madsenworld.dk/tcmd/editview3.png
I proposed a different one and Ghisler was responding to that.
white wrote: 2022-05-19, 16:52 UTC 2ghisler(Author)
  • I think the dialog becomes more clear if you don't stretch the buttons to full length like you have done now in beta 6.
  • And I think it is more readable if you indent at the other places too, not only under "Hotkeys".
  • There could be a bit more margin at the right within the groupbox border.
  • Here is another mockup showing what I mean.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48075
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *ghisler(Author) »

Yes, I meant the width of the "configure internal viewer" button in white's mock-up. What do you think?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14791
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *petermad »

I think I like Whites shorter buttons better.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48075
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *ghisler(Author) »

That's not the question here, I already made them shorter.
The question is whether the buttons "Configure internal viewer" and "Associations" should have the same width, or the same end position. I think it looks odd with the same width.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14791
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *petermad »

Definitely the same width and alignment
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4615
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.50b5] Options - Edit/View

Post by *white »

petermad wrote: 2022-05-23, 14:38 UTC Definitely the same width and alignment
It's still not clear what you mean. Do you mean the same alignment as in my mockup or do you want the buttons aligned? In case of the latter, where do you position them?

In my mockup I indented the options under a header, consistent with what was done under the "Hotkeys:" header. The first button doesn't have a header so I placed that button on the main level.

What do you think is the best alignment? The same as my mockup or different? In case of the latter, please describe the alignment of each option.
User avatar
petermad
Power Member
Power Member
Posts: 14791
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *petermad »

Tough to say, but I lean towards that the two buttons are aligned to each other at the left - that could mean either add indentation to the "Configure internal viewer" button or remove indentation from the "Associations" button - I think indenting the "Configure internal viewer" button will look the best.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48075
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *ghisler(Author) »

I think indenting the "Configure internal viewer" button will look the best.
That sounds like a good idea, I will try that in beta 7.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14791
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *petermad »

I think it looks good in TC 10.50b7 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
KozakMak
Senior Member
Senior Member
Posts: 359
Joined: 2021-05-24, 12:39 UTC
Location: UA

Re: [TC 10.50b5] Options - Edit/View

Post by *KozakMak »

OS: Win10 | TC: latest x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48075
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *ghisler(Author) »

Both buttons are set to exactly 2 pixels higher than the edit boxes. What you see is a rounding error when resizing the dialog. This cannot be avoided, sorry.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14791
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *petermad »

License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4615
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.50b5] Options - Edit/View

Post by *white »

ghisler(Author) wrote: 2022-05-26, 09:41 UTC Both buttons are set to exactly 2 pixels higher than the edit boxes. What you see is a rounding error when resizing the dialog. This cannot be avoided, sorry.
Well, all screenshots so far show the lower button too low. If the rounding error is that consistent you can compensate for that for the lower button, can't you?
Post Reply