[TC 10.50b5] Options - Edit/View

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

User avatar
jinsight
Senior Member
Senior Member
Posts: 299
Joined: 2003-02-25, 19:47 UTC
Location: Wooster, Ohio, USA

Re: [TC 10.50b5] Options - Edit/View

Post by *jinsight »

Support++ for White's suggestion as to the order of elements in Configuration > Operation > Edit/View
The resulting order seems like an intuitive order:
* Configure internal viewer
* External Viewer settings
* Hotkeys settings
License #1945
Windows 10 Pro x64
Version 22H2 (OS Build 19045.3930)
TC 11.00 x64 and x86, Everything 1.5.0.1366a x64, QAP 11.6.3.1 x64
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 10.50b5] Options - Edit/View

Post by *AntonyD »

Do I understand correctly that Last one it was a question of moving the Hotkey section below and taking it out of the viewing and editing sections altogether? If true, then why is it logical at all? After all, these keys have a connection and meaning only for the F3 viewing section. And it is quite clear that they are inside. If it is incorrect, then I'm sorry, then I just misunderstood the meaning of what was described.
But in general, I am very impressed with the current final appearance of this tab of the settings dialog.
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *petermad »

I see. But I looked at Configuration - Options - Misc, and it's not in all caps there either.
There is actually no SHIFT or ALT (all caps) anywhere in the English language strings in wcmd_eng.lng. It is only in the Internal strings - time to change that from all-uppercase.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4594
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.50b5] Options - Edit/View

Post by *white »

AntonDudarenko wrote: 2022-05-17, 17:10 UTC Do I understand correctly that Last one it was a question of moving the Hotkey section below and taking it out of the viewing and editing sections altogether?
No that is not what I meant. I meant changing the order within "Viewer for F3" group box.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *ghisler(Author) »

I think that's debatable. But regardless whether it is technically correct, why do you prefer it? Do you think it looks nicer?
No, I want to give the user a hint that he configures a viewer for F3 and editor for F4, not for opening a file with Enter or so.
I see. But I looked at Configuration - Options - Misc, and it's not in all caps there either.
The translated ones usually aren't - the English ones are hard coded and should not be all uppercase either. I will change it.
In that case you could also reverse the order.
That would indeed be an option where the string could be repeated without making it look strange.
I will try it in the next beta.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10.50b5] Options - Edit/View

Post by *Usher »

2ghisler(Author)
Note the difference:
* Configuration -> Options -> Misc. -> Hotkeys: spaces are used, f.e. Control + Alt + F5
* Start - > Chage start menu -> Shortcut key: NO spaces, f.e. Control+Alt+F3
Andrzej P. Wozniak
Polish subforum moderator
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *petermad »

Note the difference:
* Configuration -> Options -> Misc. -> Hotkeys: spaces are used, f.e. Control + Alt + F5
* Start - > Chage start menu -> Shortcut key: NO spaces, f.e. Control+Alt+F3
IMH - spaces should never be used for hotkey-combinations.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4594
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.50b5] Options - Edit/View

Post by *white »

white wrote: 2022-05-17, 10:36 UTC You didn't change the group labels "Viewer for F3" and "Editor for F4" to simply "Viewer" and "Editor".
Why? "Viewer for F3" isn't a correct description and the additional "for F?" doesn't seem necessary.
ghisler(Author) wrote: 2022-05-17, 20:19 UTC
I think that's debatable. But regardless whether it is technically correct, why do you prefer it? Do you think it looks nicer?
No, I want to give the user a hint that he configures a viewer for F3 and editor for F4, not for opening a file with Enter or so.
Not for opening a file with Enter or so.... Really?
I think you can safely leave it out. Besides shouldn't it then be the following?
Viewer for F3 and for command line parameter /S=L and for cm_List assigned to button, directory hotlist, start menu or alias
And you forgot to do it everywhere else.
Copy for F5
Delete for F8
FTP for Ctrl+F
Packer for Alt+F5
User avatar
white
Power Member
Power Member
Posts: 4594
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.50b5] Options - Edit/View

Post by *white »

petermad wrote: 2022-05-18, 02:32 UTC
Note the difference:
* Configuration -> Options -> Misc. -> Hotkeys: spaces are used, f.e. Control + Alt + F5
* Start - > Chage start menu -> Shortcut key: NO spaces, f.e. Control+Alt+F3
IMH - spaces should never be used for hotkey-combinations.
As far as I can tell, spaces weren't used anywhere else. Now that he's reusing the strings, it's get used in Configuration - Edit/View as well.
I understand why he did it when defining hotkeys (because you click each modifier key separately). By the way, there seems to be a bug in Dark mode when listing the hotkeys. White space is missing before and after the hotkeys. Screenshot: here.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *ghisler(Author) »

No problem, I will remove the spaces. I hope that there aren't any languages which use two words for Alt or Shift...
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 10.50b5] Options - Edit/View

Post by *AntonyD »

It is really strange but the width of this button |>>| is always changing - on one tab it's equal to 35px, on another - 38px.
Here at the current example - it's already 39px!!! Why it's not a fixed one???

I understand that there is a need to adjust the dimensions of some elements so that the text fits into them, so that they fit beautifully on the form. BUT there can't be different reasons for this button to have different widths! It should be a square button with one size in 35 px!

I clarify that the dimensions were taken at DPI = 120. Of course, with a different value, the width of the button will have to take a different value.
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *petermad »

history.txt wrote:18.05.22 Fixed: Rearranged dialog box items again in Configuration - Options - Edit/View, removed spaces from hotkeys (32/64)
Confirmed that the spaces are removed from the hotkeys - and that the internal English no longer uses all uppercase for the hotkeys in TC 10.50b6 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4594
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.50b5] Options - Edit/View

Post by *white »

2ghisler(Author)
  • I think the dialog becomes more clear if you don't stretch the buttons to full length like you have done now in beta 6.
  • And I think it is more readable if you indent at the other places too, not only under "Hotkeys".
  • There could be a bit more margin at the right within the groupbox border.
  • Here is another mockup showing what I mean.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b5] Options - Edit/View

Post by *ghisler(Author) »

Doesn't this look odd with the two buttons not ending at the same position? Maybe I should make the "configure internal viewer" button a bit wider so it ends at the same position as the "Associations" button?
Author of Total Commander
https://www.ghisler.com
Post Reply