[TC10.50b7] Inconsistent category headers in TOTALCMD.INC

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
white
Power Member
Power Member
Posts: 4596
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC10.50b7] Inconsistent category headers in TOTALCMD.INC

Post by *white »

Inconsistent category headers in TOTALCMD.INC

The first 21 headers use 16 underscores in front of and behind the category name and no spaces are used in the name.
Then 1 header uses 15 en 14 underscores.
Then 3 headers use 8 en 9 underscores and use spaces between words.

Code: Select all

Search "__.*" (25 hits in 1 file of 1 searched)
  TOTALCMD.INC (25 hits)
	Line   1: [________________Source________________]=0
	Line  25: [________________Left________________]=0
	Line  51: [________________Right________________]=0
	Line  77: [________________FileOperations________________]=0
	Line 115: [________________Configuration________________]=0
	Line 150: [________________Network________________]=0
	Line 158: [________________Misc________________]=0
	Line 191: [________________ParallelPort________________]=0
	Line 196: [________________Print________________]=0
	Line 201: [________________Mark________________]=0
	Line 249: [________________Security________________]=0
	Line 255: [________________Clipboard________________]=0
	Line 271: [________________FTP________________]=0
	Line 282: [________________Navigation________________]=0
	Line 320: [________________Help________________]=0
	Line 327: [________________Window________________]=0
	Line 333: [________________CommandLine________________]=0
	Line 339: [________________Tools________________]=0
	Line 356: [________________View________________]=0
	Line 407: [________________User________________]=0
	Line 419: [________________Tabs________________]=0
	Line 477: [_______________Sorting______________]=0
	Line 526: [________Custom column views_________]=0
	Line 577: [________View modes_________]=0
	Line 620: [________Commands with parameters_________]=0
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.50b7] Inconsistent category headers in TOTALCMD.INC

Post by *ghisler(Author) »

Who cares, they aren't shown like that in the user interface...
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4596
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50b7] Inconsistent category headers in TOTALCMD.INC

Post by *white »

ghisler(Author) wrote: 2022-06-01, 06:47 UTC Who cares..
Do you really want me to make an assessment whether someone cares before I report anything? Please let me know.
ghisler(Author) wrote: 2022-06-01, 06:47 UTC ..they aren't shown like that in the user interface...
That's not true for the inconsistent use of spaces and capitalization in:

FileOperations
ParallelPort
CommandLine
Custom column views
View modes
Commands with parameters
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.50b7] Inconsistent category headers in TOTALCMD.INC

Post by *ghisler(Author) »

They are shown like this in the command picker dialog:
Source ======================================

The headers in the inc are just for orientation of the translators...
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4596
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50b7] Inconsistent category headers in TOTALCMD.INC

Post by *white »

ghisler(Author) wrote: 2022-06-01, 07:31 UTC The headers in the inc are just for orientation of the translators...
Yes, if you refer to the underscores. No, if you refer to the text.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.50b7] Inconsistent category headers in TOTALCMD.INC

Post by *ghisler(Author) »

I can't just change the text, because the translations are based on the text.
So when I change e.g. FileOperations to File Operations, it would no longer get translated.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4596
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50b7] Inconsistent category headers in TOTALCMD.INC

Post by *white »

ghisler(Author) wrote: 2022-06-01, 14:14 UTC I can't just change the text, because the translations are based on the text.
Since the change is only spaces and capitalization you could, when you read the files, replace the keys with keys without spaces. That would make it more flexible too.

And you could change the format of Totalcmd.inc a bit to allow to specify a different display name for the category.

Code: Select all

[________________FileOperations________________]=0
CatDisplayname=File Operations
cm_List=903;View with Lister
cm_ListInternalOnly=1006;Lister without plugins/multimedia, single file
cm_ListInternalMulti=2933;Lister without plugins/multimedia, selected
cm_ListOnly=2934;Lister with plugins/multimedia, single file
cm_ListMulti=2935;Lister with plugins/multimedia, selected
cm_Edit=904;Edit (Notepad)
Or you could use a negative command number to specify a display name.
User avatar
white
Power Member
Power Member
Posts: 4596
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50b7] Inconsistent category headers in TOTALCMD.INC

Post by *white »

HISTORY.TXT wrote:06.06.22 Fixed: Titles in totalcmd.inc are now more consistent, but they will not get translated with older versions of Total Commander (32/64)
Tested OK using TC10.50rc1.

Moderator message from: white » 2022-06-08, 21:40 UTC

Moved to Fixed bugs.
Post Reply