Pack -> Tree / Several UI Problems

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
funkymonk
Senior Member
Senior Member
Posts: 410
Joined: 2013-12-04, 09:56 UTC

Pack -> Tree / Several UI Problems

Post by *funkymonk »

With TC10.50rc1 x32 black+light @ Win10x64, there is several problems with the Tree dialog in Pack (Alt+F5):
  1. The border around the drive list box is not drawn correctly (here: parts of the top border are missing).
  2. The dialog can be resized arbitrarily (down to a size where only the title bar remains visible).
    When doing so, some UI elements within do resize automatically, others keep a fixed size. Both looks awkward depending on how small the window is.
    In addition, some elements get out of view for small dialog sizes (e.g., Everything or re-scan).
  3. When clicking into the Quick Search text box, text can be entered but there is no visible cursor.
    Apart, no text can be selected/copied/pasted in this text box.
  4. Open the "Print..." dialog and close it again. From now on, the Quick Search text box does no longer accept any input. Re-opening the Tree dialog solves this problem.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Pack -> Tree / Several UI Problems

Post by *ghisler(Author) »

1. Not confirmed. Please let me know your font settings and scaling settings.
2. The size is not limited, I don't plan to change that.
3. It's not an edit box, and it cannot get the focus. You can type while anywhere in the dialog.
4. Not confirmed. Please note that you can only enter characters when there is a match. So when you have e.g. entered windows and want to search for system now, you need to press backspace until the quick search text is cleared.
Author of Total Commander
https://www.ghisler.com
User avatar
funkymonk
Senior Member
Senior Member
Posts: 410
Joined: 2013-12-04, 09:56 UTC

Re: Pack -> Tree / Several UI Problems

Post by *funkymonk »

  1. "Not confirmed. Please let me know your font settings and scaling settings."
    Segoe UI, Standard, 11 on various systems from fhd to 3840x2160 resolution and various dpi settings (e.g., 120, 150, auto).
    Here is a screenshot: https://ibb.co/jrr9kGH
    .
  2. "The size is not limited, I don't plan to change that."
    Ok. Still, is the dialog really meant to look like these examples?
    https://ibb.co/BVHhgN3
    https://ibb.co/10ctzSb
    Some UI elements are simply not visible, others are cut or do overlap each other...
    .
  3. "It's not an edit box, and it cannot get the focus."
    Ok, if a user knows that it might be fine. Still, it's quite confusing since the "non-edit box" looks like an edit box but does not behave like one.
    Maybe that's just me, but I guess, most users will assume that a rectangle that appears right behind a "Schnelle Suche:" label is something where you can enter text (with a regular cursor). In fact, other (similar looking) rectangles in TC are indeed text boxes (e.g., in the pack dialog itself).

    "You can type while anywhere in the dialog."
    No. Example for https://ibb.co/jrr9kGH:
    Open Tree view --> Start typing "P0" --> TC jumps to "P01" --> fine! --> Open "Print..." --> close print dialog --> continue typing "2" --> input not accepted!
    Only if the tree control gets the focus again (via mouse or tab) you can continue typing.
    It is not even sufficient to click the "non-edit box" to let the dialog accept more characters...

    (For the sake of consistency: Would it be a big problem to use a regular edit box and still allow the user to type when the tree control or the edit box or any other control has the focus?)
    .
  4. "Please note that you can only enter characters when there is a match."
    Sure. Makes total sense to me.

BTW: Is there any hotkey to jump to the next/prev match?
In fact, all F-keys (except F1 and F2) simply clear the "non-edit box". It this intended?
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Pack -> Tree / Several UI Problems

Post by *Usher »

funkymonk wrote: 2022-06-13, 21:29 UTC BTW: Is there any hotkey to jump to the next/prev match?
Just press F1 and read the TC Help.
TC Help wrote: Dialog box: Directory Tree

Quick search
If the dialog box with the directory tree is active, you can type the first letters of the desired directory. They are then shown in this field. The cursor is automatically positioned on the next directory starting with these letters. Supports wildcards * and ? just like in normal quick search. Press CTRL+ENTER or CTRL+Down to move the cursor to the next match, or CTRL+Up to go to the previous match.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Pack -> Tree / Several UI Problems

Post by *ghisler(Author) »

2funkymonk
1. No problem with Segoe UI 11. My screen is 96 dpi. so I tried setting the DPI in TC itself to 120, no problem. It looks like the font drawing is somehow overdrawing the borders, very strange. Never seen that in comboboxes.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Pack -> Tree / Several UI Problems

Post by *ghisler(Author) »

I was now able to reproduce it by setting the Windows scaling factor to 125% instead of setting the DPI in TC itself to 120 DPI. The problem is the function TextOut, it draws this extra background although the text isn't that high. Changing the background to transparent seems to fix the problem.
Author of Total Commander
https://www.ghisler.com
User avatar
funkymonk
Senior Member
Senior Member
Posts: 410
Joined: 2013-12-04, 09:56 UTC

Re: Pack -> Tree / Several UI Problems

Post by *funkymonk »

Ok, the PC I am currently working on has 150% scaling in Win10 @ 3840x2160 and auto dpi for TC 10.50rc1 x32 dark). The problem shows up here as well.

UPDATE: For Segoe UI, Standard, 11, I have just tried with all scaling factors offered by Win10 for 1920x1080 and 3840x2160. The problem shows up for all of them except 100%.
I cannot test more at the moment. Maybe that still helps.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Pack -> Tree / Several UI Problems

Post by *ghisler(Author) »

1 should be fixed now in RC2, please test it!
Author of Total Commander
https://www.ghisler.com
User avatar
funkymonk
Senior Member
Senior Member
Posts: 410
Joined: 2013-12-04, 09:56 UTC

Re: Pack -> Tree / Several UI Problems

Post by *funkymonk »

Confirmed. 1 is fixed. Thank you! 2-4 remain.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Pack -> Tree / Several UI Problems

Post by *ghisler(Author) »

Great, thanks! I will not change 2-4 for the above listed reasons, so I will move this thread to "will not be changed".
Author of Total Commander
https://www.ghisler.com
Post Reply