[TC10.50rc1] search dialog visual bug

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

KozakMak
Senior Member
Senior Member
Posts: 352
Joined: 2021-05-24, 12:39 UTC
Location: UA

[TC10.50rc1] search dialog visual bug

Post by *KozakMak »

OS: Win10 | TC: latest x64
User avatar
white
Power Member
Power Member
Posts: 4596
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50rc1] search dialog visual bug

Post by *white »

Confirmed for 64-bit only and in Dark mode. For all betas and for version 10.00 as well.
Windows scaling 100%, clean ini.
User avatar
white
Power Member
Power Member
Posts: 4596
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50rc1] search dialog visual bug

Post by *white »

The visual bug exists since the beginning of dark mode in version 9.50.

On the Advanced tab as well: Screenshot
JOUBE
Power Member
Power Member
Posts: 1448
Joined: 2004-07-08, 08:58 UTC

Re: [TC10.50rc1] search dialog visual bug

Post by *JOUBE »

Not confirmed. No problems with this here.
User avatar
nsp
Power Member
Power Member
Posts: 1804
Joined: 2005-12-04, 08:39 UTC
Location: Lyon (FRANCE)
Contact:

Re: [TC10.50rc1] search dialog visual bug

Post by *nsp »

All is clean with 1920x1080 100% English/French on my machine when i resize the dialog.
The issue is that the drawing/refresh of the group/separator line is done before the element in Dark Mode but all is fine in Normal mode. @Ghisler(Author) you can check how the paint is done and ensure that line are painted the lasts on DarkMode
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.50rc1] search dialog visual bug

Post by *ghisler(Author) »

Sorry, this cannot be avoided when the controls are longer. Just make the dialog box a bit larger.
Author of Total Commander
https://www.ghisler.com
User avatar
nsp
Power Member
Power Member
Posts: 1804
Joined: 2005-12-04, 08:39 UTC
Location: Lyon (FRANCE)
Contact:

Re: [TC10.50rc1] search dialog visual bug

Post by *nsp »

Why this does not occurs in Normal Mode ?
https://i.postimg.cc/Bv6tCqhM/Untitled.png
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.50rc1] search dialog visual bug

Post by *ghisler(Author) »

The borders are drawn in my code in dark mode, and by Windows in normal mode. I couldn't find out how Windows prevents the overdrawing. Normally the borders should be drawn in WM_NCPAINT, but this message isn't sent for tabs, so I draw it in WM_PAINT. But I found a solution: I make the checkboxes smaller when you resize the window so they fit into the space and don't overlap.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14743
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC10.50rc1] search dialog visual bug

Post by *petermad »

history.txt wrote:15.06.22 Fixed: Find files: Manually resize checkboxes ANSI, ASCII etc. so they don't overlap the right border in dark mode (64)
Confimed fixed in TC 10.50rc2 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4596
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50rc1] search dialog visual bug

Post by *white »

white wrote: 2022-06-14, 20:47 UTC On the Advanced tab as well: Screenshot
Not fixed in TC10.50 64-bit.

For 64-bit the box within the border is less wide. Screenshot
The tab controls seems to have the same widths though. Screenshot
It looks like for 32-bit the outer border is drawn and for 64-bit the inner border.
User avatar
petermad
Power Member
Power Member
Posts: 14743
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC10.50rc1] search dialog visual bug

Post by *petermad »

On the Advanced tab as well: Screenshot

Not fixed in TC10.50 64-bit.
Confirmed not fixed for the Advanced tab.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.50rc1] search dialog visual bug

Post by *ghisler(Author) »

I do not get this problem on the second page because I can't make it narrow enough. Maybe a font problem?
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4596
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50rc1] search dialog visual bug

Post by *white »

ghisler(Author) wrote: 2022-06-16, 08:35 UTC Maybe a font problem?
No, it was tested with new ini and switched to dark mode.
ghisler(Author) wrote: 2022-06-16, 08:35 UTC I do not get this problem on the second page because I can't make it narrow enough.
What is your window size with a new ini?
User avatar
white
Power Member
Power Member
Posts: 4596
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50rc1] search dialog visual bug

Post by *white »

Moderator message from: white » 2022-06-16, 09:21 UTC

Moved back to Bugs forum.
User avatar
petermad
Power Member
Power Member
Posts: 14743
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC10.50rc1] search dialog visual bug

Post by *petermad »

No, it was tested with new ini and switched to dark mode.
Same here - no special font setting, no TC OR Windows scaling.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply