Non-rendering of icons on large toolbars

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Non-rendering of icons on large toolbars

Post by *Fla$her »

A very old problem that, surprisingly, has never been considered here.
With a large number of icons in the toolbar (510+, 550, 600, etc.), when using TC, situations occur when some of the icons are not drawn. It can be several icons at the end of the list or in any other places. Sometimes, when switching to one or another, everything stops rendering at all, and it even leads to blank falls and crashes like this:

Code: Select all

---------------------------
Total Commander 10.50RC2
---------------------------
Invalid floating point operation.
Windows 7 SP1 Ultimate 6.1 (Build 7601), base: 00400000

Windows exception: C0000092
Stack trace:
005D1349
0048F043  004023FB  004026C4  005D536B  0044CE31  0044EE36
>0042A806  0044E3D4  0042A806  00430041  004300DC  
Raw:
004C006E  004C006E  00403154  0048E969  0044DFFE  0044DFFE
0048E9BA  0044DFFE  0044E49E  0040779E  0048F043  0048F059
004020AE  00402255  004023FB  004023FB  004026C4  00402D9A
00402FE3  00402DC7  00402DD5  00403419  005DC004  004C006E
005C0030  005F0077  0042A806  0044CE31  0044EE36  0044EE59
0042A806  0044E3D4  0042A806  0041F4BD  005DBF56  0044E3D4
0044E32A  0042A806  0044F1AF  0044CE31  0044F105  0044E32A
0042A806  0044CE31  0044F105  0043DB7A  0044E49E  0044EE36
0044EE59  0042A806  0044E3D4  0042A806  005D668B  005D66AF
0044E32A  0042A806  0044F1AF  0044CE31  0044F105  0044E49E
Overquoting is evil! ๐Ÿ‘Ž
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6450
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: Non-rendering of icons on large toolbars

Post by *Horst.Epp »

I don't belive that anyone can use 500 icons at once in a useful way.
So we can just ignore this error :)
Windows 11 Home x64 Version 23H2 (OS Build 22631.3374)
TC 11.03 x64 / x86
Everything 1.5.0.1371a (x64), Everything Toolbar 1.3.2, Listary Pro 6.3.0.69
QAP 11.6.3.2 x64
User avatar
white
Power Member
Power Member
Posts: 4594
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Non-rendering of icons on large toolbars

Post by *white »

2Fla$her
Perhaps you should check the system event log for errors like heap allocation errors.
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Non-rendering of icons on large toolbars

Post by *Fla$her »

2Horst.Epp
Don't believe? Are you saying that I have nothing else to do, how to identify bugs in non-working conditions? So believe me. I have several such panels for the test assembly, which I often use.

2white
The error itself is a trifle compared to the problem of rendering icons.
Overquoting is evil! ๐Ÿ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Non-rendering of icons on large toolbars

Post by *ghisler(Author) »

The maximum number of buttons in the button bar is currently limited to 500. You can't create larger bars via button bar configuration dialog. However, it looks like the loading of a manually edited .bar files with more than 500 buttons isn't prevented. I will add it.

Is 500 too small?
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Non-rendering of icons on large toolbars

Post by *Fla$her »

2ghisler(Author)
You're wrong. I add buttons in standard ways through the panel interface. I don't edit BAR files manually, I don't need it.
And don't make restrictions, please, otherwise you will break everything and I'll have to stay on the old version. :(
Make a better rendering, it will be more correct.

Unfortunately, 500 is not enough for me.
Overquoting is evil! ๐Ÿ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Non-rendering of icons on large toolbars

Post by *ghisler(Author) »

You're wrong. I add buttons in standard ways through the panel interface.
Configuration - Button bar doesn't support more than 500. But drag&drop still seems to support it, so I will enforce the limit there too.
Unfortunately, 500 is not enough for me.
I will increase it to 1000, it doesn't take much memory.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Non-rendering of icons on large toolbars

Post by *Fla$her »

ghisler(Author) wrote: โ†‘2022-06-22, 10:06 UTCBut drag&drop still seems to support it
Not only. The addition also works by inserting codes from the clipboard. These are two ways that I use, since adding via the "Change button bar" takes a lot of time.
ghisler(Author) wrote: โ†‘2022-06-22, 10:06 UTCI will increase it to 1000, it doesn't take much memory.
Thank you very much! You can't imagine how important this is to me! :D
And this only applies the count limit? Or will it affect the rendering itself too?
Last edited by Fla$her on 2022-06-22, 10:48 UTC, edited 1 time in total.
Overquoting is evil! ๐Ÿ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Non-rendering of icons on large toolbars

Post by *ghisler(Author) »

There is still a hard limit of 64 kBytes per section in ini files (.bar files are .ini files). This limit is in the Windows functions for ini files, not in Total Commander.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Non-rendering of icons on large toolbars

Post by *Fla$her »

Well I do not know. BAR files in 100-120 KB are supported, buttons are output. Even 499 buttons will be more than 64 KB.
Wincmd.ini I generally have more than 200 KB. And nothing, everything works. :)
And how does this relate to rendering?
I added above the question:
Fla$her wrote: โ†‘2022-06-22, 10:33 UTCAnd this only applies the count limit? Or will it affect the rendering itself too?
Overquoting is evil! ๐Ÿ‘Ž
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Non-rendering of icons on large toolbars

Post by *petermad »

Wincmd.ini I generally have more than 200 KB
Yes, but not just in one section (a section is for example [Configuration] or [Lister])


.bar file only have one section : [Buttonbar]
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Non-rendering of icons on large toolbars

Post by *Fla$her »

2petermad
I agree. My inattention..
Overquoting is evil! ๐Ÿ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Non-rendering of icons on large toolbars

Post by *ghisler(Author) »

Well I do not know. BAR files in 100-120 KB are supported, buttons are output. Even 499 buttons will be more than 64 KB.
Strange, maybe Microsoft changed that in an update...
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Non-rendering of icons on large toolbars

Post by *Fla$her »

ghisler(Author) wrote: โ†‘2022-06-22, 14:54 UTCStrange, maybe Microsoft changed that in an update...
Buttons were displayed until any additional updates on Win XP SP2/SP3 and Win7 x32 SP1.
Overquoting is evil! ๐Ÿ‘Ž
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Non-rendering of icons on large toolbars

Post by *Fla$her »

2ghisler(Author)
:o Oh my God! My Total Commander (in RC3) has just started breathing. Icons when changing toolbars began to appear instantly, and not as before for a few seconds. Wonderful! Many thanks! :D :D :D
How long I've been waiting for this...
Overquoting is evil! ๐Ÿ‘Ž
Post Reply