The dividers in duplicates' search results disappears on second open of search window

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
nice
Junior Member
Junior Member
Posts: 84
Joined: 2018-03-12, 23:58 UTC

The dividers in duplicates' search results disappears on second open of search window

Post by *nice »

The dividers in duplicates' search results disappears on second open of search window.

- search for duplicates.
- you get search results divided in groups of similar files.
- close search window.
- open search window.
- the list displays the same files, but without separators.

other: if you select "feed to listbox", the search window results is empty.

2: feed duplicates to panel, change columns view, the separators disappears, and sorting is lost
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: The dividers in duplicates' search results disappears on second open of search window

Post by *petermad »

Both findings confirmed.

You can change the search result to Full, Brief or Comments view without loosing the lines, but not if you change to Thumbnail view or Costum view.

If you change the Sort order the lines will also dissapear
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: The dividers in duplicates' search results disappears on second open of search window

Post by *ghisler(Author) »

I can also confirm both findings, however:
1. I'm reluctant to change this: After the user went to a file, he can delete files at will, so the results are no longer up to date. This is usually not a problem, but when you then use "feed to listbox", you may use one of the group delete functions and delete all files of a group because you don't remember that you already deleted some others. You can use separate search if you need this, but be aware of the above described risk.

2. There is no way to keep the lines in thumbnails view, but maybe I can keep them in custom columns view.
Author of Total Commander
https://www.ghisler.com
nice
Junior Member
Junior Member
Posts: 84
Joined: 2018-03-12, 23:58 UTC

Re: The dividers in duplicates' search results disappears on second open of search window

Post by *nice »

ghisler(Author) wrote:After the user went to a file, he can delete files at will, so the results are no longer up to date. This is usually not a problem, but when you then use "feed to listbox", you may use one of the group delete functions and delete all files of a group because you don't remember that you already deleted some others.
But what if you are looking for regular files, not a duplicates? Then there would be no groups, and no danger of deleting an existing one.
You can delete file in one panel, and results in another panel will be no longer up to date too.

Sometimes it' s needed to navigate to a file in a folder from the search results.
You can't feed results to one panel, then open previous search, and go to file in another panel, because previous search results will be cleared.

There is functionality of multiple previous search results, but all previous searches except last will be cleared on window close. Why? Because they are no longer up to date too?

When you go to previous search results in search window with arrows < >, it shows previous results, but doesn't show previous search string.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: The dividers in duplicates' search results disappears on second open of search window

Post by *ghisler(Author) »

But what if you are looking for regular files, not a duplicates?
You can't open the special group selection dialog with NUM+ or Mark - Select group when in normal "Feed to listbox" mode, only when in duplicate mode. This dialog has an option to keep one file for each group, which would no longer work when the user has deleted some files manually.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: The dividers in duplicates' search results disappears on second open of search window

Post by *ghisler(Author) »

I have changed request 2 in TC 10.52 release candidate 1 and later, please check it! So when you switch to a custom columns view now after duplicate file finder - feed to listbox, the sort order will remain unchanged and the separator lines will be kept.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: The dividers in duplicates' search results disappears on second open of search window

Post by *Usher »

2ghisler(Author)
Feed to listbox with custom columns works for me, many thanks.
Andrzej P. Wozniak
Polish subforum moderator
nice
Junior Member
Junior Member
Posts: 84
Joined: 2018-03-12, 23:58 UTC

Re: The dividers in duplicates' search results disappears on second open of search window

Post by *nice »

Did search, changed Sort Order, and the lines are lost!
nice
Junior Member
Junior Member
Posts: 84
Joined: 2018-03-12, 23:58 UTC

Re: The dividers in duplicates' search results disappears on second open of search window

Post by *nice »

ghisler(Author) wrote: 2022-10-12, 07:35 UTC switch to a custom columns view now after duplicate file finder - feed to listbox, the sort order will remain unchanged
what does this mean?
what about default columns but sort order changed?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: The dividers in duplicates' search results disappears on second open of search window

Post by *ghisler(Author) »

Did search, changed Sort Order, and the lines are lost!
This happens because when you change the sort order, files from different result groups will get mixed up together.
what does this mean?
When you just switch to a different view but do NOT change the sort order, the result groups remain together, so the separator lines can be kept.
Author of Total Commander
https://www.ghisler.com
nice
Junior Member
Junior Member
Posts: 84
Joined: 2018-03-12, 23:58 UTC

Re: The dividers in duplicates' search results disappears on second open of search window

Post by *nice »

This happens because when you change the sort order, files from different result groups will get mixed up together.
This can be improved.
If "same size" or "same name" is checked, when sorting by this field, groups can be preserved.
If not, sort inside groups by selected field, and then sort groups by first item by same field.
Is the default "unsorted" sort order better than nothing?
nice
Junior Member
Junior Member
Posts: 84
Joined: 2018-03-12, 23:58 UTC

Re: The dividers in duplicates' search results disappears on second open of search window

Post by *nice »

Duplicate search on second open of search window (not feed to listbox):
After the user went to a file, he can delete files at will, so the results are no longer up to date.
So not keep the separators.

Regular search:
After the user went to a file, he can delete files at will, so the results are no longer up to date.
So user can still fed to listbox without knowledge that some files have been deleted.
You can't open the special group selection dialog with NUM+ or Mark - Select group when in normal "Feed to listbox" mode, only when in duplicate mode. This dialog has an option to keep one file for each group, which would no longer work when the user has deleted some files manually.
So in regular search I should not have a knowledge that files have been deleted?

Duplicate search when not closing window:
- he can switch to another app, delete files, and the results will be still "up to date" (but actually not) in opened search window, and then
- feed to listbox and then
- you don't remember that you already deleted some others
- and then ?

Who cares about a user's behavior when it's up to him how to do it?
Post Reply