[TC10.52rc1] Wrong virtual folder selection in separate tree

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

User avatar
white
Power Member
Power Member
Posts: 4595
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *white »

Preparations:
  • Enable separate tree(s)
  • Go to virtual folder "This PC"
  • Restart TC
  • Expand "This PC" in separate tree
Then in the file panel in the folder "This PC":
  1. Select a virtual folder using the keyboard
  2. Press Enter to enter the folder (often the correct folder is selected/marked in the separate tree)
  3. Press Enter (on "..") to return to the "This PC" folder
  4. Press Enter to enter the same virtual folder again (the Desktop folder is selected in the separate tree)
  5. Press Enter (on "..") to return to the "This PC" folder
  6. Select another virtual folder and try again (go to Step 2)
Video: Animated gif
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *Usher »

Did you keep mouse cursor outside of TC window?
Andrzej P. Wozniak
Polish subforum moderator
User avatar
white
Power Member
Power Member
Posts: 4595
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *white »

Usher wrote: 2022-10-06, 12:36 UTC Did you keep mouse cursor outside of TC window?
Just tried it, in or out makes no difference.
User avatar
petermad
Power Member
Power Member
Posts: 14741
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *petermad »

It seem to me that it is only the first time when you press enter on a virtual folder (Music, Videos) in the file panel showing This PC, that the correct folder is highlighted in the tree

If I go back and into the virtual folder a second time it is the overall Desktop entry in the top of the file tree that is highlighted.

It is the same in both the left and the right separate tree - and also in the filepanel tree (visible with InactiveFocus or InactiveFocusDark set).
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *Usher »

Races again? It takes more time when you open virtual folder for the first time - and during that time the tree in TC is unstable. For large virtual folders (collecting files from multiple source directories) you can only guess which folder will be selected finally after line cursor stabilizing.
Then the data are cached and subsequent folder openings are faster, without visible delay for unstable state.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
petermad
Power Member
Power Member
Posts: 14741
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *petermad »

Usher wrote: 2022-10-06, 23:10 UTC Races again? It takes more time when you open virtual folder for the first time - and during that time the tree in TC is unstable. For large virtual folders (collecting files from multiple source directories) you can only guess which folder will be selected finally after line cursor stabilizing.
Then the data are cached and subsequent folder openings are faster, without visible delay for unstable state.
That would explain why the bug was shown the first time you open the virtual folder - but it is the opposite - it is the subsequet times that the wrong folder is selected in the tree.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *Usher »

To be honest, I didn't test it on my own, so I really could write inverted description. Loading from cache is too fast...
Whatever it is (too fast, too slow, or maybe both?), all reports for tree view show that there is a general problem with line cursor stabilization there.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *ghisler(Author) »

Unfortunately there is nothing I can do - this happens when the internal structure of the folder (the item id list) changes. Then the two in the tree and in the file panel aren't the same, so TC cannot highlight the item in the tree.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *AntonyD »

so TC cannot highlight the item in the tree
thus TC can wait a next changes - when these two will be identical.
This explanation looks like TC just tries to set highlighting too fast than it could be appropriate.
So just make a pause and o a next iteration of changes - set highlighting.
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *ghisler(Author) »

I think I found a solution: calling the function: calling SHGetNameFromIDList with parameter SIGDN_DESKTOPABSOLUTEPARSING seems to return a consistent path name even when the id list itself is different.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14741
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *petermad »

history.txt wrote:10.10.22 Fixed: Entering a virtual folder in one of the file list didn't always show the right one in the tree (32/64)
Fix confirmed in TC 10.52rc2 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4595
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *white »

Enter or double-click on the .. entry work correctly, but using the .. button or pressing Ctrl+PgUp do not.
User avatar
petermad
Power Member
Power Member
Posts: 14741
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *petermad »

It seems to depend on the virtual folder I try. It works with subfolders to virtual folders, but not for the virtual folders directly under the Desktop level.

Examples where the [..] button works:
\\Libraries\Pictures\
\\This PC\Pictures
\\This PC\Desktop
\\This PC\Downloads\
\\This PC\Documents\
\\Control Panel\User Accounts\
\\Control Panel\All Elements in Control Panel\
\\Network\Media Audio 2\

Examples where the [..] button does not work:
\\Libraries\
\\This PC\
\\Control Panel
\\Network
\\Recycle Bin
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *ghisler(Author) »

Thanks, that still seems to call an older function.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4595
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *white »

BTW, go to root in a virtual folder brings you to the network virtual folder. Is it possible to change that to the root Desktop folder?
Post Reply