EdgeViewer - Modern HTML viewer plugin

Discuss and announce Total Commander plugins, addons and other useful tools here, both their usage and their development.

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3278
Joined: 2003-05-06, 11:46 UTC

Re: Modern HTML viewer plugin

Post by *Sir_SiLvA »

AntonyD wrote: 2022-11-06, 10:52 UTC Are you sure?
Ups, that 0 in the adress should be a B. fixed my post.
Hoecker sie sind raus!
User avatar
rg_software
Member
Member
Posts: 113
Joined: 2009-08-06, 12:59 UTC
Location: Aizu-Wakamatsu, Japan

Re: Modern HTML viewer plugin

Post by *rg_software »

Oh, you don't have to do it the hard way. I was planning to encorporate various stuff in the next update, BUT the 32/64 combined package is already there, you simply have to recompile the latest source from Github.

Even better, I can do that :)
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6450
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: Modern HTML viewer plugin

Post by *Horst.Epp »

rg_software wrote: 2022-11-07, 12:50 UTC Oh, you don't have to do it the hard way. I was planning to encorporate various stuff in the next update, BUT the 32/64 combined package is already there, you simply have to recompile the latest source from Github.

Even better, I can do that :)
This combined version crashes in the 32bit TC.
---------------------------
error
---------------------------
Crash in plugin EdgeViewer.wlx:ListLoadW:

Access violation at address 66266870. Read of address 66266870
---------------------------
OK Cancel
---------------------------
Windows 11 Home x64 Version 23H2 (OS Build 22631.3374)
TC 11.03 x64 / x86
Everything 1.5.0.1371a (x64), Everything Toolbar 1.3.2, Listary Pro 6.3.0.69
QAP 11.6.3.2 x64
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Modern HTML viewer plugin

Post by *AntonyD »

2rg_software
Try to open MD file and .... dump. Cant' create WebView2. Code 203
Doesn't matter to me - why can't we continue further work, but generate a dump?
Falling down and dragging Total with itself?

IMHO IF - the real reason of this fall - is that on my system there is no INSTALLED edge - for such
"portable" cases you can imho easily provide version of your plugin which will have ALL essential dlls in some special subfolder
among all other installed staff. Thus if plugin could not detect installed version of WebView2 - it can use portable version...

And why DETECT-string is so strange???
EXT=""|EXT=""|EXT=""
#146217 personal license
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6450
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: Modern HTML viewer plugin

Post by *Horst.Epp »

AntonyD wrote: 2022-11-07, 13:20 UTC 2rg_software
Try to open MD file and .... dump. Cant' create WebView2. Code 203
Doesn't matter to me - why can't we continue further work, but generate a dump?
Falling down and dragging Total with itself?

IMHO IF - the real reason of this fall - is that on my system there is no INSTALLED edge - for such
"portable" cases you can imho easily provide version of your plugin which will have ALL essential dlls in some special subfolder
among all other installed staff. Thus if plugin could not detect installed version of WebView2 - it can use portable version...

And why DETECT-string is so strange???
EXT=""|EXT=""|EXT=""
Tested with x64 TC
No problems here viewing .md files.
The Detect string is a normal TC Detect string definition.
Windows 11 Home x64 Version 23H2 (OS Build 22631.3374)
TC 11.03 x64 / x86
Everything 1.5.0.1371a (x64), Everything Toolbar 1.3.2, Listary Pro 6.3.0.69
QAP 11.6.3.2 x64
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Modern HTML viewer plugin

Post by *AntonyD »

The Detect string is a normal TC Detect string definition.
Normal? 3 times identical empty string????

"No problems here viewing .md files."
pls, pay attention on the 1 moment - do you have installed Edge browser?
I dont' have ;)
#146217 personal license
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6450
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: Modern HTML viewer plugin

Post by *Horst.Epp »

AntonyD wrote: 2022-11-07, 13:49 UTC
The Detect string is a normal TC Detect string definition.
Normal? 3 times identical empty string????

"No problems here viewing .md files."
pls, pay attention on the 1 moment - do you have installed Edge browser?
I dont' have ;)
For me there are no emtpy detect strings, it looks like this
5=%COMMANDER_PATH%\PLUGINS\EdgeViewer\EdgeViewer.wlx
5_detect="EXT="HTM"|EXT="HTML"|EXT="XML"|EXT="MD"|EXT="MARKDOWN"|EXT="ADOC"|EXT="ASCIIDOC""

Ok, I have MS Edge installed because for me its better than Google or Firefox.
For an viewer named EdgeViewer I guess most users will see this as a prerequisite :)
Windows 11 Home x64 Version 23H2 (OS Build 22631.3374)
TC 11.03 x64 / x86
Everything 1.5.0.1371a (x64), Everything Toolbar 1.3.2, Listary Pro 6.3.0.69
QAP 11.6.3.2 x64
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3278
Joined: 2003-05-06, 11:46 UTC

Re: Modern HTML viewer plugin

Post by *Sir_SiLvA »

Sir_SiLvA wrote: 2022-11-05, 19:28 UTC Windows 10 Version 22H2 (Build 19045.2130) (64-Bit)
Edge Version 107.0.1418.35 (Offizielles Build) (64-Bit)
Total Commander Version 10.52 (32-Bit)
HTMLView works fine while EdgeViewer.wlx crashes -> https://imgur.com/a/NZtDuSK
even with this new Version the 32bit one still crashes.
64bit version seems to do fine BUT
PLEASE PLEASE enabled all the default lister keyboard shortcuts....
Second: why EBWebView is still not in the Plugin-Folder but TCs? thats the worst place to put files....
(same goes for edgeviewer.ini btw)
Hoecker sie sind raus!
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Modern HTML viewer plugin

Post by *petermad »

I tried to install the 32bit version in 32bit TC 10.52 and get the error message:"This is not a valid plugin"

I don't get such a message when installing the 64bit version in TC (x64) 10.52.

I tried to put the wincmd.ini parameters:

Code: Select all

37=%COMMANDER_PATH%\PLUGINS\wlx\EdgeViewer\EdgeViewer.wlx
37_detect="EXT="HTM"|EXT="HTML"|EXT="XML"|EXT="MD"|EXT="MARKDOWN"|EXT="ADOC"|EXT="ASCIIDOC""
from the 64bit version in my wincmd.ini file for the 32bit version - but then I get this error message when I try to view an html file:
Crash in plugin Edgeviewer.wlxListLoadW:
Access violation at address 6D766870. Read of address 6D766870
I have tried installing both wlx-edge-viewer-v1.0.0-32bit.zip and edgeviewer-Release-20221107.zip - same problem.

Tested with Windows 10 22H2 build 19045.2130
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
rg_software
Member
Member
Posts: 113
Joined: 2009-08-06, 12:59 UTC
Location: Aizu-Wakamatsu, Japan

Re: Modern HTML viewer plugin

Post by *rg_software »

Hi all,

- I will do my best to investigate the issues mentioned here when I have the time (hopefully will do something within the next 1-2 weeks -- I am a bit busy, sorry).
- Yes, I understand this common dissatisfaction with me using TC folder even though it is the right way to do according to the docs. I'll fix that.
- The situation is much harder to investigate with 32-bit OSes esp. without Edge. AFAIK you only need "Edge runtime" (linked at the Github page), not Edge itself. I don't have any 32 bit machines at hand, but at least I will try to add diagnostics and prevent crashes.

Will post any updates here, stay tuned.
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Modern HTML viewer plugin

Post by *petermad »

The situation is much harder to investigate with 32-bit OS
Just to make it clear: when I write here above that the 32bit version of the plugin crashes, then that is on Win 10 64bit in TC 32bit
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3278
Joined: 2003-05-06, 11:46 UTC

Re: Modern HTML viewer plugin

Post by *Sir_SiLvA »

petermad wrote: 2022-11-08, 00:54 UTC Just to make it clear: when I write here above that the 32bit version of the plugin crashes, then that is on Win 10 64bit in TC 32bit
Same case for me.
Hoecker sie sind raus!
User avatar
rg_software
Member
Member
Posts: 113
Joined: 2009-08-06, 12:59 UTC
Location: Aizu-Wakamatsu, Japan

Re: Modern HTML viewer plugin

Post by *rg_software »

Just to make it clear: when I write here above that the 32bit version of the plugin crashes, then that is on Win 10 64bit in TC 32bit
OK, got it. Then it is going to be easier for me of course.
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3278
Joined: 2003-05-06, 11:46 UTC

Re: Modern HTML viewer plugin

Post by *Sir_SiLvA »

32bit Version crashes on Windows 11 for me also.
Hoecker sie sind raus!
User avatar
rg_software
Member
Member
Posts: 113
Joined: 2009-08-06, 12:59 UTC
Location: Aizu-Wakamatsu, Japan

Re: Modern HTML viewer plugin

Post by *rg_software »

Ah, BTW, I'd appreciate a good advice on the following matter.
Does anyone feel that a detection string is necessary?

The problem is that one of the users here mentioned EdgeViewer can be used to preview images in a folder. To do that I need to be able to view folders. To do that, I have to remove a detection string completely, as far as I understand.
Post Reply