GIANT history menu! it covered half the screen for me!

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
jbcb
Junior Member
Junior Member
Posts: 31
Joined: 2013-08-30, 06:43 UTC

Re: GIANT history menu! it covered half the screen for me!

Post by *jbcb »

ghisler(Author) wrote: 2023-05-23, 22:37 UTC Again, what would you use as the maximum width? Why have a big screen and then not use it?
Too long lines are hard to read (not my invention, but a known fact). On large monitors, text appears outside the user's ideal field of view. If I switch TC to full screen view, it mostly just displays blank space and I would wring my head when using it. :) That's why my TC is about 1/3 the width of the screen.
Last edited by jbcb on 2023-05-24, 09:58 UTC, edited 1 time in total.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: GIANT history menu! it covered half the screen for me!

Post by *petermad »

I would suggest: HistoryWidthLimit (to match with BriefViewWidthLimit and DirTabLimit)

Should the value be in characters or pixels?
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6492
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: GIANT history menu! it covered half the screen for me!

Post by *Horst.Epp »

petermad wrote: 2023-05-24, 09:55 UTC I would suggest: HistoryWidthLimit (to match with BriefViewWidthLimit and DirTabLimit)

Should the value be in characters or pixels?
I suggest characters.
For me pixels is for developers and not for normal usage.
Windows 11 Home x64 Version 23H2 (OS Build 22631.3527)
TC 11.03 x64 / x86
Everything 1.5.0.1373a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.73
QAP 11.6.3.2 x64
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: GIANT history menu! it covered half the screen for me!

Post by *petermad »

Maybe there could even be space for it in the History config - like here (with other additions from here: viewtopic.php?p=431843#p431843 included):

https://tcmd.madsenworld.dk/historymockup1.png
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
KozakMak
Senior Member
Senior Member
Posts: 370
Joined: 2021-05-24, 12:39 UTC
Location: UA

Re: GIANT history menu! it covered half the screen for me!

Post by *KozakMak »

OS: Win10 | TC: latest x64
TW
Senior Member
Senior Member
Posts: 383
Joined: 2005-01-19, 13:35 UTC

Re: GIANT history menu! it covered half the screen for me!

Post by *TW »

interesting. what's exactly the problem here? it gets displayed only temporarily when the "button" is pressed.
i think it's good to see as much as possible here...

different people, different needs i guess. :)
licenced and happy TC user since 1994 (#11xx)
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: GIANT history menu! it covered half the screen for me!

Post by *AntonyD »

2petermad
super fantastic job! +++++++++
#146217 personal license
User avatar
Hacker
Moderator
Moderator
Posts: 13065
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: GIANT history menu! it covered half the screen for me!

Post by *Hacker »

Horst.Epp,
I suggest characters.
For me pixels is for developers and not for normal usage.
That does not really control the width then, but the amount of data shown, as iiiiiiiiiiii is less wide than wwwwwwwwwwww.
Perhaps % of panel width? I.e. "how much of the panel I am willing to cover with the directory history".

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: GIANT history menu! it covered half the screen for me!

Post by *ghisler(Author) »

Unfortunately it's not that simple: I'm currently limiting the width to half of the screen, then call DrawText with option "DT_PATH_ELLIPSIS". This causes Windows to shorten the path so the most relevant parts at the start and end stay intact. I can't just shorten the path to, say, 100 characters by cutting the end when the users sets a limit of 100 characters. Also I can't simply translate the 100 characters to a screen width because 100 "W" take much more space than 100 "i" characters.
Author of Total Commander
https://www.ghisler.com
User avatar
Gral
Power Member
Power Member
Posts: 1467
Joined: 2005-01-26, 15:12 UTC

Re: GIANT history menu! it covered half the screen for me!

Post by *Gral »

With such a reduced width it can sometimes be impossible to distinguish between different paths.
TW wrote: 2023-05-24, 11:25 UTC interesting. what's exactly the problem here? it gets displayed only temporarily when the "button" is pressed.
i think it's good to see as much as possible here...

different people, different needs i guess. :)
That's exactly what I think
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: GIANT history menu! it covered half the screen for me!

Post by *petermad »

2ghisler(Author)
I'm currently limiting the width to half of the screen
If you can do that, you can also limit it to a user defined amount of pixels - it is up to the user to figure out what his need is.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: GIANT history menu! it covered half the screen for me!

Post by *ghisler(Author) »

Yes, I can limit it to a width in pixels, but this is problematic for users with multiple screens (e.g. laptop with dock).
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: GIANT history menu! it covered half the screen for me!

Post by *petermad »

but this is problematic for users with multiple screens (e.g. laptop with dock).
That is their problem if they want the size limited - default should still be as it is now with half the screen as limit.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: GIANT history menu! it covered half the screen for me!

Post by *ghisler(Author) »

Maybe use some other measure like x characters of average width? This way it would be scaled with the font chosen by the user.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: GIANT history menu! it covered half the screen for me!

Post by *AntonyD »

Looks promising... imho...
#146217 personal license
Post Reply