[11.00b] New commands capitalization (followup)

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

[11.00b] New commands capitalization (followup)

Post by *Flint »

According to the topic New commands capitalization, the case in the command names should have been fixed. However, cm_Righttabslist still is not capitalized properly. (The other 3 commands of the same function are OK.)

While at it, I took a look at other commands and noticed a few more omissions:
cm_CopySamepanel
cm_CopyOtherpanel
(the word "Panel")
cm_SwitchDarkmode
cm_EnableDarkmode
cm_DisableDarkmode
(the word "Mode")
cm_SrcQuickview
cm_SrcHideQuickview
cm_LeftQuickview
cm_LeftHideQuickview
cm_RightQuickview
cm_RightHideQuickview
(the word "view"; at first I thought "quickview" was treated as a single combined word, but cm_SeparateQuickView and cm_UpdateQuickView have "View" capitalized)

Checked in TC 11.00b7.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48097
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *ghisler(Author) »

According to the topic New commands capitalization, the case in the command names should have been fixed.
No, I only changed the names reported. I will also change the ones you reported now.
I also found a few more:
cm_VisButtonbar->cm_VisButtonBar
cm_VisButtonbar2->cm_VisButtonBar
cm_SearchForInCurdir->cm_SearchForInCurDir
cm_VisStatusbar->cm_VisStatusBar
cm_RighttabsList->cm_RightTabsList

I will not change these:
cm_CRCcreate
cm_CRCcheck
cm_CDtree
because I would prefer to keep the abbreviations CRC and CD all uppercase.

What about cm_DirectoryHotlist? Should it be cm_DirectoryHotList?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14815
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *petermad »

2ghisler(Author)
I googled hotlist and found it as a single word in several dictionaries
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *Flint »

ghisler(Author) wrote: 2023-06-19, 10:13 UTC I will not change these:
cm_CRCcreate
cm_CRCcheck
cm_CDtree
because I would prefer to keep the abbreviations CRC and CD all uppercase.
Agree. I also noticed these, but decided, it's better to leave them as is (or change the abbreviations to capitalized form, like cm_CrcCheck, but I don't think that would be better).
What about cm_DirectoryHotlist? Should it be cm_DirectoryHotList?
Hm… In ABBYY Lingvo's English dictionaries (including the Oxford dictionary) "hotlist" is provided as a single word, and "hot list" as an optional, referring back to "hotlist". So I agree with petermad, it's probably better to leave it "Hotlist".
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
petermad
Power Member
Power Member
Posts: 14815
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *petermad »

I dont know about this:
cm_VisXPThemeBackground
maybe it should be cm_VisXPthemeBackground - if the rule is not to use a capital letter after an all uppercase abbreviation (like cm_CRCcreate, cm_CRCcheck, cm_CDtree, cm_NTinstallDriver and cm_NTremoveDriver)


And maybe finally remove this
cm_EditPersmissionInfo=2200;Typo...
it was introduced in February 10th 2000 - hence a more than 23 year old typo - I think it can be removed by now.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48097
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *ghisler(Author) »

maybe it should be cm_VisXPthemeBackground
Agreed.
And maybe finally remove this
OK, I will remove it.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48097
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *ghisler(Author) »

Please let me know if I missed any of the above changes, or if there are others I should change.
Author of Total Commander
https://www.ghisler.com
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3300
Joined: 2003-05-06, 11:46 UTC

Re: [11.00b] New commands capitalization (followup)

Post by *Sir_SiLvA »

Well tbh if we finally start fixing totalcmd.inc I would prefer cm_CheckForUpdates=650;Check for new versions between
cm_VisitHomepage and cm_About under [________________Help________________]=0

Code: Select all

cm_VisitHomepage=640;Visit https://www.ghisler.com/
cm_CheckForUpdates=650;Check for new versions
cm_About=690;Help/About Total Commander
and not in the misc section, because in every menu-file that comes with TC cm_CheckForUpdates can be found under the menu item Help.
Hoecker sie sind raus!
User avatar
petermad
Power Member
Power Member
Posts: 14815
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *petermad »

2Sir_SiLvA
Support++
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14815
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *petermad »

ghisler(Author) wrote: 2023-06-20, 10:32 UTC
maybe it should be cm_VisXPthemeBackground
Agreed.
And maybe finally remove this
OK, I will remove it.
Confirmed changed in TC 11.00b8 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48097
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *ghisler(Author) »

OK, I will move the command
cm_CheckForUpdates
to the help section.

Any other suggestions?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14815
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *petermad »

Any other suggestions?
Not for totalcmd.inc, but for wcmd_eng.inc - I know it is sent to the translators, but perhaps do the suggested changes now, so they won't be forgotten:

2047="Left: branch view, only selected"
to:
2047="Left: Branch view, only selected"

2035="Right: branch view"
to:
2035="Right: Branch view"

2048="Right: branch view, only selected"
to:
2048="Right: Branch view, only selected"

All other descriptions with "Left: " or "Right: " starts with a capital letter
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48097
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *ghisler(Author) »

Totalcmd.inc is already capitalized like this.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14815
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.00b] New commands capitalization (followup)

Post by *petermad »

Totalcmd.inc is already capitalized like this.
I was talking about wcmd_eng.inc
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3300
Joined: 2003-05-06, 11:46 UTC

Re: [11.00b] New commands capitalization (followup)

Post by *Sir_SiLvA »

Now that we have fixed totalcmd.inc we have to talk about the window in TC that shows the commands it :!:

The window for cm_CommandBrowser (2924) needs to be updated
(perhaps make the width for the Command customizable?)
as the following commands

[enter cm_CommandBrowser in TCs cmdline and enter the following numbers into the filterbox]

3022 (cm_AddPathAndFileNameToCmdline)
5511 (cm_RightSwitchToThisCustomView)
-19 (OPENLANGUAGEFILE <WCMD_xyz.LNG>)
-26 (ZIPFROMLIST <archive name> <filelist>)

are longer then the predifinied width for the command and thus are displayed as

cm_AddPathAndFileNameToCmdlir
cm_RightSwitchToThisCustomView (the last letter is only partial visible)
OPENLANGUAGEFILE <WCMD_xyz.|
ZIPFROMLIST <archive name> <filelis
Hoecker sie sind raus!
Post Reply