Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

Ziabrev
Junior Member
Junior Member
Posts: 29
Joined: 2022-05-12, 18:03 UTC

Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *Ziabrev »

In the cm_EditNewFile command dialog box, swap the "Tree" and "OK" buttons according to the standard - screen
Last edited by Ziabrev on 2023-06-28, 09:16 UTC, edited 3 times in total.
User avatar
AntonyD
Power Member
Power Member
Posts: 1250
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Changing the cm_EditNewFile command dialog box

Post by *AntonyD »

It also makes sense to add the same "Tree" button to the F7 dialog:
https://ibb.co/C6MJwMQ
The position can be either to the left of the OK button or to the right - as in the picture above.
To the Right - is more preferable of course.
Last edited by AntonyD on 2023-06-30, 11:26 UTC, edited 2 times in total.
#146217 personal license
Ziabrev
Junior Member
Junior Member
Posts: 29
Joined: 2022-05-12, 18:03 UTC

Re: Changing the cm_EditNewFile command dialog box

Post by *Ziabrev »

I support adding the "Tree" button to the F7 dialog box to the right of the "OK" button
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48118
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *ghisler(Author) »

I prefer keeping the tree button on the left, because it is wider and would look strange like that between the two buttons.

Moderator message

Moved to suggestions
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4632
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *white »

ghisler(Author) wrote: 2023-06-28, 10:36 UTC I prefer keeping the tree button on the left, because it is wider and would look strange like that between the two buttons.
Sure. Please change these dialogs: Screenshot

Moderator message from: white » 2023-06-28, 11:27 UTC

Moved to Bugs forum.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48118
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *ghisler(Author) »

There the tree button isn't wider...

Moved back to suggestions. It's not a bug.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4632
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *white »

ghisler(Author) wrote: 2023-06-28, 13:03 UTC There the tree button isn't wider...
Then make it wider there as well, so you can put it in front. That seems to be what you want.

BTW, why doesn't the + button have a tab stop?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48118
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *ghisler(Author) »

I just checked, cm_EditNewFile doesn't even have a tree button(?).

The + button is a "speed button" which cannot be focused. The idea was that tab still goes to OK after adding this button.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14826
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *petermad »

I just checked, cm_EditNewFile doesn't even have a tree button(
Hmm, it looks very much like it does here: https://tcmd.madsenworld.dk/editnewfiletreebutton.png

But the cm_MkDir dialog does not have a tree button.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4632
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *white »

ghisler(Author) wrote: 2023-06-28, 14:37 UTC I just checked, cm_EditNewFile doesn't even have a tree button(?).
Yes, it does.
ghisler(Author) wrote: 2023-06-28, 14:37 UTC The + button is a "speed button" which cannot be focused. The idea was that tab still goes to OK after adding this button.
It goes to the Tree button now..

"The idea was that tab still goes to OK after adding this button" makes no sense to me. Tabbing is meant to navigate through all controls, hotkeys are meant to directly activate a control.
User avatar
AntonyD
Power Member
Power Member
Posts: 1250
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *AntonyD »

2ghisler(Author)
There the tree button isn't wider...
And what tool did you use when you claim the fact of the difference in size?
Moreover, as I understand it, there is a very significant difference (isn't it?), since in the above two dialogs
you refuse to place the button where it ALREADY exists in other shown dialogs - and for a long time - after the OK button ...
How accurately are these "Tree" buttons NOT wider - that they can't be made by analogy like 'the first button' on a form?
exactly 1 pixel, or maybe 5px/10/12/...?

P.S.
I venture to clarify that my drawing is a sketch of what the dialog COULD look like!
This is not the real state of affairs just in case;)
Last edited by AntonyD on 2023-06-29, 12:09 UTC, edited 1 time in total.
#146217 personal license
Ziabrev
Junior Member
Junior Member
Posts: 29
Joined: 2022-05-12, 18:03 UTC

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *Ziabrev »

Button "OK" should be located as in the system dialogs, all else is wrong.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48118
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *ghisler(Author) »

Ah, I get it - the tree button gets hidden when you start the name with < to use placeholders. The space is then needed to show the name preview.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4632
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *white »

ghisler(Author) wrote: 2023-06-29, 09:04 UTC Ah, I get it - the tree button gets hidden when you start the name with < to use placeholders. The space is then needed to show the name preview.
This seems like a weird solution to me. Wouldn't it be better to make room above the buttons?
BTW, why is there so much room above the input field?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48118
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Changing the buttons in the cm_EditNewFile and cm_MkDir dialog boxes

Post by *ghisler(Author) »

This seems like a weird solution to me. Wouldn't it be better to make room above the buttons?
It needs up to two lines when using a counter. And the tree button doesn't work when there are placeholders, so why not?
BTW, why is there so much room above the input field?
It's a standard dialog also used in other functions, where the text can get longer.
Author of Total Commander
https://www.ghisler.com
Post Reply