[Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

[Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *JOUBE »

[Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work. Instead, it ends with a strange error message and a file created afterwards with the appropriate name and size zero. Annoying when new functions are implemented and the existing functions are affected. Please release Tc11b10a right now.

Joube
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *white »

Not confirmed. Please add more details. What error message? What file did you try to create?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *ghisler(Author) »

Not confirmed. What are your editor settings in Configuration - Options Edit/View?
Author of Total Commander
https://www.ghisler.com
User avatar
Hacker
Moderator
Moderator
Posts: 13067
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *Hacker »

JOUBE,
Works completely fine here.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *JOUBE »

Like every day: 20 and more times:

Shift+F4 c.txt Enter (or x.txt, b.txt, y.cmd, .... I rename the file later in the process...)

This line worked 5 (or many more) years now:
windcmd.ini

Code: Select all

Editor=""C:\Program Files (x86)\Npp\notepad++.exe""

I have change it now manually to:
windcmd.ini

Code: Select all

Editor="C:\Program Files (x86)\Npp\notepad++.exe"
and it worked now.

But it is a real bug:
I have insert the Editor in configuration -> Editor with brakets. And this should be okay (I have generated it and copied from the Tc commandline via Ctrl+Shift+Enter) because of spaces in pathname. Result are the "" .... "" in the ini, which are (started with Tc11B10) problematic *).

Please fix it.

Joube

*) And, I think, not only at my wincmd.ini but thousands others also (In this case I am "the normal one", I think ;-) ).
Last edited by JOUBE on 2023-07-06, 09:35 UTC, edited 5 times in total.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *ghisler(Author) »

I changed a lot when calling Shift+F4 to support all the new functions with cm_Edit parameters. One change was using ShellExecuteEx instead of the old WinExec, because the old function doesn't support elevation (run as admin).

I will check why it doesn't work with double quotes, it should work fine.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *AntonyD »

2JOUBE
what will be if you use this line:

Code: Select all

Editor=""C:\Program Files (x86)\Npp\notepad++.exe" "%1""
?
#146217 personal license
fgsdfg
Junior Member
Junior Member
Posts: 5
Joined: 2018-12-20, 02:20 UTC

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *fgsdfg »

Also does not working in TC 11 b1ta 10.

If I replace just totalcmd.exe by beta 9 version all is OK.

I tried old worked up to beta 9 variant:
"%COMMANDER_PATH%\Programs\Notepad++x86Portable\notepad++.exe" "%1"
""%COMMANDER_PATH%\Programs\Notepad++x86Portable\notepad++.exe" "%1""

Both are working in beta 9, no one working in beta 10.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *ghisler(Author) »

I can confirm that the editor name with double quotes is parsed incorrectly. I will fix it in the next beta. Sorry for the troubles.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *JOUBE »

Double double quotes and Tc inis: a topic in itself. Also, for example, in the [DirMenu] section. That goes into the basics of Tc: Therefore don't change the basics, just keep it in mind.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *ghisler(Author) »

Double double quotes
That's due to how Windows handles ini files: If a value in an ini file is surrounded by double quotes, Windows removes them when reading the value, e.g.
value="1"
will return just 1.
Author of Total Commander
https://www.ghisler.com
Schultheis
Member
Member
Posts: 117
Joined: 2004-03-04, 14:56 UTC
Location: Germany

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *Schultheis »

I use Emacs as my editor. I have the same error, but it does not work with single quotes, too. My line in wincmd.ini is now
Editor="C:\Program Files\Emacs\emacs-28.2\bin\runemacs.exe" "%1"
Schultheis
Member
Member
Posts: 117
Joined: 2004-03-04, 14:56 UTC
Location: Germany

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *Schultheis »

With double quotes it does work with F4, with single quotes it doesn't even work with F4!
Schultheis
Member
Member
Posts: 117
Joined: 2004-03-04, 14:56 UTC
Location: Germany

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *Schultheis »

But it dows work without any quotes.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *ghisler(Author) »

Try without parameters, e.g. just
Editor=C:\Program Files\Emacs\emacs-28.2\bin\runemacs.exe
Author of Total Commander
https://www.ghisler.com
Post Reply