[TC11.00rc1] buttonbar navigation with keyboard not right

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC11.00rc1] buttonbar navigation with keyboard not right

Post by *petermad »

2ghisler(Author)
No, I meant that when the user wants to scroll to the end of the list so he can then open the overflow menu, he can now just hold down the down key until the cursor is there. That wouldn't work when looping. Users would have to use up in that case.
If the user keeps pressing the down key, that's on him - it is the users responsibility to stop at the wanted item, not for TC to guess the intention.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC11.00rc1] buttonbar navigation with keyboard not right

Post by *petermad »

histoty.txt wrote:14.07.23 Fixed: Vertical button bar, focus with Alt+Shift+F12: Couldn't navigate across separators with "cursor up" (32/64)
16.07.23 Fixed: Vertical button bar: Loop when using cursor up/down when reaching the first/last button like in the top bar with left/right (32/64)
16.07.23 Fixed: Vertical button bar: Fixed cursor navigation when using an overflow menu (Home/End, Enter and Esc on overflow menu) (32/64)
16.07.23 Fixed: Button bar: Pressing space on a focused button didn't open the context menu in 64-bit, or made a beep in 32-bit, need to handle it in the "key up" event (32/64)
17.07.23 Fixed: Vertical button bar: Cursor right/left now behaves like Cursor down/up, respectively (32/64)
17.07.23 Fixed: Space, Shift+F10 or context menu key on overflow button in the vertical button bar now opens the overflow menu (32/64)
17.07.23 Fixed: Shift+F10 didn't open the context menu in the vertical button bar (32/64)
19.07.23 Fixed: Tab/Shift+Tab didn't work in button bar to switch to next/previous button (64)
Confirm all of the above fixes in TC 11.00rc2 :-)

Ctrl+Tab also works correctly in the button bars.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC11.00rc1] buttonbar navigation with keyboard not right

Post by *white »

petermad wrote: 2023-07-19, 12:39 UTC Confirm all of the above fixes in TC 11.00rc2 :-)
Confirmed.
HISTORY.TXT wrote:17.07.23 Fixed: Space, Shift+F10 or context menu key on overflow button in the vertical button bar now opens the overflow menu (32/64)
Shouldn't this do a beep and do nothing? This creates an inconsistency. Suppose you have several subbars shown as menu on the vertical buttonbar and also usually an overflow menu, then pressing space opens the overflow menu but not the subbars. Isn't that confusing for users?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC11.00rc1] buttonbar navigation with keyboard not right

Post by *ghisler(Author) »

There is no context menu for the overflow menu because there is no button you could configure, so it's best to show just the overflow menu itself (it is also a context menu).
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC11.00rc1] buttonbar navigation with keyboard not right

Post by *white »

ghisler(Author) wrote: 2023-07-19, 13:27 UTC There is no context menu for the overflow menu because there is no button you could configure, so it's best to show just the overflow menu itself
I agree to disagree on that.
ghisler(Author) wrote: 2023-07-19, 13:27 UTC (it is also a context menu).
While technically true, I think that's a weird argument. If the overflow button were to have a context menu, I think it would have an option to configure the overflow menu. And it doesn't address the inconsistency. If people get used to opening the overflow menu by pressing space and then add a subbar that opens as menu, wouldn't they expect to be able to open the subbar by pressing space as well?
Post Reply