[TC 11.00rc1] Pressing space when button on a buttonbar has focus

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *white »

* Press Alt+Shift+F11
* Press Space
In 32-bit TC the context menu of the button opens, in 64-bit nothing happens.

BTW. My expectation is that space activates the button, like normally in a dialog when a button has focus.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *petermad »

In 32-bit TC the context menu of the button opens, in 64-bit nothing happens.
Confirmed.

BTW. My expectation is that space activates the button, like normally in a dialog when a button has focus.
If you by activate mean perform the same action as when clicking it I totally agree.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *white »

petermad wrote: 2023-07-15, 16:08 UTC If you by activate mean perform the same action as when clicking it I totally agree.
Yup, that's what I meant :)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *ghisler(Author) »

Actually the menu does get shown, but it gets immediately closed. You can see this by holding down the space bar.
The reason seems to be that pressing space in a 64-bit context menu closes it, while it does nothing in a 32-bit context menu. I don't know why this is happening, but the solution would be to show the menu when the space bar is being released.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *white »

2ghisler(Author)
So space is the new context menu key and no longer the activation key?
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *petermad »

So space is the new context menu key and no longer the activation key
I hope not! The context menu should be opened with Alt+Enter not Space.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *ghisler(Author) »

Alt+Enter isn't the context menu hotkey either! Shift+F10 or the dedicated context menu key is! And they both work in the button bar.
However, I prefer to keep space for the menu too in this special case. Use Enter to execute the command.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *petermad »

Alt+Enter isn't the context menu hotkey either! Shift+F10 or the dedicated context menu key is!
Correct - my bad.

And they both work in the button bar.
Shift+F10 does not work in the Vertical button bar - it puts focus on the Menu. The dedicated key works though.
Last edited by petermad on 2023-07-17, 10:03 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *ghisler(Author) »

Confirmed, Shift+F10 isn't being handled in the vertical bar so far because it didn't support keyboard navigation until recently.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *white »

ghisler(Author) wrote: 2023-07-17, 08:41 UTC However, I prefer to keep space for the menu too in this special case. Use Enter to execute the command.
In dialogs, when you use the keyboard to focus a control, you can activate it by pressing space. If you press Enter, the default button is activated unless the control that has focus is a button. Due to this behavior, I believe it would be more intuitive for keyboard users if Total Commander supports the use of space to activate a button on the buttonbar. This aligns with users' expectations and enhances the overall user experience.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *ghisler(Author) »

Sorry but I don't want to change this now after so many years, people would get even more confused.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *JOUBE »

ghisler(Author) wrote: 2023-07-17, 10:29 UTC Sorry but I don't want to change this now after so many years, people would get even more confused.
Thanks.
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *white »

HISTORY.TXT wrote:16.07.23 Fixed: Button bar: Pressing space on a focused button didn't open the context menu in 64-bit, or made a beep in 32-bit, need to handle it in the "key up" event (32/64)
Yes, I was wondering about that beep, that was weird to me too. BTW, you changed it after so many years, aren't the users confused now? ;)

It seems to work as designed now in TC 11.00rc2 32-bit and 64-bit. Keyboard navigation is smooth now, but that space doesn't activate the button still feels very weird.

And pressing space on a button in the overflow menu or in a subbar shown as menu, does nothing. Shouldn't that have the same behavior?
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *petermad »

history.txt wrote:17.07.23 Fixed: Shift+F10 didn't open the context menu in the vertical button bar (32/64)
Confirmed fixed in TC 11.00rc2 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *ghisler(Author) »

Thanks for confirming the fix! Since showing the right click menu within the overflow menu closes it, I prefer not to handle it via keyboard for now.
Author of Total Commander
https://www.ghisler.com
Post Reply