Lister: The issue with the Plugins menu missing 64-bit options.

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
tuska
Power Member
Power Member
Posts: 3762
Joined: 2007-05-21, 12:17 UTC

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *tuska »

2Horst.Epp
However, you have now given me this idea. :)

Only If I delete this entry, then the menu item "ulister" is also present for .eml and .msg files:

Code: Select all

Lister: view methods by file type
*.eml;*.msg	ulister.wlx64
User avatar
petermad
Power Member
Power Member
Posts: 14811
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *petermad »

I did not test with ulister (don't have it), I tested with =%COMMANDER_PATH%\PLUGINS\wlx\mmedia\mmedia.wlx64, where I have no .wlx file - and it works fine.

2tuska
Could you try temporarily to remove the .wlx file from any of your other Lister plugins, to see if that plugin doesn't turn up either.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
tuska
Power Member
Power Member
Posts: 3762
Joined: 2007-05-21, 12:17 UTC

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *tuska »

petermad wrote: 2023-08-02, 19:37 UTC 2tuska
Could you try temporarily to remove the .wlx file from any of your other Lister plugins, to see if that plugin doesn't turn up either.
Yes, I'll get back to you...
User avatar
tuska
Power Member
Power Member
Posts: 3762
Joined: 2007-05-21, 12:17 UTC

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *tuska »

2petermad
I have now REMOVED *.csv ... CSVView.wlx! (Define view method by file type...)
After that "CSVView" was visible in the plugins menu (not before).

The same for: *.mp4;*.amr ... mmedia.wlx64
User avatar
petermad
Power Member
Power Member
Posts: 14811
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *petermad »

I can confirm that if a .wlx64 plugin is listed in the [ListerModes] section, then that plugin will not be shown in Listers Plugins menu, when the associated file type is shown.

If a file type that is not associated to the plugin is shown (a txt file for example), then the plugin is shown in the menu.

Example with the mmedia plygin installed with only mmedia.wlx64 and no mmedia.wlx

With this setting mmedia is not shown in Listers Plugins menu when for example an mp4 file is opened, but it is when a txt file is opened:

Code: Select all

[ListerPlugins]
0=%COMMANDER_PATH%\PLUGINS\wlx\mmedia\mmedia.wlx64
0_detect="MULTIMEDIA"

[ListerModes]
0exts=*.mp4 *.mpg *.mpeg *.avi *.wmv *.wma *.mov *.m4a
0fields=4i,mmedia.wlx64

With this setting mmedia is shown in Listers Plugins menu when for example a mp4 file is opened:

Code: Select all

[ListerPlugins]
0=%COMMANDER_PATH%\PLUGINS\wlx\mmedia\mmedia.wlx64
0_detect="MULTIMEDIA"

[ListerModes]
0exts=*.mp4 *.mpg *.mpeg *.avi *.wmv *.wma *.mov *.m4a
0fields=4i,mmedia.wlx

And of course with this setting mmedia is shown in Listers Plugins menu when for example a mp4 file is opened:

Code: Select all

[ListerPlugins]
0=%COMMANDER_PATH%\PLUGINS\wlx\mmedia\mmedia.wlx
0_detect="MULTIMEDIA"

[ListerModes]
0exts=*.mp4 *.mpg *.mpeg *.avi *.wmv *.wma *.mov *.m4a
0fields=4i,mmedia.wlx
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
tuska
Power Member
Power Member
Posts: 3762
Joined: 2007-05-21, 12:17 UTC

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *tuska »

Here are more examples e.g. for tests.

Code: Select all

[ListerModes]
0exts=*.csv
0fields=CSVView.wlx
1exts=*.eml;*.msg
1fields=ulister.wlx64
2exts=*.cr3;*.dng;*.eps;*.heif;*.nef;*.nrw;*.ps;*.qt;*.ra;*.ram;*.rm
2fields=IrfanView.wlx
3exts=*.html
3fields=5
4exts=*.ini;*.js;*.json;*.md;*.ps1;*.txt
4fields=8
5exts=*.jp2
5fields=PhotoViewer.wlx
6exts=*.mp4;*.amr
6fields=mmedia.wlx64
7exts=*.pdf;*.epub;*.xps
7fields=SumatraPDF.wlx
8exts=*.AVIF;*.png;*.WMF
8fields=Imagine.wlx
9exts=*.sqlite;*.xys
9fields=1
10exts=*.3DS;*.AC;*.DAT;*.LWO;*.OBJ;*.PLY;*.PFZ;*.STL
10fields=WCPFREP.wlx
11exts=*.xml
11fields=6
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *ghisler(Author) »

I can confirm that ulister doesn't show up in the menu when it is set as a default for some file types - probably because it is chosen automatically anyway. I will fix it.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *AntonyD »

2ghisler(Author)
Please clarify that the fix is ​​for 64-bit plugins in general, and not just for the one mentioned 'ulister'.
Above, the situation was very clearly described, that for ANY 64-bit plugin specified in the [ListerModes] section,
these 'visibility' problems occur in the Lister plugins menu!

And by the way, 2petermad - have you tested this behavior for 32-bit plugins? No problems there?
#146217 personal license
User avatar
tuska
Power Member
Power Member
Posts: 3762
Joined: 2007-05-21, 12:17 UTC

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *tuska »

2AntonyD
32-bit plugins are not affected, i.e. after F3 Lister the plugins are displayed in the plugins menu.

As you can easily see from the above additional examples (CSVView.wlx, mmedia.wlx64),
the error affects not only the uLister plugin but also other plugins -> see section [ListerModes].
User avatar
petermad
Power Member
Power Member
Posts: 14811
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *petermad »

2AntonyD
And by the way, 2petermad - have you tested this behavior for 32-bit plugins? No problems there?
32bit plugins will always have a .wlx (or uwlx) file - so there will never be a problem here.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
tuska
Power Member
Power Member
Posts: 3762
Joined: 2007-05-21, 12:17 UTC

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *tuska »

In this context, I am unclear about the following:

Example:

Code: Select all

Name/Ext	Size		Date			Attr
CSVView.wlx	1 863 168	25.03.2020 12:02	-a--
CSVView.wlx64	2 972 160	25.03.2020 12:02	-a--
Configuration > Options... > Edit/View > Configure internal viewer... > Tab "Multimedia" > Define view method by file type... >
Lister: view methods by file type: Add... > *.csv > OK > '+' > 4 Image/Multimedia > CSVView.wlx (only .wlx selectable)

Here mainly only .wlx files are offered for selection, although there are often additionally .wlx64 files.
Should .wlx64 files perhaps also be selectable here?
Although, TC x64 can also use .wlx files.
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *AntonyD »

2tuska
the error affects not only the uLister plugin but also other plugins
That’s what I realized in fact - and now I’m asking Mr.Ghisler to confirm that he understood this moment
and that’s why his fix should work with all plugins 64 bit.
Should .wlx64 files perhaps also be selectable here?
By the way, this is a very good wish/question. It is really very painful that Total internally works
with two types of plugins, but in fact the user has "bad" usability - it makes it work only with .wlx files.
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14811
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *petermad »

Although, TC x64 can also use .wlx files.
no - but if a .wlx64 file with a corresponding name exist, TC will use that in stead - That is why you can always use the .wlx extension in the [ListerPlugins] section. Allover in TC where plugins are used they can be referred to with the .wlx extension.

The problem with the Lister Plugins menu was that if a plugin was installed with the .wlx64 extension in [ListerPlugins], TC could not find the plugin, when there was not a corresponding .wlx file in the plugins directory. - this part is fixed.

But for the "View modes by file type" it is still a problem if the .wlx64 extension is used - somehow this messes up the way Lister retrieves the plugin names for the Plugins menu, but only when the extension for the selected file is associated with the plugin in the "View modes by file type" setting. This is what Ghisler will fix.

A workaround, until it is fixed is simply just to change the .wlx64 extension for your plugin in the [ListerPlugins] section - for example
change:

Code: Select all

0=%COMMANDER_PATH%\plugins\wlx\ulister\ulister.wlx64
to:

Code: Select all

0=%COMMANDER_PATH%\plugins\wlx\ulister\ulister.wlx
it will work even if you don't have a ulister.wlx
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
tuska
Power Member
Power Member
Posts: 3762
Joined: 2007-05-21, 12:17 UTC

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *tuska »

petermad wrote: 2023-08-03, 12:06 UTC
Although, TC x64 can also use .wlx files.
no ...
Sorry for my wrong assumption. :?

Thank you for your detailed comments!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: The issue with the Plugins menu missing 64-bit options.

Post by *ghisler(Author) »

Yes, it affects all plugins which are only installed as a 64-bit version, not just ulister.
Author of Total Commander
https://www.ghisler.com
Post Reply