[TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

jirzi
Junior Member
Junior Member
Posts: 7
Joined: 2004-09-25, 09:23 UTC

[TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *jirzi »

Hi,
during my regular use, I encountered quite strange error. ZIP, created by TC, was not correctly extractable by Windows Explorer internal ZIP extractor.
Corrupted files were always DLLs.
Procedure was easily reproducible on several different computers.
TC: 11.01 x64
Windows 10 22H2
1. With TC, go to folder c:\windows\system32 in left panel and in in some temp folder, like c:\temp in right panel
2. Select all dll in that left panel folder, like Numeric +, *.dll, Enter -> in my case 3452 files
3. Alt-F5, select ZIP, default options (first two checkboxes), compression ratio 6, OK -> system32.zip, 660.958.535 bytes in right panel
4. Open Windows Explorer and go to created ZIP
5. RMB -> Extract All -> Extract -> first error on AppxApplicabilityEngine.dll, if skip, there are more errors
6. Using TC or 7zip, ZIP is extracted without errors
Images -> first two corrupted DLLs
Image: https://ibb.co/8PCFpmb
Image: https://ibb.co/yV0sBwn
License #135134
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6495
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *Horst.Epp »

Confirmed
Only the internal zip packer creates the problem.
Using the new TC 11 feature to let 7z.exe create zip files, extract in Explorer works fine.
Windows 11 Home x64 Version 23H2 (OS Build 22631.3527)
TC 11.03 x64 / x86
Everything 1.5.0.1373a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.73
QAP 11.6.3.2 x64
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *white »

Confirmed with Windows 11 Pro and TC 11.01. Works fine when using TC 10.52.
You can simply pack any of these files:

Code: Select all

AppxApplicabilityEngine.dll
AppxPackaging.dll
BCP47Langs.dll
BCP47mrm.dll
C_G18030.DLL
It seems that the new packing of TC 11 (using the new libdeflate library) is not entirely compatible with Window unpacking capabilities.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *petermad »

The file C_G18030.DLL is one of the files that cannot be unpacked by Explorer an the file is common to both Wincows 7 and 10, so I could test in both Systems and can confirm the bug.

If I rename TC's LIBDEFLATE64.DLL file and pack C_G18030.DLL it can be unpacked by Explorer, but if I pack it with LIBDEFLATE64.DLL present, then Explorer cannot unpack the file.

It is the same with 32bit TC and using LIBDEFLATE.DLL
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *petermad »

white wrote: 2023-09-22, 16:57 UTC You can simply pack any of these files:

Code: Select all

AppxApplicabilityEngine.dll
AppxPackaging.dll
BCP47Langs.dll
BCP47mrm.dll
C_G18030.DLL
It seems that the new packing of TC 11 (using the new libdeflate library) is not entirely compatible with Window unpacking capabilities.

I don't get the error with AppxPackaging.dll and BCP47mrm.dll - but i get it with Windows.Media.Protection.PlayReady.dll
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *white »

pulbitz wrote: 2023-09-22, 23:28 UTC This appears to be a fixed issue in libdeflate v1.19

https://github.com/ebiggers/libdeflate/issues/323
Aah, an issue openen by Christian Ghisler where he offers a $2000 reward to fix it. I guess he knows about it then ;)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *ghisler(Author) »

I have sent a bug report to Microsoft about the Explorer bug via Windows 11 feedback hub. It works in Windows XP Explorer and all other packers (WinRAR, 7zip, Windzip, even pkzip 2.04g!), but doesn't work in Windows 7 Explorer and newer. As described in the github thread, they are violating RFC 1951 which defines the Deflate standard. Libdeflate used by Total Commander is not faulty. However, I'm currently working on a new version where I incude the change by the libdeflate author to make the archives compatible with Explorer.

You can already test the new dlls if you want:
https://www.totalcommander.ch/win/libdeflate_updated.7z

It would be very helpful if as many people as possible could comment on the feedback hub message, so Microsoft no longer ignores it. Unfortunately only Windows 11 users can access it.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *white »

ghisler(Author) wrote: 2023-09-23, 09:32 UTC I have sent a bug report to Microsoft about the Explorer bug via Windows 11 feedback hub.
I've seen reports suggesting that Feedback-hub is designed to differentiate between Insider and non-Insider accounts. I have no Insider account and I get "Your account has no access to this feedback."
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *petermad »

I can confirm that these problematic files:

Code: Select all

Name/Ext                                   Size     Date
AppxApplicabilityEngine.dll                239.432  09-04-2021 15:44
AppxPackaging.dll                        1.835.904  09-08-2023 15:58
BCP47Langs.dll                             362.080  09-03-2022 13:02
C_G18030.DLL                               223.744  14-07-2009 03:40
Windows.Media.Protection.PlayReady.dll  10.347.936  13-09-2023 05:49
BCP47mrm.dll                               176.672  12-02-2022 04:47
are now correctly unpacked by Windows Explorer (Windows 7) when packed using the new libdeflate libraries: https://www.totalcommander.ch/win/libdeflate_updated.7z Tested with both 32bit and 64bit TC 11.01
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *white »

petermad wrote: 2023-09-23, 10:39 UTC are now correctly unpacked by Windows Explorer (Windows 7) when packed using the new libdeflate libraries: https://www.totalcommander.ch/win/libdeflate_updated.7z Tested with both 32bit and 64bit TC 11.01
Also tested OK using Windows 11 Pro.
jirzi
Junior Member
Junior Member
Posts: 7
Joined: 2004-09-25, 09:23 UTC

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *jirzi »

Confirmed.
Thanks to all who replied and Christian for solution.
License #135134
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *petermad »

history.txt wrote:10.09.23 Fixed: In rare cases, the Windows 7/8/10/11 Explorer couldn't unpack ZIP archives created with the new libdeflate dll, although all other packers including Windows XP Explorer, pkzip, winzip, winrar and 7zip could (32/64)
I can confirm that the previously mentioned files, can be unpacked by Windows Explorer when packed wit TC's internal ZIP-packer and compression below 10. :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *white »

LIBDEFLATE.DLL and LIBDEFLATE64.DLL included with TC 11.02rc1 are different than the ones included in libdeflate_updated.7z, but they produce the same zip files. If the differences are not entirely meaningless then perhaps libdeflate_updated.7z should be updated or removed from the server.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.01] ZIP created by TC extracted with errors by Windows Explorer

Post by *ghisler(Author) »

The change is to support the following new function:
25.09.23 Added: Menu Files - Test archives: Show warning when a ZIP file (created by the new libdeflate) can't be unpacked by Windows Explorer due to an Explorer bug (32/64)
I have updated the archive and added a link to it to the newsletter.
Author of Total Commander
https://www.ghisler.com
Post Reply