ShrinkBitmap=2 has disappeared in the wincmd.ini file

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
monarch-lfv
Junior Member
Junior Member
Posts: 73
Joined: 2022-06-16, 23:37 UTC

ShrinkBitmap=2 has disappeared in the wincmd.ini file

Post by *monarch-lfv »

The problem is the following, do the following step by step:
1. Quick view files *.jpg using the Imagine plugin.
2. Switch to another panel (TAB) and press the "4" button to view without plugins (built-in image viewer)
3. Change the image scale (zoom in using ctrl+scrollmouse)
4. Switch back to the file panel (TAB) and navigate to another image file - the scale will remain enlarged.
5. Turn off quick view and turn it on again, now the Imagine plugin does not fit the image into the window, but zooms in, and the line ShrinkBitmap=2 has disappeared in the wincmd.ini file.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: ShrinkBitmap=2 has disappeared in the wincmd.ini file

Post by *ghisler(Author) »

This isn't a bug. By changing the scale, you turn off the "fit to window" mode.
Author of Total Commander
https://www.ghisler.com
monarch-lfv
Junior Member
Junior Member
Posts: 73
Joined: 2022-06-16, 23:37 UTC

Re: ShrinkBitmap=2 has disappeared in the wincmd.ini file

Post by *monarch-lfv »

2ghisler(Author)
If so, why, if you completely disable the Imagine plugin and view only with the built-in viewer, then changing the scale and doing the operations in the same sequence does not entail deleting the ShrinkBitmap=2 line in wincmd.ini?
That is:
1. Quick view files *.jpg using built-in viewer.
2. Change the image scale (zoom in using ctrl+scrollmouse)
3. Switch back to the file panel (TAB) and navigate to another image file - the scale will remain enlarged.
4. Turn off quick view and turn it on again, now the built-in viewer does fit the image into the window, and the line exist ShrinkBitmap=2 in the wincmd.ini file.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: ShrinkBitmap=2 has disappeared in the wincmd.ini file

Post by *ghisler(Author) »

I have checked it in the debugger now: Apparently imagine sends a message WM_COMMAND with parameter itm_fit to tell TC that the user changed the full screen method. Normally this should only be sent when the user changed the method, so TC assumes that the function was turned off and stores it in wincmd.ini. I will add some code to catch this situation, so it's only stored when the zoom factor is still unset.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: ShrinkBitmap=2 has disappeared in the wincmd.ini file

Post by *ghisler(Author) »

This should be fixed in RC6, please test it!
31.10.23 Fixed: Don't change ShrinkBitmap in wincmd.ini when a plugin sends WM_COMMAND with option itm_fit to Lister when already zoomed (32/64)
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: ShrinkBitmap=2 has disappeared in the wincmd.ini file

Post by *petermad »

I can confirm the fix in TC 11.02rc6

If I have "Fit only larger images to window" enabled and I scale an image in the Internal viewer and switch to Imagine, then Imagine does not fit the image, because the scaling in the Internal viewer has disabled "Fit only larger images to window". But if I close Lister (or QuickView) and open it again, then "Fit only larger images to window" is reenabled, which it was not in TC 11.02rc5 - so I consider the problem fixed.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
monarch-lfv
Junior Member
Junior Member
Posts: 73
Joined: 2022-06-16, 23:37 UTC

Re: ShrinkBitmap=2 has disappeared in the wincmd.ini file

Post by *monarch-lfv »

2ghisler(Author)
I apologize for not answering for a long time. Yes, I confirm that it has been fixed. Thank you!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: ShrinkBitmap=2 has disappeared in the wincmd.ini file

Post by *ghisler(Author) »

Great, thanks!

Moderator message

Moved to fixed bugs
Author of Total Commander
https://www.ghisler.com
Post Reply