Page 1 of 1
File compare tool: Add keyboard shortcut to tooltip for the Save button
Posted: 2023-11-12, 21:42 UTC
by white
* Select two files and choose menu option Files/Compare by Content
* Hover the mouse over the Save button
A tooltip is shown with the text "Save". I suggest including "(Ctrl+S)" to display the keyboard shortcut, similar to the tooltips for the Find and Find Next buttons.
Re: File compare tool: Add keyboard shortcut to tooltip for the Save button
Posted: 2023-11-12, 23:57 UTC
by petermad
Good idea. It is just a change to string 1612 in the .lng file - I don't think that string is used anywhere else, but Christian must know that.
Re: File compare tool: Add keyboard shortcut to tooltip for the Save button
Posted: 2023-11-14, 16:24 UTC
by ghisler(Author)
String 1612 is also used in the title of the dialog to save the selection when saving settings in "Synchronize dirs":
1. Select files
2. Synchronize dirs
3. Click on folder button
4. Choose "Add current directories and settings to list"
5. Enter name
6. Confirm dialog
-> dialog to save selection to file starts with string 1612.
Re: File compare tool: Add keyboard shortcut to tooltip for the Save button
Posted: 2023-11-14, 18:51 UTC
by white
So the suggestion is to solve that. For example by adding a separate string for the save selection dialog, or by adding a string for the keyboard shortcut.
Re: File compare tool: Add keyboard shortcut to tooltip for the Save button
Posted: 2023-11-14, 21:20 UTC
by petermad
or by adding a string for the keyboard shortcut.
I vote for that - it could be a new string 1489, just before the two related strings:
1490="Find (F7)"
1491="Find next (F3)"
Re: File compare tool: Add keyboard shortcut to tooltip for the Save button
Posted: 2023-11-15, 21:55 UTC
by ghisler(Author)
Why would it need a new string? The hotkey could be appended programmatically.
Re: File compare tool: Add keyboard shortcut to tooltip for the Save button
Posted: 2023-11-15, 22:10 UTC
by JOUBE
ghisler(Author) wrote: ↑2023-11-15, 21:55 UTC
The hotkey could be appended programmatically.
Oh, no. Don't do such things.
Re: File compare tool: Add keyboard shortcut to tooltip for the Save button
Posted: 2023-11-15, 22:11 UTC
by ghisler(Author)
Why not?
Re: File compare tool: Add keyboard shortcut to tooltip for the Save button
Posted: 2023-11-15, 22:14 UTC
by JOUBE
- Translations... Some people e.g. in german language do not like Strg+S but Ctrl+S, or Ctrl-S... and want to change it themselfs for there needs/wishes in lng file.
- Hardcoding is against the TC rules, if soft configuring is possible
- This info about the shortcut is not a must at this button
Re: File compare tool: Add keyboard shortcut to tooltip for the Save button
Posted: 2023-11-16, 08:54 UTC
by ghisler(Author)
Translations aren't an argument, the keys are translated in strings 5282..5284 and 5299.
Adding a string would be better than modifying an existing one which is already used for other things.
Re: File compare tool: Add keyboard shortcut to tooltip for the Save button
Posted: 2023-11-17, 12:03 UTC
by JOUBE
Ever heard of SAA (Systems Application Architecture), CUA (Common User Access) and - following - Windows Keyboard shortcuts?
If someone - pointlessly - want to write down obvious shortcuts again, he make it clear that he have no interest in these similarities and no understanding of these common features of a user interface.
The Tc shouldn't do that to itself.
Joube