Synchronize dirs from FTP: unable to cancel

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
szfjozsef
Junior Member
Junior Member
Posts: 3
Joined: 2022-11-14, 19:48 UTC

Synchronize dirs from FTP: unable to cancel

Post by *szfjozsef »

When syncing FTP > Local dir, the process cannot be cancelled normally, the user has to struggle countless times to actually stop the process.
To reproduce:
1. Connect to a FTP
2. Select some dirs to sync.
3. Commands -> Synchronize dirs.
4. Click Compare.
Now
a) Click Canncel during the compare process
b) Synchronize the dirs and then try to click Cancel during the compare process after the synchronization.
In either cases a dialog appears: "User abort!", having 3 buttons: OK (Stop) | Cancel | Finish copying current file.
Problem:
Clicking any of the buttons will not cancel the process! The FTP reading process still continues. Often, the process has to be cancelled 5-10 times before actually stops.
I suggest setting some global variable "The user cancelled the operation" and read this variable in the FTP routine. Currently it seems that the cancellation takes place only in certain phases of the FTP communication...

This problem was present in all TC versions, since the early times.

A screen recording of the problem: https://drive.google.com/file/d/1qev4olmKx8m3Ku0KkODKjqK0hH6qXANj/view?usp=sharing
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Synchronize dirs from FTP: unable to cancel

Post by *ghisler(Author) »

"OK (Stop)" should immediately cancel the process. Maybe you clicked "Cancel"?
Author of Total Commander
https://www.ghisler.com
szfjozsef
Junior Member
Junior Member
Posts: 3
Joined: 2022-11-14, 19:48 UTC

Re: Synchronize dirs from FTP: unable to cancel

Post by *szfjozsef »

"OK (Stop)" does NOT cancel the process.
Please test the functionality as described or please watch the attached video.
Definitely I did not hit 'Cancel', I am clicking "OK (Stop)".
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Synchronize dirs from FTP: unable to cancel

Post by *ghisler(Author) »

I have tested this now:
"OK (Stop)" does stop downloading files here. It does not stop the reading of the directories, though - I will fix that.
As a workaround, press ESC to abort this step.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Synchronize dirs from FTP: unable to cancel

Post by *ghisler(Author) »

This should be fixed in Total Commander 11.03 RC1, please check it!
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Synchronize dirs from FTP: unable to cancel

Post by *ghisler(Author) »

The user who reported it has confirmed by e-mail that the bug has been fixed.
I downloaded this 11.03 version and I can confirm that it is working as expected - cancelling the FTP read operation is immediate.

Moderator message

Moved to fixed bugs
Author of Total Commander
https://www.ghisler.com
Post Reply