TC 11.03RC1 - Lister and video files

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: TC 11.03RC1 - Lister and video files

Post by *Fla$her »

beb wrote: 2024-01-23, 18:14 UTC If the icons are there, it means a user has specifically invoked advanced settings and made a somewhat input in there who knows which.
Is the issue you encounter being repeated on every video you try, or only on the specific ones?
This is not the case, no changes have been made to the settings.
I haven't seen any trouble-free videos yet.
Overquoting is evil! 👎
User avatar
beb
Senior Member
Senior Member
Posts: 435
Joined: 2009-09-20, 08:03 UTC
Location: Odesa, Ukraine

Re: TC 11.03RC1 - Lister and video files

Post by *beb »

ghisler(Author) wrote: 2024-01-22, 10:04 UTC Sorry, it's a bug in RC1. By mistake, both 32-bit and 64-bit version are looking in filter32 directory for their filters, but 64-bit should be looking in filter64. I will fix it in RC2...
Can confirm, with the tc1103rc2 the issue has gone.
I have completely removed [Lister]filter32dir=%commander_path%\Filter32\ and [Lister]filter64dir=%commander_path%\Filter64\ entries from the ini and it works fine.
Thank you.
#278521 User License
Total Commander [always the latest version, including betas] x86/x64 on Win10 x64/Android 10
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: TC 11.03RC1 - Lister and video files

Post by *petermad »

history.txt wrote:22.01.24 Fixed: Lister was looking in filter32 directory for LAV filters instead of filter64 (64)
Confirmed fixed in TC 11.03rc2 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Sombra
Power Member
Power Member
Posts: 811
Joined: 2005-12-27, 22:23 UTC
Location: Zaragoza, Spain

Re: TC 11.03RC1 - Lister and video files

Post by *Sombra »

Yes, Fixed confirmed!
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: TC 11.03RC1 - Lister and video files

Post by *Fla$her »

Fla$her wrote: 2024-01-23, 16:36 UTC For mkv, for example, these threads remain active in TC: DSOUND.DLL, LAVSplitter.ax, VSFilter.dll, quartz.dll and evr.dll.
I forgot to note: if you complete quartz.dll, the player will no longer appear in Lister.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 11.03RC1 - Lister and video files

Post by *ghisler(Author) »

Confirmed fixed in TC 11.03rc2 :-)
Thanks!
There are no improvements in RC2 yet.
That's because I can't reproduce any bug. Even on Windows XP the player threads all end when I close Lister with ESC. I really don't know what's wrong on your PC.
Lister: dshow command: destroy
I'm taking down the video playback graph in this function, by removing the player from the running object table and then releasing all interfaces.

I had code in there which called

Code: Select all

  if state=state_running then
    stop;
but it has a comment "don't call stop here, or we can't delete the file!". I will check whether I can enable that without the file being locked. This still doesn't explain why the threads don't end on your system, the player releases all the interfaces to them.
Author of Total Commander
https://www.ghisler.com
User avatar
Dalai
Power Member
Power Member
Posts: 9393
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Re: TC 11.03RC1 - Lister and video files

Post by *Dalai »

Fla$her wrote: 2024-01-23, 16:36 UTCFor mkv, for example, these threads remain active in TC: DSOUND.DLL, LAVSplitter.ax, VSFilter.dll, quartz.dll and evr.dll.
Are you talking about threads or about the DLLs which are still loaded into the process? A DLL is not a thread.

2Ghisler:
Is TC supposed to unload the DLLs used to play videos when Lister is closed?

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 11.03RC1 - Lister and video files

Post by *ghisler(Author) »

No, the DLLs don't get unloaded, at least I can't delete them after viewing a video.
However, the threads should stop - you can check this with the tool "Process Explorer" from Microsoft SysInternals. The properties of a program have a tab "Threads".
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: TC 11.03RC1 - Lister and video files

Post by *Fla$her »

ghisler(Author) wrote: 2024-01-24, 08:29 UTCI will check whether I can enable that without the file being locked.
OK.
Dalai wrote: 2024-01-24, 11:24 UTC Are you talking about threads or about the DLLs which are still loaded into the process? A DLL is not a thread.
There can be multiple threads from each library (not just dll). See the 3rd tab in \\\AceHelper\Processes\TOTALCMD.EXE.
Overquoting is evil! 👎
User avatar
Dalai
Power Member
Power Member
Posts: 9393
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Re: TC 11.03RC1 - Lister and video files

Post by *Dalai »

Fla$her wrote: 2024-01-24, 13:07 UTCThere can be multiple threads from each library (not just dll).
I'm well aware of this. But it doesn't answer my question of what you're talking about: threads or DLLs. As Ghisler said, TC doesn't unload the DLLs when Lister is closed.
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: TC 11.03RC1 - Lister and video files

Post by *Fla$her »

Dalai wrote: 2024-01-24, 14:07 UTC But it doesn't answer my question of what you're talking about: threads or DLLs.
If I execute TerminateThread via the context menu on this tab, of course I'm writing about threads.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 11.03RC1 - Lister and video files

Post by *ghisler(Author) »

2Fla$her: It's possible that I will not be able to fix your problem. In this stackoverflow thread, a developer seems to have the same problem: They unload all the COM objects as i do, but the filter graph doesn't stop playing. Since you write that this happens even when you let the video end, stopping the video before unloading will probably not help either. This means that you will get more and more (idle) threads until windows can't open any more threads or runs out of memory.

Since this doesn't work on my XP system, it is most probably a codec problem. For test purposes, please rename your filter32 directory (may need to close and re-open Total Commander first), create a new one and then put the codecs from my system in there.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: TC 11.03RC1 - Lister and video files

Post by *Fla$her »

2ghisler(Author)
It's a pity if that's the case.

Your codecs match mine, only your archive doesn't contain VSFilter.dll, but I already wrote that his movement has no effect.
The only thing I can notice is that if I rename the FILTER32 folder, then only audio on a black background is played in the window, and when closing Lister, the threads with DSOUND.DLL, quartz.dll and splitter.ax are immediately terminated.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 11.03RC1 - Lister and video files

Post by *ghisler(Author) »

Well, if it isn't Windows XP and isn't the codecs, what remains?
1. It could be the videos you tried, their encodings may cause the problem. Can you try one of my videos?
https://www.totalcommander.ch/img/testvideo.mp4
2. It could be some background software like a virus scanner or other low level software.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: TC 11.03RC1 - Lister and video files

Post by *Fla$her »

Why not codecs? I think this is due to Lavfilers, as long as there is no problem with the system audio codec without them.
1. The same problems.
2. There are no scanners. I can suspect that the NVidia driver may have something to do with this.
Overquoting is evil! 👎
Post Reply