Page 1 of 1

[implemented] About icons for em_commands in Main menu

Posted: 2024-10-19, 12:24 UTC
by petermad
history.txt wrote:16.10.24 Added: Use icon defined in em_command also in main menu, but only from wcmicons.dll or .ico files, not from arbitrary exe or dll files (speed reasons) (32/64)
Thanks a lot for that new feature - it will save me a lot of time not having to update wcmicons.inc every time I make a change to my menu files.

This doesn't work though:

Code: Select all

button=wcmicons.dll
I have to use:

Code: Select all

button=wcmicons.dll,0
could that be fixed? Usually not giving an index means index 0.

And if I have set the button= to use an .exe file, but also have en entry in wcmicons.inc for that em_command, then the icon stated in wcmicons.inc is not used - I think wcmicons.inc should only be overruled if the button= is set to wcmiconc.dll or an .ico file

Could you probably also make this feature support icons from %COMMANDER_EXE%

Re: About icons for em_commands in Main menu

Posted: 2024-10-20, 08:00 UTC
by ghisler(Author)
Usually not giving an index means index 0.
OK, I will add that.
And if I have set the button= to use an .exe file, but also have en entry in wcmicons.inc for that em_command, then the icon stated in wcmicons.inc is not used
Not confirmed. It's not used when button=wcmicons.dll or button=wcmicons.dll,invalid, but not when button=notepad.exe or so.
Could you probably also make this feature support icons from %COMMANDER_EXE%
Difficult because there are multiple ways to give the program name.

Re: About icons for em_commands in Main menu

Posted: 2024-10-20, 12:24 UTC
by petermad
but not when button=notepad.exe or so.
You are right, I must have had the wrong .inc file in use when I tested it - sorry :oops:

Difficult because there are multiple ways to give the program name.
Then restrict it to only work when %COMMANDER_EXE% is used, is that feasible?

Re: About icons for em_commands in Main menu

Posted: 2024-10-24, 00:05 UTC
by petermad
history.txt wrote:22.10.24 Added: Main menu, start menu, em_command: Also use icons from main Total Commander executable, must be set to %COMMANDER_EXE% or the program name without path (32/64)

20.10.24 Fixed: Menu "Start": Use icon defined in em_command from wcmicons.dll even if no icon index specified -> use first icon (32/64)
Thanks for implementing this :-)


Maybe this:
20.10.24 Fixed: Menu "Start": Use icon defined in em_command from wcmicons.dll even if no icon index specified -> use first icon (32/64)
should be changed to:
20.10.24 Fixed: Main menu, Start menu": Use icon defined in em_command from wcmicons.dll even if no icon index specified -> use first icon (32/64)

Re: [implemented] About icons for em_commands in Main menu

Posted: 2024-10-24, 07:25 UTC
by ghisler(Author)
OK, I have updated the history.

Re: [implemented] About icons for em_commands in Main menu

Posted: 2024-10-30, 19:33 UTC
by white
petermad wrote: 2024-10-24, 00:05 UTC should be changed to:
20.10.24 Fixed: Main menu, Start menu": Use icon defined in em_command from wcmicons.dll even if no icon index specified -> use first icon (32/64)
ghisler(Author) wrote: 2024-10-24, 07:25 UTC OK, I have updated the history.
Confirmed, but wasn't the double quote character a typo by petermad?

Re: [implemented] About icons for em_commands in Main menu

Posted: 2024-10-30, 20:26 UTC
by petermad
Confirmed, but wasn't the double quote character a typo by petermad?
It was, I forgot to remove the " after Start (now after menu) - it should of course be removed in the history file.