Page 1 of 1
internal 7zip: Error Messages Bugs and Improvements
Posted: 2024-11-03, 11:10 UTC
by funkymonk
TC 11.50b4 x32 dark @ Win11
When cancelling file compression with the new internal 7zip packer:
- An "Error" box appears: https://ibb.co/NWydtxz
Imho, cancelling/aborting the process is not an error --> Thus, this should be an "Info" box.
And: The message box uses the light color theme even if the dark theme is active for TC.
- Right after the 1st error box, a 2nd message box appears that indicates the error again: https://ibb.co/hBs2yWc
Imho, it's still not an error.
And: Why a *second* message box at all? --> One is enough.
--> Suggestion: Display a single "Info" box with the correct color theme to confirm the cancellation -- and that's it.
(Cancelling a zip packing process could serve as an example. However, for zip, cancelling is shown as an error as well. This should also be changed.)
Re: internal 7zip: Error Messages Bugs and Improvements
Posted: 2024-11-03, 13:24 UTC
by petermad
An "Error" box appears:
https://ibb.co/NWydtxz
Imho, cancelling/aborting the process is not an error --> Thus, this should be an "Info" box.
And: The message box uses the light color theme even if the dark theme is active for TC.
I don't think this is a TC message, hence it is not using TC's Dark theme setting. The English part of the message can be found inside TCBIT7Z64.DLL
7-zip (TzG.exe) has it's own dialog when cancelling packing (pressing Escape): "Are you sure you want to cancel?"
If I use 7zG.exe instead of Internal 7-Zip packer I get the message "Are you sure you want to cancel?" - but then if I choose to cancel, I also get that second TC-error message "Error packing files!" - that should not happen.
Re: internal 7zip: Error Messages Bugs and Improvements
Posted: 2024-11-04, 08:53 UTC
by ghisler(Author)
I don't think that these are bugs.
Moderator message from: ghisler(Author) ยป 2024-11-04, 08:53 UTC
Moved to suggestions
Re: internal 7zip: Error Messages Bugs and Improvements
Posted: 2024-11-04, 12:33 UTC
by petermad
If it is not a bug, then I suggest that that Internal 7-Zip packing captures the error code from the dll when the user cancels the operation and only shows TC's "Error packing files" OR better the error message: "Pack aborted" that is shown when aborting packing .zip files.
Re: internal 7zip: Error Messages Bugs and Improvements
Posted: 2024-11-06, 22:07 UTC
by petermad
History.txt wrote:05.11.24 Fixed: 7-Zip packer: Improved error handling when compression aborted, or files couldn't be opened (32/64)
Confirmed that only one massage box with the text: "User abort!" is shown now, when aborting internal 7-Zip packing.
When using the external 7zG.exe packer aborting the packing still gives both a dialog from 7-Zip and if answering "Yes" in that TC also shows the message: "Error packing files!" - could the TC message be suppressed in this case?
Re: internal 7zip: Error Messages Bugs and Improvements
Posted: 2024-11-07, 06:42 UTC
by funkymonk
11.50b4 x32
Code: Select all
05.11.24 Fixed: 7-Zip packer: Improved error handling when compression aborted, or files couldn't be opened (32/64)
Looks good now.