Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Stefan2, Hacker, petermad

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 17375
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *petermad »

history.txt wrote:23.03.26 Fixed: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active via header (32/64)
Seems to work that way for most plugins, but not for TCSumatraPDF (v. 1.19) - but maybe that is a problem in the plugin
License #524 1994
Danish TC Translator
TC 11.58 32+64bit on Windows XP 32bit & Windows 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1416b
TC 3.62 on Android 6, 13, 15 & 16
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Fla$her
Power Member
Power Member
Posts: 4033
Joined: 2020-01-18, 04:03 UTC

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *Fla$her »

2petermad
I recommend checking all of the author's plugins regarding this. There is a peculiar approach to embedding windows into the TC interface.
Overquoting is evil! 👎
User avatar
petermad
Power Member
Power Member
Posts: 17375
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *petermad »

The TCSumatraPDF package does not say anywhere who the author is, so I don't know which other plugins to test.

I see the same problem with EdgeViewer - click on the plugin does not activate the panel header.
License #524 1994
Danish TC Translator
TC 11.58 32+64bit on Windows XP 32bit & Windows 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1416b
TC 3.62 on Android 6, 13, 15 & 16
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Fla$her
Power Member
Power Member
Posts: 4033
Joined: 2020-01-18, 04:03 UTC

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *Fla$her »

What does Legal Copyright from peviewer for SumatraPDF.wlx tell you? Or here? Valery Kurenkov aka AkulaBig. All the names of its wlx plugins start with 'TC'. Use quick filtering in "%COMMANDER_PATH%\Plugins\wlx\".

I suppose anything that embeds third-party application windows, rather than rendering its own, will behave in a similar way. slister is also not activated by clicking in the Sumatra window.
Overquoting is evil! 👎
User avatar
petermad
Power Member
Power Member
Posts: 17375
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *petermad »

I don't have any other plugins from Valery Kurenkov (I could see his name in the wlx file with the fileinfo plugin - I don't have peviewer)

You are correct that slister also has the problem.

But SumatraPDF (1,2) by Krzysztof J. Kowalczyk et Al does not have the problem - it does not use SumatraPDF.exe as slister and TCSumatraPDF does.
License #524 1994
Danish TC Translator
TC 11.58 32+64bit on Windows XP 32bit & Windows 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1416b
TC 3.62 on Android 6, 13, 15 & 16
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Fla$her
Power Member
Power Member
Posts: 4033
Joined: 2020-01-18, 04:03 UTC

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *Fla$her »

I also hardly use them. In any case, you've probably come across the mention of TCIrfanView and TCAkelPad several times. And you may have seen our long discussions on TC1by1. About TCModPlug, TCFlashPlayer, TCAlReaderExt, you probably don't even know.
But SumatraPDF (1,2) by Krzysztof J. Kowalczyk et Al does not have the problem - it does not use SumatraPDF.exe as slister and TCSumatraPDF does.
I don't understand the meaning of what you wrote. Try to rephrase it.
Overquoting is evil! 👎
User avatar
petermad
Power Member
Power Member
Posts: 17375
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *petermad »

Try to rephrase it.
I have an older PDF viewer named SumatraPDF made by Krzysztof J. Kowalczyk an others. Unlike slister and TCSumatraPDF it does not use any external programs for example SumatraPDF.exe (currently SumatraPDF-3.6-64.exe) - it is all contained in the .wlx/.wlx64 file - so this is in line with what you write here:
I suppose anything that embeds third-party application windows, rather than rendering its own, will behave in a similar way.
https://tcmd.madsenworld.dk/plugins/wlx_sumatrapdf_0.8.1_x64_source.zip
License #524 1994
Danish TC Translator
TC 11.58 32+64bit on Windows XP 32bit & Windows 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1416b
TC 3.62 on Android 6, 13, 15 & 16
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 53139
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *ghisler(Author) »

Seems to work that way for most plugins, but not for TCSumatraPDF (v. 1.19) - but maybe that is a problem in the plugin
Thanks for confirming the fix! TCSumatraPDF and SLister show a window from a different executable embedded in Total Commander. In this case, TC will not receive any mouse click messages in its message loop, so it cannot see when the window gets clicked. Therefore it's impossible to know that the user clicked on the plugin. I don't want to use a mouse hook which would see the mouse in all programs, because this can be seen as spying by anti-malware tools.

Moderator message from: ghisler(Author) » 2026-03-26, 09:50 UTC

Moved to will not be changed
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 4033
Joined: 2020-01-18, 04:03 UTC

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *Fla$her »

2petermad
Now I understand. Thanks for the clarifications. I didn't know that the author of Sumatra wrote his plugin for TC.

If you want, we can implement it on Autorun. Paranoid tools should not bother us.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 53139
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *ghisler(Author) »

If you want, we can implement it on Autorun. Paranoid tools should not bother us.
Sorry, what do you mean with that? You want to rewrite the Sumatra plugin?

Anyway, I found a workaround for when the focus was previously in the file panel: I can react to WM_KILLFOCUS and then check via GetFocus and multiple GetParent calls whether the focus is now on the quick view panel.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 4033
Joined: 2020-01-18, 04:03 UTC

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *Fla$her »

Sorry, what do you mean with that? You want to rewrite the Sumatra plugin?
No, just react to a click in the inactive panel area.
Anyway, I found a workaround ...
Great!
Overquoting is evil! 👎
Fla$her
Power Member
Power Member
Posts: 4033
Joined: 2020-01-18, 04:03 UTC

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *Fla$her »

2ghisler(Author)
27.03.26 Fixed: Quick view panel: Clicking on certain Lister plugins like SLister didn't show that panel as focused (color of header) (64)
It works with slister. Great! But, for example, not with 1by1.
And why did you write "(64)" at the end? It didn't work for x32 either.
Overquoting is evil! 👎
User avatar
petermad
Power Member
Power Member
Posts: 17375
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *petermad »

It didn't work for x32 either.
Confirmed for TC 11.57rc1

Shouldn't this topic be in the TC Fixed bugs section, since it is mentined as fixed in history.txt

Anyway - also confirmed that if works for at least for the slister, TCSumatraPDF and edgeviewer in both 64bit and 32bit TC 11.57rc2
License #524 1994
Danish TC Translator
TC 11.58 32+64bit on Windows XP 32bit & Windows 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1416b
TC 3.62 on Android 6, 13, 15 & 16
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Fla$her
Power Member
Power Member
Posts: 4033
Joined: 2020-01-18, 04:03 UTC

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *Fla$her »

Shouldn't this topic be in the TC Fixed bugs section, since it is mentined as fixed in history.txt
For now, it should be in "TC11.x bug reports (English)", since there are problems with other AkulaBig plugins. As a moderator, you can fix this.
Overquoting is evil! 👎
AkulaBig
Power Member
Power Member
Posts: 775
Joined: 2021-09-09, 17:28 UTC

Re: Quick view panel: Clicking on a Lister plugin didn't mark the panel as active

Post by *AkulaBig »

I saw a discussion on the topic of focus in the corrections and found this link. Yes, in three of my plugins: TC1by1, TCAlReaderExt, TCModPlug, the QuickView window title is not highlighted when the mouse is clicked in the application window. But the programs used in these plugins have a non-standard interface. They don't have a standard Windows window. I'll try to figure this out.
petermad wrote: 2026-03-25, 21:32 UTC I don't have any other plugins from Valery Kurenkov (I could see his name in the wlx file with the fileinfo plugin - I don't have peviewer)
It’s interesting, but in the English description of my most popular plugin, TCSumatraPDF, I didn’t write the author :)
[img]https://s1.hostingkartinok.com/uploads/thumbs/2026/04/8bb04ffad129dc23b2ee169c5470a107.png[/img]
In all other plugins it is in both descriptions.
ghisler(Author) wrote: 2026-03-26, 09:50 UTC I don't want to use a mouse hook which would see the mouse in all programs, because this can be seen as spying by anti-malware tools.
For me this is the only way out. Since it is impossible to make the 32-bit programs that I use for my plugins work with 64-bit plugins using standard methods.
Post Reply