[TC 11.57rc3/4] - quick view, delete, quick view panel gets focus vs up/down navigation in file panel

[hi5]

Edit: it is not specific plugins, it is all plugins - ignore all mention of specific plugins below.

This doesn't happen with a clean ini and no plugins, but with my normal setup under Win 11, 32bit (forgot to test 64bit ):

Setup:
* slister with sumatrapdf (older version which works)
* cudalister for non txt files
* imagine for images

I have a list of files, mix of images, png, pdf, txt etc and I want to view some to delete some.

I do a quick view and can then use UP/DOWN arrow keys to navigate in the active file panel to view the files, so for so good.

BUT when I delete a file while still in quick view (so I delete the file that is currently in the quick view panel using DEL), the focus on the active file panel is lost and moves to the quick view panel

So say I'm viewing a PNG file in quick view mode which calls Imagine, I press delete, the next file is a PDF which is now opened in quick view (using slister/sumatrapdf)

But THEN I starting moving pages up/down in the PDF when pressing UP/DOWN arrow as I'm no longer in the active file list panel.

The next file (after the image example above) can also be a txt file to make the quick view panel get focus so it is not PDFs that have this problem, as soon as I delete a file, the quick view is updated with the new file that is now under the caret, but the quick view also gets focus and I have to TAB back to the other panel to continue the navigation using UP/DOWN to view/find the files I want to delete.

As this doesn't happen with a fresh ini, any thought on what setting it could be that causes this?

[petermad]

It is even worse - try this:

1. Configure TC so the first plugin used for .png files is Imagine.
2. Make a folder in the left with one png and one txt file.
3. Make the right side display another folder than the left side.
4. In the left side place the cursor on the image and press Ctrl+Q.
5. Set focus on the right Quick View panel.
6. Press the Delete button - since Delete is a shortcut for deleting files in Imagine, Imagine asks to delete the file - answer Yes to that
7. Now the Imagine plugin is closed down and I can see the file list in the right side BUT the side is not responsive and has no tabstop header - I can not use Tab to set focus on the left side. I have to press Ctrl+Q twice to make the right side respond again.

If I at step 6 click on a drive button with another drive then 64bit TC crashes

If I in 32bit TC do the same and after step 6 click a drive button I get this::

---------------------------
Total Commander 11.57rc4
---------------------------
Access violation at address 0045216A. Read of address 075940C0.
Access violation at address 0045216A. Read of address 075940C0
Windows 7 SP1 Professional 6.1 (Build 7601), base: 00400000

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Windows exception: C0000005
Stack trace:
0045216A
004023FB 00452168 005A614E 0044E61C 0044E94B 00450691
004504EA >0042BCF2 0044FA88 0042BCF2 0043152D 004315C8

Raw:
00452168 0044DB56 004023FB 0040342B 00452168 005874E8
005A614E 0044F9DE 0042BCF2 00450863 0044E4E5 004507B9
0044FB52 004504EA 0045050D 0042BCF2 0044FA88 0042BCF2
004023FB 004023FB 004026C4 0044DC1D 0044E61C 00472547
0047253A 0044E94B 0044E9BF 0044E4E5 0044E427 00450691
00450765 0044FB52 004504EA 0042BCF2 0044FA88 0042BCF2
00412CE0 0043152D 004315C8 00431782
Press Ctrl+C to copy this report!
Continue execution?
---------------------------
Ja Nej
---------------------------

and thereafter this: if I click Yes:

---------------------------
Application Error
---------------------------
Exception EAccessViolation in module TOTALCMD.EXE at 00050F1E.
Access violation at address 0045216A. Read of address 07FA00C4.
---------------------------
OK
---------------------------

And TC closes down

I guess this will happen with any plugin that can delete the current file and thereafter closes down.

[Horst.Epp]

In a mix of file formats I can delete any of them while a quick view is active on the other side.
The focus stays in the file list and the cursor moves down to the next entry.

[petermad]

2Horst.Epp
My report is about deleting the curent for with the plugin - not with TC - Imagine can do that if the Quick view panel is in focus, but I cannot think of any other plugins that can do that

[hi5]

Just to be clear, I don't delete the file while the quick view panel has focus, but I stay on the file list side.

So say file list LEFT, quick view RIGHT, I use up/down to quick view files, I see that I want to delete a file, press DEL while still in the LEFT panel (file list), the file gets deleted OK and is removed from the file list in the LEFT panel

The file beneath the just deleted file is now visible in the quick panel BUT also has focus, so the "active panel" is now the RIGHT panel.
That never used to be the case, it always remained on the file list site e.g. LEFT in this example.

But you seem to have found another issue, perhaps they are related.

[petermad]

The file beneath the just deleted file is now visible in the quick panel BUT also has focus

I can not reproduce that - here by me focus stays in the left panel after deleting a file.

Notice that slister (with for example SumatraPDF-3.6.1-64.exe) has a known issue - it removes focus from TC when opened in quick view - it also happens with F3 and slister. So if the cursor moves to a pdf file after deleting a file - TC itself looses focus, not just the left panel.

[tuska]

Deleted as inaccurate.

[hi5]

It's unrelated to PDFs I'm sure (I think I'm sure).

Just now on a win10 machine I had RC1 32bit, I did the same quick view a few files (pngs), deleted a file, and I would remain in the active FILE panel and continue to move up/down to view files, that is how it should work.

Then I installed RC4, 32bit, and voila, I view a few files (gif this time), delete one, and NOW the quick view panel becomes active, so I can't continue to use up/down to navigate files, I'm "stuck" in the quick view panel and have to TAB to the file list again.

(if the newly active file is a PDF it is a bit more annoying as up/down navigates pages so something is happening at least but not what you expect).

Just to be save I also unloaded all my AHK scripts just in case, this didn't help to fix it.

So I'm fairly certain something has changed between RC1 and RC3/4 - what that is I don't know, but I do see various quick view panel fixes in the history.

[hi5]

sLister is currently unusable.

It work(ed) fine here upto RC3 (both win10/11) - that said, I just removed all lister plugins (and deleted all files in the plugins folder) related to slister, edgeviewer (which would then show PDFs I think, and and old PDFviewer I also had)

So now when I F3 or quick view a PDF I just see the binary source e.g. "%PDF-1.4" etc...

The same problem continues to happen, quick view, up/down, delete file, focus MOVES to the quick view panel.

So we can rule out slister, and all other PDF plugins. It happens with just PNGs in the file panel only as well for example.

[petermad]

2hi5

quick view, up/down, delete file, focus MOVES to the quick view panel.

I now tested it in 32bit TC 11.67rc4 and can confirm the shift of focus - but I cannot confirm it in 64bit TC

[Fla$her]

I can't confirm. In my case, the focus remains in the source panel. The arrows are working.

[ghisler(Author)]

Unfortunately some plugins steal the focus from Total Commander when refreshing.

Update: Imagine actually sends a CLOSE message to Lister after deleting the file! This makes sense when it's a standalone Lister, but causes trouble with quick view - the quick view window is closed without notifying the main program.

Solution: I will ignore the CLOSE message unless the close is initiated by Total Commander itself.

[petermad]

I now tested it in 32bit TC 11.67rc4 and can confirm the shift of focus

Tested again today in 32bit - but now I cannot reproduce it -I wonder what the culprit is - I am very sure I saw the focus shift yesterday with only pure ansi text files involved?

[hi5]

Just to confirm it happens with all my plugins (incl. csvtab, OOoViewer, etc) not just imagine / images.

[ghisler(Author)]

Just to confirm it happens with all my plugins (incl. csvtab, OOoViewer, etc) not just imagine / images.

Do your plugins send a close command to Lister after deleting a file?