[TC 11.57rc3/4] - quick view, delete, quick view panel gets focus vs up/down navigation in file panel

[petermad]

20.04.26 Fixed: Quick view panel: Opening a dialog box (e.g. delete confirmation) while the focus was on the file list could move the focus to the quick view panel (32/64)

Fixed in TC 11.57rc5 when testing as described here: viewtopic.php?p=482763#p482763

16.04.26 Fixed: Quick view panel: Deleting a file within the Imagine plugin made imagine send a CLOSE message to Lister, causing problems with quick view (32/64)

Confirmed fixed in TC 11.57rc5 when testing as described here: viewtopic.php?p=482473#p482473

But after deleting a file from Imagine in Quick View, the cursor in the file panel is moved to the previous file before the deleted one and Imagine shows the next image it can find or a blank file if there are no more images in the folder. And the Title of the Quick view keeps showing the name of the first deleted file - so yo can end up with the cursor on one file, another file displayed, and a third file shown in the Quick view title bar

The same thing can actually happen if I press Space of BackSpace in the Imagine Quick View which makes Imagine display the next or previous image in the folder without TC noticing it.

Is there any chance of detecting when Imagine displays a new file and adjust the File panel cursor position and the Quick view Title accordingly?

[hi5]

20.04.26 Fixed: Quick view panel: Opening a dialog box (e.g. delete confirmation) while the focus was on the file list could move the focus to the quick view panel (32/64)

Fixed for me on Win10 and Win11. Many thanks!


Just to confirm: I can also see what petermad describes deleting a file via imagine in the quick view panel.

[ghisler(Author)]

Great, thanks for confirming the fix!

Moderator message from: ghisler(Author) » 2026-04-23, 07:24 UTC

Moved to fixed bugs

Is there any chance of detecting when Imagine displays a new file and adjust the File panel cursor position and the Quick view Title accordingly?

No, unfortunately not - Imagine deletes the file on its own and doesn't inform Total Commander. The best you can do is enable auto-refresh in Configuration - Options - Refresh (lower part) so the file vanishes when it gets deleted.

[petermad]

The best you can do is enable auto-refresh in Configuration - Options - Refresh (lower part) so the file vanishes when it gets deleted.

I already have that enabled - that is why I end up eith the file under the cursor not being the same as the file name displayed in the Quick view Title bar.

[ghisler(Author)]

Well, Lister could inform TC that it received CLOSE command, and then Total Commander could close the Quick View panel. But I don't think that this is what the user wants. The user can just go to the next file by himself.

[petermad]

Lister could inform TC that it received CLOSE command,

In normal Lister, when using Imagine and the displayed file is changed by Imagine by pressing Space or BackSpace, Lister's Title bar is updated with the name of the new displayed file - so Lister is probably aware of the change of file. So would it be possible to also change the name in the Title bar in Quick View - so that the user can at least see that the file displayed is not the file under the cursor in the file panel.

[ghisler(Author)]

There seem to be two cases here when you delete an image in Imagine itself:
1. When there are other image files, Imagine switches to another image, and seems to set the Lister title by itself by sending it a WM_SETTEXT message.
2. When there are no more image files, Imagine send a close message to Lister.

Currently I only intercept the second case, to prevent Total Commander from crashing. I can't really take the title set via WM_SETTEXT because the title for quick view differs from the one in standalone Lister, and I can't determine whether WM_SETTEXT was sent by Imagine or via any other way.

What I can do is react to the deletion by updating the quick view panel, but only when the user has "Auto-refresh when the file system changes" enabled.

[ghisler(Author)]

2petermad
I have sent you a private beta today, can you have a look at it please?

[petermad]

I have sent you a private beta today, can you have a look at it please?

Tested both with private TC 11.57rc5a and TC 11.57rc6 on 32 and 64 bitTC

It works fine in11.57rc5a but in 11.57rc6 the inactive cursor in the file panel disappears after an Imagine deletion and when I press TAB it goes to [..] - in 11.57rc5a the cursor get moved to the file before the deleted file, which is much better - so the 11.57rc5a solution is the best

In both versions the Quick view title gets correctly updated with the file name of the new displayed image, but instead of ending with " - imagine" it ends with " - imagine.wlx" after deletion.

If I navigate in Imagine with SPACE / BACKSPACE the Quick view Title is not updated - if you can update it after a deletion why not after an image shift?

[ghisler(Author)]

so the 11.57rc5a solution is the best

The reason why I changed it in RC6 is because the cursor would just randomly go to another file when the deleted file was removed from the list. In RC6, the cursor position is set to -1 (no focus). Of course it would be better to set the cursor on the correct file, but this would trigger a reload, possibly resulting in an infinite load loop. I don't want to risk that for 11.57.

If I navigate in Imagine with SPACE / BACKSPACE the Quick view Title is not updated - if you can update it after a deletion why not after an image shift?

Currently I'm only handling the case where the previous file was deleted, so it no longer exists.

[petermad]

In RC6, the cursor position is set to -1 (no focus)

But the cursor is also invisible even if inactive cursor is activated - could the inactive cursor at least be shown on the [..] entry. I was very surprised when I pressed tab and Dirsizecalc started showing the directory.

I observed a difference between 32bit and 64bit. If I set focus on the Quick view panel and press Ctrl+Q then the 64bit version close Quick view, but in the 32bit version Imagines shortcut for Ctrl+Q (JPEG Loosless Transformation) is opened. If I remove the Ctrl+Q shortcut in Imagine's settings, the the 64bit TC still closes Quick view, while 32bit TC does nothing,

[ghisler(Author)]

But the cursor is also invisible even if inactive cursor is activated - could the inactive cursor at least be shown on the [..] entry. I was very surprised when I pressed tab and Dirsizecalc started showing the directory.

Putting the cursor on [..] would also trigger the refresh for that entry, so it's not an option.

I observed a difference between 32bit and 64bit. If I set focus on the Quick view panel and press Ctrl+Q then the 64bit version close Quick view, but in the 32bit version Imagines shortcut for Ctrl+Q (JPEG Loosless Transformation) is opened. If I remove the Ctrl+Q shortcut in Imagine's settings, the the 64bit TC still closes Quick view, while 32bit TC does nothing,

I'm subclassing the plugin window to intercept common keys like Ctrl+Q. Some plugins override this. It also doesn't work when a plugin uses nested windows and the focus is on such a window.